D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > This is no longer a technical constraint that we face. I don't think this was ever a thing. - Ok, lets do it with the symlink thing. REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL

D18006: Include only the largest size for the "Next" wallpaper

davidedmundson added a comment. I said it's roughly unchanged, we resize to the uncropped version of the image. --- As per IRC discussion yesterday. We can do it in the extra wallpapers, and see how that goes, lets not change "Next" this release. REPOSITORY R31 Breeze REVISION D

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. You have 4 possible states: Icon is taller and text is one line Icon is taller and text is multi-line Text is taller and text is one line Text is taller and text is multi-line Changing font sizes is moving you between them, but that's just a side

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49209. rooty added a comment. Fix lower border cutoff for fonts > 10 pt REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49208&id=49209 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1797

D17975: [Notifications] Add padding to notifications

filipf added a comment. Last diff is much better in general, but Noto Sans 11pt seems to cause problems F6539442: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham,

D17975: [Notifications] Add padding to notifications

rooty added a comment. >> How do we get the icon size to increase in proportion to increasing font size > > See units.cpp in plasma-framework. It's complex. I don't think that's a relevant topic you need to go down Yeah, also I'm not sure it's the right approach - icons might

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. > Is there a way to give the icon itself padding? I've been using anchors Yes, but if you're padding the icon by moving it then you need to set the window height to Math.max(sizeOfIcon, sizeOfText) needs to be Math.max(sizeOfIcon + 2*padding,

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49208. rooty added a comment. Correct padding with just icon + heading + no text, make icon padding even for 10 pt sized fonts other than Noto Sans REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49132&i

D18032: Fix USB view

alexandref updated this revision to Diff 49207. alexandref added a comment. This patch contains the full sync with usb.ids from www.linux-usb.org REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18032?vs=48843&id=49207 REVISION DETAIL https://phabricat

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391008 , @filipf wrote: > ^ Yes, it's important to note that additional (and unwanted) padding underneath the icon can happen with master, while this patch can add the same above the icon. From my layman's unders

D17975: [Notifications] Add padding to notifications

filipf added a comment. ^ Yes, it's important to note that additional (and unwanted) padding underneath the icon can happen with master, while this patch can add the same above the icon. From my layman's understanding, there is nothing quite solid and absolute values are based on. REPOSITOR

D18172: Use app specific config after QApplication constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R124:9cb4aea3d23f: Use app specific config after QApplication constructor (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18172?vs=4

D18032: Fix USB view

davidedmundson added a comment. Yes please. Our bundled version is only used if the distro doesn't provide it's own version. So they should be in sync. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 To: alexandref, #plasma, cfeck, davidedmundson Cc:

D18172: Use app specific config after QApplication constructor

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Used to print a warning Now doesn't REPOSITORY R124 System Settings BRANCH m

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#390875 , @ngraham wrote: > With this patch: F6539252: With patch.png TLDR: Yup, but that's only **the tip of the iceberg** (of the problems that plague //both master

D18145: Add an X-DocPath link to the Activities KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4110ed27c126: Add an X-DocPath link to the Activities KCM (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18145?vs=49126&id=49197 REV

D18168: [WIP] [Digital Clock] Embed date formatting variable documentation

Zren created this revision. Zren added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Assuming D18019 is merged, this would: - Provides an

D17975: [Notifications] Add padding to notifications

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. If I use `notify-send` to create a simple notification, it's unfortunately a regression compared to what we have right now. Checkout the uneven top and bottom padding on the ico

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

ngraham added a comment. @tagorechandanreddy, can you provide us with your email address? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13868 To: tagorechandanreddy, #plasma, davidedmundson Cc: ngraham, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen,

D18032: Fix USB view

alexandref added a comment. I do not have commit access. I added the USB IDs that matched my machine just to validate the change. I can sync with the Linux-USB is that is useful. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 To: alexandref, #plasma, cfec

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

ngraham added a comment. In D17921#389697 , @broulik wrote: > > Actually my proposal is to always show the text on the button, so you wouldn't need to drag it to see the text. > > And then people will complain even more about this "useless bu

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. In D17906#389914 , @mart wrote: > I wonder if it shouldn't be something in the future eventually part of the theme, I see things like menu font and toolbar font in fonts kcm as something completely obsolete, while those

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. In D18019#390363 , @Zren wrote: > I played around with a prettier looking example table. > > F6538091: 2019-01-10___02-37-24.png > F6538098: 2019-01-10___02-42-25.png

D18159: Fix patch to not delete defualt activity

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ae8483efa40f: [Activities KCM] Fix patch to not delete default activity (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18159?vs

D18159: Fix patch to not delete defualt activity

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So sorry for this! I swear I tested this and it worked for me somehow. I even have a screenshot to prove it: https://i.imgur.com/kD5praI.png The bad commit went into the `Plasma/5.12`

D18159: Fix patch to not delete defualt activity

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Patch referenced an id which didn't exist BUG: 397887 TEST PLAN Had one activity, was disabled Had two, both we

D17906: [kirigami] Do not use light font styles for headings (2/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5d392cb79f9: [kirigami] Do not use light font styles for headings (2/3) (authored by filipf, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. Yep, will do. We have other diffs for those. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks, mart Cc: fabianr, rooty, #frameworks, ngra

D17694: Support a tooltip on a MouseArea

This revision was automatically updated to reflect the committed changes. Closed by commit R858:a24b4e4de240: Support a tooltip on a MouseArea (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17694?vs=47858&id=49165

D18032: Fix USB view

davidedmundson added a comment. Did you manually change the usb ID's or sync with: http://www.linux-usb.org/usb.ids ? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 To: alexandref, #plasma, cfeck, davidedmundson Cc: davidedmundson, plasma-devel, kva

D18032: Fix USB view

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff. Do you have commit access? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 To: alexandref, #plasma, cfeck, davidedmundson Cc:

D18150: Unbreak the AboutPage layout on smaller devices

This revision was automatically updated to reflect the committed changes. Closed by commit R169:de624a35bd52: Unbreak the AboutPage layout on smaller devices (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18150?vs=49143&id=49158 REVISIO

D18019: [Digital Clock] Add ability to set a custom date format string

davidedmundson added a comment. I think these changes ultimately come down to two questions: **1) Is it something we actually want to customise at a per-plasmoid level, or is it a hack round something else? ** I quite like ndavis's reply. > user might prefer to use ISO date form

D18155: Custom date format in DigitalClock plasmoid

karpenyamichael abandoned this revision. karpenyamichael added a comment. Ok, thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18155 To: karpenyamichael, davidedmundson Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBo

D18155: Custom date format in DigitalClock plasmoid

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Thanks for the work, but there's already a patch on phab with a discussion: D18019 REPOSITORY R120 Plasma Workspace REVISIO

D18155: Custom date format in DigitalClock plasmoid

karpenyamichael created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. karpenyamichael requested review of this revision. REVISION SUMMARY Currently the date is displayed in three different styles. I has add another one which can be edited by user. REPO

D18150: Unbreak the AboutPage layout on smaller devices

leinir added a comment. In D18150#390493 , @apol wrote: > Can you show a screenshot of before/after so I understand? So far it looks a bit random. Well, the previous state was "crash" so i /could/ take a shot of an empty desktop or a bac

D18150: Unbreak the AboutPage layout on smaller devices

apol added a comment. Can you show a screenshot of before/after so I understand? So far it looks a bit random. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18150 To: leinir, apol, mart, #kirigami Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. so, if this is pushed, the same thing should happen at the same time to the corresponding plasma components REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma,

D17659: Set parent window for dialogs

volkov added a comment. Oh, I see. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D18150: Unbreak the AboutPage layout on smaller devices

leinir created this revision. leinir added reviewers: apol, mart, Kirigami. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, if the about page is scaled down past a certain width (common on

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

McPain added a comment. In D17689#379900 , @hein wrote: > Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019. ping? REPOSITORY R119 Plasma Desktop REVISION DE

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49137. Zren edited the summary of this revision. Zren added a comment. Translate the "Time Format Documentation" link. Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated). Place the 2 links below the text field

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a `plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on all panels/screens) were bound to, so the user only had to configur