D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. I think some users may want to have a separate date format for their clock than the rest of the system. A user might prefer to use ISO date format with only the last 2 digits of the year in their clock because it saves space, but they might prefer to use regular ISO d

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389613 , @davidedmundson wrote: > BTW, if you want a neater solution: (though consider this optional) > Instead, use Layout.topMargin on the titleBar and Layout.bottomMargin on the lowerPart. I love it

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. BTW, if you want a neater solution: (though consider this optional) At the moment you're moving mainLayout about and then doing maths on the window height to make sure we get the same padding underneath. Instead, use Layout.topMargin on the titleBar an

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. @filipf The media player situation was very different. This won't break anything. @rooty ((bodyText.lineCount > 1) ? 0.5 : ((bodyText.lineCount == 0) ? 0 : 2) * units.smallSpacing))) There's a logic error. I'll rewrite it so you can see it.

D17975: [Notifications] Add padding to notifications

rooty added a comment. > I wouldn't want the attitude of "breaking other themes is unfortunate, but.." becoming a pattern because openness to customization is our main selling point. You've made your point. But allow me to flesh it out - it seems we've reached an impasse; in simple ter

D17975: [Notifications] Add padding to notifications

rooty added a comment. @davidedmundson I've tried using implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 ? units.iconSizes.large : 0, (mainLayout.height + ((bodyText.lineCount > 1) ? 0.5 : ((bodyText.lineCount == 0) ? 0 : 2) * units.smallSpacing))) // Add units.

D17975: [Notifications] Add padding to notifications

filipf added a comment. In D17975#389584 , @ngraham wrote: > So what's going on here? Other themes add more padding? If so, I don't see how that's something we can possibly account for, and that shouldn't affect our ability to improve our own st

D17154: Go back to SCSS

ngraham added a comment. Awesome, thanks a lot David! REPOSITORY R98 Breeze for Gtk BRANCH breeze-gtk-sass (branched from master) REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson Cc: bshah, cgiboudeaux, dav

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389580 , @filipf wrote > I'd much rather if there was some padding added in Breeze and then you only fix the wrong spacing to right of the notification. Even if that wouldn't work, I don't get the sense we've ful

D17975: [Notifications] Add padding to notifications

ngraham added a comment. So what's going on here? Other themes add more padding? If so, I don't see how that's something we can possibly account for, and that shouldn't affect our ability to improve our own stuff. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.

D16170: [Device Notifier] Restore busy indicator

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this works great. REPOSITORY R120 Plasma Workspace BRANCH arc_busyindicator (branched from master) REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma

D17975: [Notifications] Add padding to notifications

filipf added a comment. In D17975#389575 , @rooty wrote: > Breaking other desktop themes is unfortunate ... It's a bit more than unfortunate. Similar things have happened recently e.g. with the new media player icons and with the network

D17154: Go back to SCSS

davidedmundson added a comment. I've git filter-branch'd Alex's github branch so the root commit's now match ours. Then merged that into master. History graph still looks like quite a mess, but then that's a reflection of reality :) - I'll wait a day for some other git p

D17975: [Notifications] Add padding to notifications

Codezela added a comment. In D17975#389576 , @rooty wrote: > In D17975#389567 , @Codezela wrote: > > > why every notification width is too wide > > why its not resize depends on the content on it

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389567 , @Codezela wrote: > why every notification width is too wide > why its not resize depends on the content on it with some little padding what do you mean? the width of the entire notification? RE

D17975: [Notifications] Add padding to notifications

rooty added a comment. > Wouldn't it be better to somehow add padding globally? Not really feasible because you don't necessarily want padding everywhere (for example, Adapta does this and i think it looks unsightly) F6536644: adapta-popup.png Ad

D17975: [Notifications] Add padding to notifications

Codezela added a comment. why every notification width is too wide why its not resize depends on the content on it with some little padding REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham Cc: Codezela, abetts, filipf

D17975: [Notifications] Add padding to notifications

filipf added a comment. This is what I get when I test on 2 of my machines: F6536633: Screenshot_20190109_001429.png F6536634: Screenshot_20190109_001555.png F6536638: Screenshot_20190109_000551.png

D17975: [Notifications] Add padding to notifications

davidedmundson added inline comments. INLINE COMMENTS > hein wrote in NotificationItem.qml:33 > Adding 1.75 pixels is just too arbitrary (and not an even number, and not > scaled by device pixel ratio). Much better. Only part I don't understand, then ship it! from me. Assuming there's no icon

D18005: Include only the largest size for each wallpaper

ngraham added a comment. In D18005#389553 , @davidedmundson wrote: > If we're going to save it, we could save the post-scaled version which would nullify the increased loading cost argument...and it would be a prerequisite for having a single w

D18019: [Digital Clock] Add ability to set a custom date format string

abetts added a comment. Is there a way that the custom date setting can be in its own window pop up instead of building into the KCM and pushing down the control that's below this setting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #pl

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. Darn. Thanks Christoph. If global changes are currently impossible due to lack of support in Qt, I think this is a reasonable approach for now, since it's the most prominent place where formatted times and dates are actually displayed in the UI. Therefore +1

D18019: [Digital Clock] Add ability to set a custom date format string

cfeck added a comment. Bug 340982 is about system-wide locale format changes. Qt currently does not have a way to customize its internal CLDR database. This change is indeed only about the Plasma clock, somewhat a workaround for the bug. REPOSITORY R120 Plasma Workspace REVISION DETA

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#389443 , @ngraham wrote: > This is no longer WIP, right? Oh so I can rename it? Sure! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngr

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > Could Plasma always copy the used wallpaper to some location and link to that? "Could it" yes. "Does it" no. If we're going to save it, we could save the post-scaled version which would nullify the increased loading cost argument...and it would

D18005: Include only the largest size for each wallpaper

ngraham added a comment. Does @cfeck's idea to turn the smaller sizes into symlinks make sense as a transitional step to preserve the user experience for people who are current users of these wallpapers? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from mast

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > any ideas on this front? >> [Containments][11][Wallpaper][org.kde.image][General] >> Image=file:///home/opt/kde5/share/wallpapers/FallenLeaf/contents/images/1280x1024.jpg Apparently we do store by full path which is quite a good argument for

D18005: Include only the largest size for each wallpaper

filipf added a comment. Could Plasma always copy the used wallpaper to some location and link to that? This is actually an annoyance irrespective of this discussion, if you move your wallpaper on the disk you lose the wallpaper. REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest

D18005: Include only the largest size for each wallpaper

GB_2 added a comment. @cfeck had a good idea: In D18005#387519 , @cfeck wrote: > Maybe symlinking all to the largest version? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL http

D18093: Calculate screen scaling dynamically, so it always fits to the page

ngraham added a comment. Ahh, nice idea. +1 on the concept. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D17402: [Device Notifier] Disable the possibility to unmount the root partition

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1a5507bd57a: [Device Notifier] Disable the possibility to unmount the root partition (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17402?vs=47024&id=49038#toc REPOSIT

D18005: Include only the largest size for each wallpaper

ngraham added a subscriber: mart. ngraham added a comment. So it sounds like our only technical blocker is that we don't want people who are using a wallpaper whose small sizes disappear on disk to get an ugly black background. @davidedmundson or @mart, any ideas on this front? REPOSITORY

D18005: Include only the largest size for each wallpaper

filipf added a subscriber: rooty. filipf added a comment. It's a total non-issue. @rooty and I have been shifting through loads of wallpapers in the past month or so and it hasn't even occurred to us that this (image editor vs. Plasma cropping) might even be a thing. The difference is minor

D18005: Include only the largest size for each wallpaper

ngraham added a comment. FWIW I agree that the image editor scaling vs Plasma scaling is a non-issue. Even in the worst-case scenario, the only distinguishable differences are when you deliberately do a flip-between-them comparison. For most, the differences are negligible and non-regressive

D17402: [Device Notifier] Disable the possibility to unmount the root partition

ngraham accepted this revision. ngraham added a comment. Ship it! REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg, davidedmundson, ngraham Cc: abetts, ngraham, broulik, plasma

D18005: Include only the largest size for each wallpaper

ngraham added a comment. In D18005#388044 , @rikmills wrote: > Instead Plasma should perhaps recognise that the image has gone, and seek and apply whatever single larger size now exists. In D18005#388048

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. Thanks for this one too ! I forgot to mention this third patch: D16170 :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #

D17154: Go back to SCSS

ngraham added a comment. Hmm, so what's our path forward here? What's the best way to merge this while preserving some semblance of history and state? REPOSITORY R98 Breeze for Gtk BRANCH breeze-gtk-sass (branched from master) REVISION DETAIL https://phabricator.kde.org/D17154 To: ge

D17127: [Device Notifier] Keep the device label & icon after unmounting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb3237987b26: [Device Notifier] Keep the device label & icon after unmounting (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17127?

D18080: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18080 To: aacid, apol Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. This is no longer WIP, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham Cc: abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia added a comment. It is a followup and extension of https://phabricator.kde.org/D17682 Basically it is possible that you have 3-4 monitors and only 2.5 or so are visible, because they don't fit in the dialog. This patch makes sure they are all visible. The previous patch just redu

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. Thank you very much for taking a look. If you have a bit of time, I have two other patches about the device notifier that have been waiting for a while: D17402 and D16212 . REPOSITORY R120 P

D17154: Go back to SCSS

davidedmundson accepted this revision. davidedmundson added a comment. We should try to see how we can merge this properly Effectively it's a revert - and there's relevant tracking in the github history here. I'd rather not just have a massive patch that changes everything. REPOSITORY

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added a comment. In D18078#389037 , @filipf wrote: > As a further step I suggest to remove the yellow tulips (Blooming Flowers) wallpaper because we have enough flowers. That wallpaper is also somewhat busy in the bottom part. > > F6

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added a comment. > +100 > (and we should push more on distros to have this installed by default Indeed! Manjaro already does. See also: - T10219: Ship the plasma-workspace-wallpapers package by default in Neon - T10218: Ship the

D17154: Go back to SCSS

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This has been working fine in my testing. I haven't noticed any overt regressions. Technically it looks fine to me too now. It would be nice to get some more testing from others before sh

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. In D17975#389141 , @abetts wrote: > I would be in favor of more consistency wherever possible. However if we can't get that, I would still vote for having these changes applied to notifications rather than not have them

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. However, to @mart's point, the custom format chooser is systemwide on macOS, not limited to their digital clock equivalent. Systemwide does indeed seem like the more appropriate place, but I'm not sure if that would be compatible with Qt's locale system though? REPO

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. "Very geeky options" aren't generally a problem as long as they're not the default setting. In fact, they're one of the big things that KDE is known for so in principle I think this is great as long as it doesn't get in the way of people who are not very geeky.

D18093: Calculate screen scaling dynamically, so it always fits to the page

ngraham added a comment. A bit more context would be helpful here. :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 49002. amantia added a comment. Restore REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48998&id=49002 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FILES kcm/src/decl

D18100: Calculate screen scaling dynamically, so it always fits to the page

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Don't reset the moved display position This fixes the problem that after moving a display, clicking on another one and clicki

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 48998. amantia added a comment. - Don't reset the moved display position REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48953&id=48998 BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.o

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388829 , @ndavis wrote: > Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget? The time format docs mentio

D17975: [WIP, Notifications] Add padding to notifications

abetts added a comment. In D17975#388981 , @filipf wrote: > I have some concerns about this. Mostly it's about visual consistency and notifications having different padding than other plasmoids. Notice how there's currently more or less equal di

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

abetts added a comment. +1 I like the selection so far. Just ping me when you need an official approval. Thank you for your work! REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: abetts, mart, rooty, pla

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 282 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/282/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 08 Jan 2019 13:48:43 + Build duration: 4 min 37 sec and counting CONSOLE OUTPUT [...truncated 2461 lin

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Note: scaling **Almond Blossom** and **Two Labrador Retriever Puppies** made no sense, these pics have great compression & turned out bigger when shrunk. As a further step I suggest to remove the yellow tulips wallpaper because we have enough flowers. F653590

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf updated this revision to Diff 48962. filipf added a comment. Scale oversized wallpapers to 5K; crop the NASA wallpaper in order to remove a visual annoyance REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18078?vs=48929&id=48962 BRANCH n

D17127: [Device Notifier] Keep the device label & icon after unmounting

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's a very clever and neat solution. REPOSITORY R120 Plasma Workspace BRANCH arc_notifier_labels (branched from master) REVISION DETAIL https://phabricator.kde.org

Plasma 5.14.4

Plasma 5.14.5 is now released https://www.kde.org/announcements/plasma-5.14.5.php

D17975: [WIP, Notifications] Add padding to notifications

filipf added a comment. I have some concerns about this. Mostly it's about visual consistency and notifications having different padding than other plasmoids. Notice how there's currently more or less equal distance to the left of Audio Volume and to the left of the album cover icon? F6

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. wow scrolling down took a while haha sure fine with me, crop em (except for Lake Bled?) REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: mart, rooty, plasma-devel, kvanton, jraleigh, GB_2,

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Thanks :) Trying to have more distros include the package is the plan. + I have some good news, by scaling down the really big wallpapers added here to 5K we save 10 MiB. @rooty, that okay? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabri

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.11 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.11/18/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 08 Jan 2019 10:53:01 + Build duration: 44 min and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/16/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 08 Jan 2019 10:52:51 + Build duration: 41 min and counting CONSOLE OUTPUT [...trunc

D18092: Backport "Show unconnected displays at the right side of the main screen"

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/D17682 REPOSITORY R104 KScreen BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18092 AFFECTED FILES kcm/src/declar

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REPOSITORY R104 KScreen BRANCH backport_screen_to_right REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FILES kcm/src/declarativ

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/2/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 08 Jan 2019 10:49:22 + Build duration: 8 min 6 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/15/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 08 Jan 2019 10:49:22 + Build duration: 6 min 39 sec and counting CONSOLE OUTPUT

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388876 , @mart wrote: > is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date for

D18018: [Digital Clock] Add ability to change first day of week

mart added a comment. -1 on this in particular +1 for having it system wide REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: mart, abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, Zre

D18019: [Digital Clock] Add ability to set a custom date format string

mart added a comment. is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date format setting? (and with also a graphical ui to generate this) REPOSITORY R120 Pla

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

mart added a comment. +100 (and we should push more on distros to have this installed by default, they often don't to save space on the iso :/ REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: mart, rooty, plasm

Re: Minutes meeting , week 2

On lunedì 7 gennaio 2019 13:46:56 CET Bhushan Shah wrote: > Hello everyone! > > This is first meeting of year 2019, happy new year! > couldn't make to the meeting, so here's my part: Kirigami * better transitions between ApplicationWindow showgui and not * don't show the drawer handle when it sh

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. This patch fixes a regression that appeared in this cycle, that would be good if someone could review it so that we don't ship it with 5.15. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17127 To: thsurrel, #plasma Cc: filipf, pl