D17758: Disable KDE ServerDecoration on Qt > 5.12

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I still have Qt 5.11, so I'll try to compile the change and give it a try. INLINE COMMENTS > kwaylandintegration.cpp:127 > + > +if (QLibraryInfo::version() >= QVersionNumber(5, 12

D17751: Add shadow to Hour's hand

ndavis added a comment. In D17751#381431 , @shubham wrote: > How could the shadow appearance be fixed? In breeze icons? No, the SVG that the analog clock uses is in plasma-framework REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D17751: Add shadow to Hour's hand

shubham added a comment. How could the shadow appearance be fixed? In breeze icons? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17751 To: shubham, mart, hein, #vdg, ngraham Cc: abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot

D17751: Add shadow to Hour's hand

abetts added a comment. In D17751#381351 , @ngraham wrote: > Gotta fix the shadow appearance before we can land this. > > If we consider where the light is actually coming from, probably we need for the center part to cast a shadow too.

D17751: Add shadow to Hour's hand

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Gotta fix the shadow appearance before we can land this. If we consider where the light is actually coming from, probably we need for the center part to cast a shadow too.

D17758: Disable KDE ServerDecoration on Qt > 5.12

davidedmundson created this revision. davidedmundson added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY XdgDecoration is built into QtWayland 5.12. Running two interfaces to do

D17677: Add workaround for gtk file chooser filter patterns

This revision was automatically updated to reflect the committed changes. Closed by commit R838:66eb2fe654b9: Add workaround for gtk file chooser filter patterns (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D17752: Remove full representation of analog clock

davidedmundson added a comment. > User can click in the system tray instead. Not if they have the analog clock in the system tray instead REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17752 To: shubham, hein, mart, #vdg Cc: davidedmundson, plasma-de

D17751: Add shadow to Hour's hand

davidedmundson added a comment. From the linked bug report (and your screenshot) > You're right about the typo, but it doesn't seem that trivial. The shadow shadow appears all offset (on the default breeze theme at least) The hour hand shadow starts several px below the hour hand RE

D17752: Remove full representation of analog clock

shubham created this revision. shubham added reviewers: hein, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Full representation of analog clock showed a calendar, which does not makes sense for two reas

D17751: Add shadow to Hour's hand

shubham created this revision. shubham added reviewers: mart, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. TEST PLAN Add new analog clock widget from "Add widget" on right click context m REPOSITORY R120 Plasma Works

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added a comment. David, can you accept this revision then? I'll push it to Plasma/5.14 branch only. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17677 To: jgrulich, broulik Cc: heikobecker, ngraham, davidedmundson, pla

D17738: Use KFileWidget instead of QFileDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R838:9f0c704e96ea: Use KFileWidget instead of QFileDialog (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1773