D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-12-21 Thread Mélanie Chauvel
achauvel updated this revision to Diff 47987. achauvel added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Uses new function added in https://phabricator.kde.org/D17726 REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kd

D17154: Go back to SCSS

2018-12-21 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. @gepardo I'm very sorry that you haven't gotten any real feedback on this yet. :( The maintainer seems to have vanished. I will CC come more people

D17677: Add workaround for gtk file chooser filter patterns

2018-12-21 Thread Nathaniel Graham
ngraham added a comment. Is there a new version of this patch somewhere else? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17677 To: jgrulich, broulik Cc: heikobecker, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel,

D17725: [RFC] Fix model updates in RunnerMatchesModel

2018-12-21 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > runnermatchesmodel.cpp:225 > emitDataChange = true; > - > -break; > +m_matches[row] = matches.at(row); > } Maybe it would make sense to only emit the ones that changed? > runnermatchesmodel.cpp:230 > +

D17725: [RFC] Fix model updates in RunnerMatchesModel

2018-12-21 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY RunnerMatchesModel is backed by a list. When this list changes RunnerManage

D17704: Copy to clipboard always copy English texts

2018-12-21 Thread Nathaniel Graham
ngraham added a comment. Thanks @gregormi. I could see a split button working well here. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D17704: Copy to clipboard always copy English texts

2018-12-21 Thread gregormi
gregormi added a comment. Hi, here is the discussion around my the patch that introduced the Copy button: https://phabricator.kde.org/D7087 Originally, I proposed the untranslated English text. Those are the reasons that lead to the fact that we have the translated version: https://phab

D17706: Fix lock screen focus

2018-12-21 Thread Andres Betts
abetts added a comment. > **abetts ** > It is easy to reproduce when more than one monitor is connected, you must set the cursor on any monitor except the first one and block the screen with hot keys, after which you will notice that the focus of the password entry remains on the first sc

[kwrited] [Bug 386067] Use seperate notifications for each message

2018-12-21 Thread Sefa Eyeoglu
https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #4 from Sefa Eyeoglu --- Nice! If really need to look into KF5. If I would have known, that it is just one flag I would have created a patch months ago. Thank you anyway David. -- You are receiving this mail because: You are the assignee f

D17717: Remove KDE3 reference in kdeeject

2018-12-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R126:e8585dba97b7: Remove KDE3 reference in kdeeject (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17717?vs=47924&id=47954 REVI

D17652: Fix logic error in kioclient noninteractive argument handling

2018-12-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R126:14198396c974: Fix logic error in kioclient noninteractive argument handling (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

[kwrited] [Bug 386067] Use seperate notifications for each message

2018-12-21 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=386067 David Edmundson changed: What|Removed |Added Latest Commit||https://commits.kde.org/kwr

D17721: Don't group wall notifications

2018-12-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R109:c36bf41537e6: Don't group wall notifications (authored by davidedmundson). REPOSITORY R109 KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17721?vs=47951&id=47952 REVISION DETAIL

D17721: Don't group wall notifications

2018-12-21 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BUG: 386067 REPOSITORY R109 KWriteD BRANCH master REVISION DETAIL ht

[kwrited] [Bug 386067] Use seperate notifications for each message

2018-12-21 Thread Sefa Eyeoglu
https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #2 from Sefa Eyeoglu --- If I run "wall Test" multiple times the messages are combined in one single notification, without any seperator. -- You are receiving this mail because: You are the assignee for the bug.

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.11 - Build # 18 - Unstable!

2018-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.11/18/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 21 Dec 2018 08:04:26 + Build duration: 14 min and counting JUnit Tests Name: (root) F

KDE CI: Plasma » kscreen » stable-kf5-qt5 FreeBSDQt5.11 - Build # 16 - Fixed!

2018-12-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20FreeBSDQt5.11/16/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 21 Dec 2018 08:04:27 + Build duration: 13 min and counting