D17533: Make the button's purpose more clear

2018-12-16 Thread Andras Mantia
amantia abandoned this revision. amantia added inline comments. INLINE COMMENTS > ngraham wrote in kaccess.cpp:870 > Let's use `xi18nc()` for this: > > `xi18nc("@info", "%1", question)` That looks weird., as it creates a translatable string for no reason. Obviously best would be to update all

D17622: [Panel Edit Mode] Show screen edge button and panel size button tooltips immediately after click

2018-12-16 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2ea223d5b56a: [Panel Edit Mode] Show screen edge button and panel size button tooltips… (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://p

D17533: Make the button's purpose more clear

2018-12-16 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > kaccess.cpp:870 > + QStringLiteral(" ") + i18n("These > AccessX settings are needed for some users with motion impairments and can be > configured in the KDE System Settings. You can also turn them on and off w

D17622: [Panel Edit Mode] Show screen edge button and panel size button tooltips immediately after click

2018-12-16 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This sets the delay of the tooltips added in D17323 to 0, so th

D17533: Make the button's purpose more clear

2018-12-16 Thread Andras Mantia
amantia added a comment. Yes, most questions can be answered with Yes/No, and still I'd say it is better to use Yes/No, instead of OK/Cancel. OK/Cancel is rather useless, although widely used, I know... I made the question text bold now, and unfortunately as I said I don't want to spend mo

D17533: Make the button's purpose more clear

2018-12-16 Thread Andras Mantia
amantia updated this revision to Diff 47661. amantia added a comment. Make the question text bold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47590&id=47661 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.k

D17615: [FolderView] Fix blurry icon labels

2018-12-16 Thread Root
rooty added a comment. my bad, i just didn't copy the entire contents of the plasma-desktop/containments/desktop/package/contents/ui/code folder off of github (just the FolderItemDelegate.qml), it works fine now that it's all up to date REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

D17615: [FolderView] Fix blurry icon labels

2018-12-16 Thread Root
rooty added a comment. yup i rename it and it turns all blurry, irrespective of where the panel is or how much the icons have been selected / moved around REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615 To: filipf, #plasma Cc: rooty, plasma-devel, GB_2,

D17615: [FolderView] Fix blurry icon labels

2018-12-16 Thread Filip Fila
filipf reclaimed this revision. filipf added a subscriber: rooty. filipf added a comment. I'm reopening this because in my tests 3526334e8234 does not fix icons becoming blurry when changing icon sizes and @rooty is

D16918: [dimdisplay] Do not change screen brightness on invalid values

2018-12-16 Thread Anthony Fieroni
anthonyfieroni added a comment. @broulik, @thsurrel any other ideas or to commit it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, a