D17615: [FolderView] Fix blurry icon labels

2018-12-15 Thread Filip Fila
filipf abandoned this revision. filipf added a comment. Okay, so apparently 3526334e8234 already fixed the blurry labels, sorry. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615

D17615: [FolderView] Fix blurry icon labels

2018-12-15 Thread Filip Fila
filipf added a comment. Side effect: fonts are thicker looking now, although they don't correspond to styles such as Medium or Bold. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615 To: filipf, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, les

D17615: [FolderView] Fix blurry icon labels

2018-12-15 Thread Filip Fila
filipf added a comment. Disclaimer: I'm really new with code so I don't know if this is the right way to solve the problem, but at the very least I think it shows this if clause is causing issues. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615 To: fil

D17615: [FolderView] Fix blurry icon labels

2018-12-15 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Commit 5fca2b32ce5b introduced a bug which makes some ic

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. In D14542#376755 , @hein wrote: > @ngraham From a UX perspective your comments make perfect sense, but unfortunately KWin currently has a flat list of desktops divided by number of rows so

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-12-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=350365 hiwatari.se...@gmail.com changed: What|Removed |Added CC||hiwatari.se...@gmail.com --- Comment

D17533: Make the button's purpose more clear

2018-12-15 Thread Nathaniel Graham
ngraham added a comment. All dialogs ask a question that can be answered with a yes or a no. The problem is that most users don't read dialog box text--especially very long text, like the kind presented here. They do generally read the dialog box button labels though, which is why it's so im

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1ae7f9fece38: Change panel edit mode icon from from a hamburger icon to a configure icon (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-15 Thread David Edmundson
davidedmundson added a comment. > Cannot read property 'applet' of null Which means currentApplet is null. When is that set? Were you checking if it was visible afterwards? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg

D17598: Improve "No internet connection!" error message

2018-12-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 47625. ngraham added a comment. Improve message REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=47610&id=47625 BRANCH better-no-connectivity-error-message (branched from master) REVISION DETA

D17598: Improve "No internet connection!" error message

2018-12-15 Thread Aleix Pol Gonzalez
apol added a comment. I wonder if "app" is the right term. How about "could not load the featured applications"? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: pino, plasma-devel, GB_2, rag

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-15 Thread Björn Feber
GB_2 updated this revision to Diff 47615. GB_2 added a comment. Remove unneeded line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46739&id=47615 REVISION DETAIL https://phabricator.kde.org/D17321 AFFECTED FILES toolboxes/paneltoolbo

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-15 Thread Björn Feber
GB_2 added a comment. In D17410#374062 , @davidedmundson wrote: > > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... > > Use console.log to check your code is bein