D17561: Fix memory leak in notifications applet if only tracking jobs

broulik added inline comments. INLINE COMMENTS > Jobs.qml:69 > if (error == 1) { > return > } What about here? > Jobs.qml:75 > if (!message && !infoMessage) { > return > } and here? REPOSITORY R120 Plasma

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 47546. hein added a comment. Fix initial state REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=47240&id=47546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES kcmkwin/kwindeskto

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein added a comment. @ngraham: From a UX perspective your comments make perfect sense, but unfortunately KWin currently has a flat list of desktops divided by number of rows. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltosca

D17571: Fix pixmap scaling on HiDPI screens

emateli added a comment. There are no side effects from what I can tell. REPOSITORY R106 KSysguard BRANCH hidpi REVISION DETAIL https://phabricator.kde.org/D17571 To: emateli, mlaurent, davidedmundson Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D17571: Fix pixmap scaling on HiDPI screens

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Adds the usual flag needed for HiDPI screens. Usual flag, usual reply. Please be sure to open every dialog / config screen / etc that you can find. Setting this

D17571: Fix pixmap scaling on HiDPI screens

emateli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. emateli requested review of this revision. REVISION SUMMARY Adds the usual flag needed for HiDPI screens. REPOSITORY R106 KSysguard BRANCH hidpi REVISION DETAIL https://phabricator.kd

D17551: Take the scrollbar into account for the ScrollablePage margin

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17551 To: apol, #kirigami, mart, ngraham Cc: ngraham, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17562: Don't try to reposition the ScrollView when we get a faulty height

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17562 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17556: Make Status and Notification popup consistent with others.

abetts added a comment. In general, this patch makes it better. However, I feel that all the items are simply too close to the left edge. Can you add some padding or margin to the left? Maybe something like 5 px? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D17562: Don't try to reposition the ScrollView when we get a faulty height

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY BUG: 401960 TEST PLAN Tried as explained in the bug, can't see the issue anymore REPOSITORY

D17551: Take the scrollbar into account for the ScrollablePage margin

ngraham added a comment. This fixes the issue in Discover for me and doesn't seem to regress anything in Gallery. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17551 To: apol, #kirigami, mart Cc: ngraham, plasma-devel, dkardarakos, apol, davidedmundson, mart, hei

D17561: Fix memory leak in notifications applet if only tracking jobs

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There's an early return before the memory cleanup that happens at the end o

D17556: Make Status and Notification popup consistent with others.

loh.tar added a comment. Just my 2Cents > I think the zero left margin looks odd, it should at least align with the icons. > i think it should either be aligned to the left of the icons, or to the left of the text items I agree to both of you, but the title "Make Status a

D17527: [Chrome Bookmark Runner] Use QJsonObject directly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:434765e9fb97: [Chrome Bookmark Runner] Use QJsonObject directly (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17527?vs=47425&id=475

D17536: Make accessibility warning dialog usable again and fix event handling

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17536 To: amantia, #plasma_accessibility, #plasma, aacid, mart Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

mart added a comment. for it to be perfect looking, i think it should either be aligned to the left of the icons, or to the left of the text items REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma, mart, hein Cc: plas

D17557: Make accessibility warning dialog usable again

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D17467: digital-clock: Show events on initial expansion for all time zones

mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > another way you can try is to do it on Component.onCompleted: { } Yes I laready considered that. But when I tried your suggestion, I figured out what the real problem was that the events are initially not sh

D17557: Make accessibility warning dialog usable again

amantia created this revision. amantia added reviewers: Plasma Accessibility, Plasma, aacid. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH Plasma

D17557: Make accessibility warning dialog usable again

amantia added a comment. Backport to 5.12 branch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17467: digital-clock: Show events on initial expansion for all time zones

mart added inline comments. INLINE COMMENTS > mbehrendt wrote in CalendarView.qml:60 > No, the model initially seems to be an empty list. another way you can try is to do it on Component.onCompleted: { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17467

D17556: Make Status and Notification popup consistent with others.

shubham added a comment. @broulik In all others, if you notice it is 0 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D17556: Make Status and Notification popup consistent with others.

broulik added a comment. I think the zero left margin looks odd, it should at least align with the icons. Also, this was originally done so it doesn't shift around as you switch between applets and the list. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1

D17556: Make Status and Notification popup consistent with others.

shubham created this revision. shubham added a project: Plasma. Herald edited subscribers, added: plasma-devel; removed: Plasma. shubham requested review of this revision. REVISION SUMMARY 1. Remove the left margin. 2. Change '&' to "and". Before: F6474493: be.png

D17346: Support Bluetooth batteries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:2907d7f54c6e: Support Bluetooth batteries (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAS