D17217: Implement free memory notifier

davidedmundson added a comment. Given there is some negativity in the feedback I do want to point out that it's cool to still upload whatever to the KDE store/wider ecosystem. Not everything run in plasma needs to be from plasma; we go to great lengths to make sure that's the case. Ther

Re: Plasma 5.14.4

On 27.11.2018 18:17, Jonathan Riddell wrote: Plasma 5.14.4 is now released https://www.kde.org/announcements/plasma-5.14.4.php It was suggested to do a 5.14.4.1 respin of 'plasma-desktop' to include a patch for regression bug 401508 (the bug ticket does not mention that it can even crash the

Re: Conceptual changes to KScreen

On Sun, 25 Nov 2018 04:47:39 -0700 Roman Gilg wrote > From a user-facing standpoint there is not much change. Certain > display property a user manipulates manually via the KCM are now per > default persistent over all possible configurations of displays (i.e. > which displays

D17207: Use KPasswordLineEdit

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great and the code looks sane, thanks! REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D17207 To: broulik, jriddell, davidedmundson, ng

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

lueck updated this revision to Diff 46432. lueck added a comment. fix typo spotted by Yuri, thanks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17226?vs=46431&id=46432 REVISION DETAIL https://phabricator.kde.org/D17226 AFFECTED FILES doc/kcontrol/kcmsmserver/index.docbook To

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

yurchor accepted this revision as: yurchor. yurchor added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > index.docbook:110 > Finally, you can enter a colon (:) or comma > (,) > -separated list of applications that should not be saved in sessions, > +separate

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

lueck created this revision. lueck added reviewers: Plasma, Documentation. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY bump date + releaseinfo proofread fix wrong item name in

D17225: Update translation kcm docbook to plasma 5.14

lueck created this revision. lueck added reviewers: Plasma, Documentation. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY update according port of KCM to Qt Quick with https://phabr

D17217: Implement free memory notifier

ngraham added a comment. In D17217#367643 , @graesslin wrote: > I don't think that this is useful - sorry. I run out of memory about once every five years, so polling every five seconds is way too often and a waste of resources. On the other ha

D17217: Implement free memory notifier

graesslin added a comment. I don't think that this is useful - sorry. I run out of memory about once every five years, so polling every five seconds is way too often and a waste of resources. On the other hand the time when it happens polling 5 sec is way too low as then we are already dead.

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. Btw, It seems the gtk-cursor-theme-name option actually has no influence on GTK2 applications, so it probably wouldn't need to be written to the GTK2 config here. But then, the KCM does save it to the GTK2 config as well... REPOSITORY R98 Breeze for Gtk REVISION

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I agree with @abetts. The alignment changes are great, but I think it's a semantic error to use the title size and style for text that's essentially a glorified back button. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To:

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367366 , @fvogt wrote: > > The same happens already if one uses the GTK KCM though, as it will always write a cursor theme entry too. > > Yes, that can be unexpected - even by not changing the cursor theme e

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367565 , @ngraham wrote: > That's a pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=401507 That's not the full truth though. The cursor theme KCM will affect the default theme of the whole session

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. I don't really have an issue with the font alignment. I think where I am conflicted is the part where we want this text to have too many purposes. The label is big so as to mean that it is a page title. However, when we place this on a phone, the header text is huge.

D17212: Port to QQC2 and FormLayout

ngraham added a comment. Looking good code-wise! Could we take the opportunity to improve the layout too? This huge list of checkboxes is entirely left-aligned, with a huge gaping chasm of whitespace on the right. Seems like we could benefit from centering it as per the typical Kirigami

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. @abetts , @ngraham discuss :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46417. apol added a comment. ADd since REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46416&id=46417 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17216 AFFECTED FILES kirigami.qrc src/con

D17216: Move the about page from Discover to Kirigami

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in AboutPage.qml:102 > Not a huge fan of this, privacy-wise, also QtQuick doesn't do any caching on > its own I do agree it can read a bit weird. It's generally done on public emails though, I'm n

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46416. apol marked 5 inline comments as done. apol added a comment. Address Kai's comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46406&id=46416 BRANCH master REVISION DETAIL https://phabricator.kde

D17219: Fix group popup dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ed34cc5f181e: Fix group popup dialog (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17219?vs=46414&id=46415 REVISION DETAIL https://pha

D17219: Fix group popup dialog

hein created this revision. hein added a reviewer: davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Fixes regression introduced with ab26ebb18b74 : That diff conta

D17211: Port applet/containment configs to qqc2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release. The Positioning combobox shouldn't be so much much wider than the other comboboxes;

D17004: Always scroll views up when the fullrepr is collapsed.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:74ff6586944f: Always scroll views up when the fullrepr is collapsed. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17004?vs=45778&id=46413#toc REPOSITORY R119 Plasma Des

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

ngraham added a comment. In D17217#367544 , @McPain wrote: > Sometimes I see what happens if you're running out of memory and oom can't do anything - the whole system halts and only solution for this is hard reset with all unsaved data lost. >

D17217: Implement free memory notifier

McPain added a comment. In D17217#367545 , @abetts wrote: > Is having this feature an optional feature? Can it be turned off? I'll make the notification "disableable" tomorrow REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D17187: Set the default cursor theme to breeze_cursors

ngraham added a comment. In D17187#367348 , @wbauer wrote: > OTOH, this patch actually causes a mismatch if one changes the cursor theme in Plasma's cursor theme KCM. (it won't affect GTK applications, they will continue to use breeze...)

D17218: Fix removing first item in languages list

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Instead, we want to disallow removing when the count drops to 1. BUG:401473 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D17212: Port to QQC2 and FormLayout

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

broulik added a comment. I think that's because we're iterating `m_cookieToBusService` in that method and at the same time have `ReleaseInhibition` tamper with it. Perhaps taking a copy should fix that already: void PolicyAgent::onServiceUnregistered(const QString& serviceName) {

D17217: Implement free memory notifier

abetts added a comment. Is having this feature an optional feature? Can it be turned off? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17217 To: McPain, broulik, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D17217: Implement free memory notifier

McPain added a comment. In D17217#367525 , @ngraham wrote: > Thanks for all the work! > > ...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to dele

D17216: Move the about page from Discover to Kirigami

broulik added inline comments. INLINE COMMENTS > AboutPage.qml:102 > +Layout.maximumWidth: Units.iconSizes.medium > +source: "https://www.gravatar.com/avatar/"; + > Qt.md5(modelData.emailAddress) + "?d=404&s=" + Units.iconSizes.medium > +

D16890: [systemtray] Keep config entries after modifying

ngraham added a comment. If it's a Qt bug, our options are to fix it upstream, or work around it here with a comment in the code indicating the workaround and the Qt bug report. Can you add that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: an

D17217: Implement free memory notifier

ngraham added a reviewer: VDG. ngraham added a comment. Thanks for all the work! ...But is this actually useful or actionable for the majority of users? Free space is a fairly understandable concept: if you run out, you need to delete things to make more room before you can add more stuf

KDE Privacy Sprint - Find a date

Hey, We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen in March. We think at a sprint of five days. The main goal for the sprint is to locate privacy issues and after locating them hopefully fix them. Let's take the advantage to speak in person with multiple people of

Re: Plasma 5.14.4

Updating On 11/27/18, Jonathan Riddell wrote: > Plasma 5.14.4 is now released > https://www.kde.org/announcements/plasma-5.14.4.php >

D17217: Implement free memory notifier

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY FreeMemoryNotifier will warn when free RAM is running out. By default, it is 25% without swap spac

D17216: Move the about page from Discover to Kirigami

apol created this revision. apol added reviewers: Kirigami, mart, broulik. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Includes the AboutPage we're using in Discover for other Kirigami projects to use. It

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni added a comment. Yep, it's Qt bug. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham Cc: trmdi, mart, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D17211: Port applet/containment configs to qqc2

broulik added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D16890: [systemtray] Keep config entries after modifying

trmdi added a comment. In D16890#366015 , @anthonyfieroni wrote: > To commit it @mart @broulik ? I think that is not the root cause. You should fix the root cause instead of just a part of it. See my comment on https://bugs.kde.org/sho

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > mart wrote in main.qml:111 > can you put this in the commit description as well? How to get commit access? REVISION DETAIL https://phabricator.kde.org/D15333 To: McPain, #plasma, ngraham Cc: mart, davidedmundson, cfeck, plasma-devel, ragreen, P

D17213: Add support for settings portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Sandboxed applications usually don't have access to read kdeglobals configuration. For this reason we introduced Settings porta

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

anthonyfieroni added a comment. It looks like the problem is in dimming. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46398. mart added a comment. - initialize a proper size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46397&id=46398 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 AFFECTED FILE

D17211: Port applet/containment configs to qqc2

mart added a comment. oddly seems not all the pages to not animate... i fear they are trying to set anchors? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, al

D17211: Port applet/containment configs to qqc2

mart added a comment. F6444604: Screenshot_20181128_130459.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46397. mart added a comment. move text in tooltip REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46394&id=46397 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 AFFECTED FILES de

D17177: Drop tab-based UI for the about page

apol added a comment. Yes, yes, on it... REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17211: Port applet/containment configs to qqc2

broulik added a comment. Quirks I have found: - The "Filters" page in Folder View configuration doesn't get a size initially and only does when I resize the window - The transition animation is buggy, the "enterItem" isn't properly animated from what I can tell, just pops up right away

D17211: Port applet/containment configs to qqc2

apol added a comment. +1 cool! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17212: Port to QQC2 and FormLayout

mart added a comment. F6444563: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17212: Port to QQC2 and FormLayout

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY No big visible changes, but simplifies and modernizes the code TEST PLAN used all functionality of t

D17177: Drop tab-based UI for the about page

broulik added a comment. Wouldn't it make sense to provide an `AboutPage` in Kirigami (KF5::kirigami-whatever-that-can-be-tier-2 :D) like kxmlgui has it, for use in e.g. Itinerary and what not? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.

D17211: Port applet/containment configs to qqc2

mart added a comment. before: F6444531: Screenshot_20181128_113703.png after: F6444535: Screenshot_20181128_113712.png F6444538: Screenshot_20181128_113718.png REPOSI

D17211: Port applet/containment configs to qqc2

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY port the applet config dialogs and containments to QtQuickControls2 and Kirigami modernizing it, us

D17177: Drop tab-based UI for the about page

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Lovin' it - i also like how sort of... well, how little code there really is here, QML done absolutely the right way, only the presentation and that's it, nifty :) REPOSITORY R134 Discov

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46390. apol added a comment. Move report action back to the contextual actions REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46328&id=46390 BRANCH master REVISION DETAIL https://phabricator.

D17187: Set the default cursor theme to breeze_cursors

fvogt added a comment. > OTOH, this patch actually causes a mismatch if one changes the cursor theme in Plasma's cursor theme KCM. (it won't affect GTK applications, they will continue to use breeze...) There is no sync in any direction of icon themes, cursor themes and application them

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367118 , @fvogt wrote: > In D17187#367110 , @wbauer wrote: > > > Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e.

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. anyways, this can wait/can be discussed, the ones instead i would like to get in soonish are D17190 and D17191 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D171

D17207: Use KPasswordLineEdit

broulik created this revision. broulik added reviewers: jriddell, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - I now get the eye button to show the password I typed - Typing wrong password still