D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Right, I agree. In fact, that's how Kicker does it: the search field is focused by default, but if you mouse over a list item, then focus visually moves to the list. I'm supportive of doing that sort of thing here. Then the Kicker and Kickoff search fields would even

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

D17006: Compress calls to `updateSize`

hein created this revision. hein added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Repeater+Flow has no reliable way to transactionize/batch insertion, e.g. `Flow.positionCompleted` is useless in a function that ca

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important focus is. Making sure that the active element both has and looks like it has focus

D17005: Fix dismissing the Dashboard by clicking inbetween multi-grid categories.

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Or on category headers. BUG:400720 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17005 AF

D3236: Enables grouping and sorting settings in Icons Only Task Manager

hein added a comment. I'm very sorry this went unanswered for so long - for some reason the patch slipped through the cracks. Unfortunately I have to continue with bad news - those behaviors being hard-chosen in the ITM widget is by design choice, so I have to reject this patch. REPOSITORY

D17004: Always scroll views up when the fullrepr is collapsed.

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:400664 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17004 AFFECTED FILES applets/kickof

D17003: Fix mouse events being withheld from the scrollbar.

hein created this revision. hein added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY Fixes regression introduced in 48b32259e73f

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein added a comment. In D15855#362015 , @ngraham wrote: > @hein This broke the scrollbar for any views that are scrollable. Now the scrollbars don't accept clicks and drags anymore, and don't change on hover. Maybe the MouseArea doesn't pass on

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham added a comment. In D16988#362025 , @filipf wrote: > Hmm but it doesn't even need to be primarily argumented as a visual improvement. Can't we approach the focused/unfocused matters contextually? If I'm using Kickoff mostly to click on m

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. In D16988#361980 , @ngraham wrote: > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. @hein This broke the scrollbar for any views that are scrollable. Now the scrollbars don't accept clicks and drags anymore, and don't change on hover. Maybe the MouseArea doesn't pass on the mouse events to the ScrollArea underneath it or something? We can't shi

Re: Relicensing of file in plasma-phone-components

[Adding plasma-devel] Thanks Michael. On Sun, Nov 18, 2018 at 09:40:11PM -0500, Michael Eden wrote: > Thanks for catching this! > I'm OK with re-licensing or getting rid of libphonenumber. I do not > know of a good replacement, however. > On Sun, Nov 18, 2018 at 7:47 AM Bhushan Shah wrote: > > >

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. You know what, I tried this out and I like it. The differing line widths don't actually seem all that weird when actually using it for a a bit. I think this is fine. Other #VDG

Re: Relicensing of file in plasma-phone-components

(adding plasma-devel) Thanks Boudewijn! On Sun, Nov 18, 2018 at 01:56:14PM +0100, Boudewijn Rempt wrote: > Yes > > On zondag 18 november 2018 13:45:56 CET you wrote: > > Hello everyone, > > > > I am writing to you since you have commited to the > > plasma-phone-components/dialer/src/dialerutils

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham requested changes to this revision. ngraham added subscribers: chempfling, gladhorn. ngraham added a comment. This revision now requires changes to proceed. There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly

D16997: [kcm] Expose interface to control output property retention

ngraham added a comment. Visually, let's follow the existing formlayout style in the KCM and put the label to the left of the radio buttons rather than using a group box. Also, the two radio button labels shouldn't end with periods. I'll admit just looking at the new UI, it's not entirel

D16998: Remove the background gradient from icon view

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ed4367d86a63: Remove the background gradient from icon view (authored by janpr, committed by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16998?

D16998: Remove the background gradient from icon view

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, this is wy better. Thanks for the patch, and thanks for using `arc` to submit it! I've changed the title (which becomes the commit message) and the summary a bit in preparation

D16998: Removed the background gradient in icon view (it looked bad)

janpr created this revision. janpr added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. janpr requested review of this revision. REVISION SUMMARY The icon view showed a very faint gradient in the background. This looked weird, broken and not really lik

D16997: [kcm] Expose interface to control output property retention

romangg planned changes to this revision. romangg added a comment. This diff contains some fix, that need to go into earlier diffs in this patch series. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16997 To: romangg, #plasma Cc: plasma-devel, ragreen, Pitel, Zren

D16997: [kcm] Expose interface to control output property retention

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds two radio buttons to the kcm, that allow to change the output property retention of th

D16996: Add method to write retention to configuration control files

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This patch adds a small method to ControlConfig which writes modified retention values to the co

D16995: Consider identical display models in ControlConfig

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Load the correct control information in configurations with identical displays having the same E

D16994: Split Control class into configurations and outputs control classes

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In order to control the behavior of global output data and configuration data in a structured ma

D16993: Add a common directory for functionality being used by kcm and daemon

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Certain functionality will be shared between kcm and daemon in the future, but is for now not ex

Re: Plasma Accessibility: Kickoff Application starter and Focus handling

Howdy Edmundson, Oh really? This is incredible awesome. Its the last pice of puzzle what would fit our goal - make most important Desktop components accessible and make plasma initial (very basic) usefully for blind people. Would be very exciting if you could bring your patch in place. I recogniz

D16992: Introduce secondary control channel of the KScreen daemon

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Kcm and daemon can only communicate a limited data set through the backend. This feature patch a

D16991: Introduce concept of global and individual output data retention

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This is a new concept allowing the user to specifiy properties of a display model (in best case

D16990: [kded] Change configuration storage path

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY As a preparational stepp change the configuration storage directory into the subfolder 'config'

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45757. rooty added a comment. - Trim unnecessary code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45753&id=45757 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https:/

D16989: [kded] Introduce Config wrapper class

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In order to consolidate the code and as a preparatory step for larger changes introduce a wrappe

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. I cannot comment on the technical side of things (noob), and am perhaps a little biased since Root and I are best friends who have been working (mostly him) on Kickoff this weekend as our first real contribution to KDE, however... this change can really do wonders for

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45753. rooty added a comment. - Fix broken states and return ability to hover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45751&id=45753 BRANCH kickoff-visible-and-unfocused (branched from master) R

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45751. rooty added a comment. - Tidy up some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45750&id=45751 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https://pha

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45750. rooty added a comment. - Remove unnecessary states, tidy things up REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45747&id=45750 BRANCH kickoff-visible-and-unfocused (branched from master) REVIS

D16988: [Kickoff] Make the visible search field unfocused by default

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Changes: applets/kickoff/package/contents/ui/Header.qml This patch: (1) Keeps the search field visible by default but leaves it u

Re: Plasma Accessibility: Kickoff Application starter and Focus handling

On søndag 18. november 2018 18:08:27 CET David Edmundson wrote: > I started a patch a while ago in a branch: > D7780: Make Kickoff expose items to accessibility > > Which rewrote a lot as the focus handling was all over the place. > > However, in the meantime there was another big patch to kickof

D16987: Recalculate connected hash only on change and emit signal

romangg added a comment. Checking the edid is necessary, because it might be set asynchronously and before that the hash is based on the output name only. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D16987 To: romangg, #plasma Cc: plasma-devel, ragreen, P

D16987: Recalculate connected hash only on change and emit signal

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Instead of recomputing the connected outputs hash on every access, store it in Config and only r

D16945: Fix fallback to built-in ui

graesslin updated this revision to Diff 45744. graesslin added a comment. Adjust in the way David suggested. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45633&id=45744 BRANCH fix-fallback REVISION DETAIL https://phabricator.kde.org/D

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. I can understand that. However, I think it's kind of a foul to change the UI such that the label becomes difficult to read with a lot of wallpapers, and then say, "just choose a better wallpaper." This isn't very respectful of our users, who I think should be fr

D16768: mage global menu screen aware

mvourlakos added a subscriber: mart. mvourlakos added a comment. @davidedmundson I cant commit yet because @mart suggested to rename "menuHidden" to "visible" at https://phabricator.kde.org/D16715 what do you think is the best way to proceed? I would prefer to accept first D16715

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni added a comment. But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfier

D16400: Prefer to set current mode in resolution combobox

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Nice solution. REPOSITORY R104 KScreen BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D16400 To: volkov, #plasma, davidedmundson Cc: davidedmundson,

D16977: [weather] Fix broken observation display for temperature of 0 °

davidedmundson added a comment. > Observation temperature of 0 ° no longer is shown as empty string, Classic JS! well found. It looks OK to me, but hopefully @broulik can have a look as quirky JS is his specialty. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricat

Re: qdbus kactivities - delete all stats

>i need to be able to delete all recent documents from all applications via qdbus org.kde.ActivityManager.ResourcesScoring.DeleteRecentStats "" 0 "everything" But can you expand a bit on the full situation of what you want to achieve? There might be alternative options. David

D16890: [systemtray] Keep config entries after modifying

davidedmundson added a comment. I don't understand. The only usage of plasmoidItemComponent is in " Containment.onAppletAdded:", so how is this going to make any difference? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #pla

Re: Plasma Accessibility: Kickoff Application starter and Focus handling

I started a patch a while ago in a branch: D7780: Make Kickoff expose items to accessibility Which rewrote a lot as the focus handling was all over the place. However, in the meantime there was another big patch to kickoff that meant I needed to resolve all the merge conflicts in mine, and I kept

D16945: Fix fallback to built-in ui

davidedmundson added a comment. Ship it if you like, but I think there's a nicer solution. INLINE COMMENTS > greeterapp.cpp:313 > // on error, load the fallback lockscreen to not lock the user out > of the system > -if (view->status() == QQmlComponent::Error) { > +if

D16977: [weather] Fix broken observation display for temperature of 0 °

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY For that also deduplicate any data extraction & conversion logic in helper methods fo

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. In D16937#361224 , @romangg wrote: > Would someone take a look at the Simple Menu code to see if the unfocused search field code can be copied over directly to Kickoff (separate review though)? Long story short, no

KDE CI: Plasma » plasma-browser-integration » stable-kf5-qt5 FreeBSDQt5.11 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/stable-kf5-qt5%20FreeBSDQt5.11/38/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 18 Nov 2018 09:40:04 + Build duration: 14 min and counting CONSOLE

D16968: [Folder View] improve label contrast against challenging backgrounds

hein added a comment. Looks ugly to me. Honestly, my stance is "use a better wallpaper". There's only so far you can compromise theme aesthetics for other people's bad taste. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #v