D16856: [comic] Sync configuration on write

anthonyfieroni updated this revision to Diff 45556. anthonyfieroni added a comment. Better not change data engine REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16856?vs=45396&id=45556 REVISION DETAIL https://phabricator.kde.org/D16856 AFFECTED FI

D16898: [kcm] Remove profiles code

apol added subscribers: dvratil, apol. apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. RIP I see that @dvratil removed it at some point, maybe he remembers why it's not necessary? REPOSITORY R104 KScreen BRANCH removeProfilesCode

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

ngraham updated this revision to Diff 4. ngraham added a comment. Make sure extraWidth stuff still works properly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16901?vs=45525&id=4 BRANCH more-room-for-labels-with-tiny-icons (branched from

D16914: [Runners KCM] Focus the search field by default

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. TEST PLAN Start krunner, click on the parameter button on the left. In the window opening, the plugin search b

D16888: Recreate interrupted download when it is resumed

This revision was automatically updated to reflect the committed changes. Closed by commit R856:2b15d99afd53: Recreate interrupted download when it is resumed (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16888?vs=454

D16888: Recreate interrupted download when it is resumed

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Gave it a quick test as well, seems to work fine. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D16888 To: broulik, #plasma, davidedmundson, fvog

D16906: Update about KDE text

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This reflects the changes done to KAboutDialog TEST PLAN - New text shows up, the three

D16690: [Baloo Runner] Filter duplicates and prefer specific type matches

This revision was automatically updated to reflect the committed changes. Closed by commit R120:867c864e7c07: [Baloo Runner] Filter duplicates and prefer specific type matches (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16690

D16887: Send all active downloads on load

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7bb04c749f67: Send all active downloads on load (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16887?vs=45494&id=45536 RE

D16889: Listen to KDE Connect device signals

fvogt added inline comments. INLINE COMMENTS > extension.js:156 > +if (chrome.runtime.lastError) { > +// failed to create entry, most likely visibility change before > device added was processed > +return; Can you explain how that makes the creation fail? > kdec

D16890: [systemtray] Keep config entries after modifying

broulik added a comment. I think that's a Qt bug, i did an investigation in another systray bug report but can't find it right now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson Cc: broulik, plasma

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16901 To: ngraham, #plasma, #vdg, hein Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

broulik added a comment. Can you check the `extraWidth` stuff still works? Ie. Whether left and right padding of screen is equal, since you `Math.max` the entire thing to icon size REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16901 To: ngraham, #plasma, #v

D16897: Allow windows to be closed from the window switchers

ngraham added a comment. In D16897#359911 , @graesslin wrote: > In D16897#359900 , @ngraham wrote: > > > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin

D16897: Allow windows to be closed from the window switchers

graesslin added a comment. In D16897#359900 , @ngraham wrote: > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). I would pre

D16897: Allow windows to be closed from the window switchers

ngraham planned changes to this revision. ngraham added a comment. Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phab

D16859: Rename config loading function

This revision was automatically updated to reflect the committed changes. Closed by commit R104:af6da1146ef6: Rename config loading function (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16859?vs=45407&id=45528 REVISION DETAIL https:

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

ngraham created this revision. ngraham added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements a minimum width when using on-the-desktop icon view to make sure

D16897: Allow windows to be closed from the window switchers

graesslin added a comment. I agree with David: please don't hardcode the key. Please don't use "W" - it has no meaning in a window manager, it's just the shortcut in some applications, others use Ctrl+Q and localized it could be something completely different. I suggest to implement thi

D16897: Allow windows to be closed from the window switchers

davidedmundson added a comment. You can do control+w with if (event.matches(StandardKey.Close)) { } alt+f4 would need some exposing on the kwin side as that's not a "standard key" exposed via the QPT REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1

D16886: [windowswitcher] Implement keyboard navigation

davidedmundson added subscribers: Zren, davidedmundson. davidedmundson added a comment. In the previous patch @zren said: > "Breeze (Look and Feel) > > Works?! I guess the ListView handles the key input?" and the comments in this patch are copy pasted from the kdeplasma-addons

D16897: Allow windows to be closed from the window switchers

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. you can't hardcode the key combos REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16897 To: ngraham, #plasma, #vdg, davidedmundson

D16897: Allow windows to be closed from the window switchers

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16897 To: ngraham, #plasma, #vdg Cc: abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16900: Don't use an icon that is only supposed for plasmoids

apol created this revision. apol added reviewers: andreask, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D16900

D16898: [kcm] Remove profiles code

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This code seems to be unused for a long time or was never used at all. Introduced in 2013 there

D16897: Allow windows to be closed from the window switchers

ngraham added a subscriber: Zren. ngraham added a comment. I'm also having trouble getting the same approach to work for the default Breeze switcher, which lives in plasma-workspace. Keyboard navigation with the arrow keys works, so the event handler is functional. But I can't seem to target

D16897: Allow windows to be closed from the window switchers

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implements the ability to close windows from the various non-default window switchers using t

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 116 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/116/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 15 Nov 2018 14:02:32 + Build duration: 3 min 50 sec and counting

D16886: [windowswitcher] Implement keyboard navigation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4d52641657d6: [windowswitcher] Implement keyboard navigation (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16886?vs=45493&id=45517

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni added a comment. Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson C

D16891: [logout-greeter] Use correct enum for logout hint to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R120:02541b8af06e: [logout-greeter] Use correct enum for logout hint to QML (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16891?v

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 115 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/115/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 15 Nov 2018 11:34:32 + Build duration: 1.8 sec and counting CONSOLE OUTPUT Started b

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni updated this revision to Diff 45502. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16890?vs=45500&id=45502 REVISION DETAIL https://phabricator.kde.org/D16890 AFFECTED FILES applets/systemtray/package/contents/ui/main.qml To: anth

D16889: Listen to KDE Connect device signals

apol added inline comments. INLINE COMMENTS > kdeconnectplugin.cpp:185 > +msg.setArguments({url}); > +QDBusConnection::sessionBus().call(msg, QDBus::NoBlock); > +} Never saw this kind of change, what's the difference? REPOSITORY R856 Plasma Browser Integration REVISION DE

D16889: Listen to KDE Connect device signals

apol added a comment. +1 LGTM the KDE Connect parts. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D16889 To: broulik, #plasma, davidedmundson, fvogt, nicolasfella Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j

D16891: [logout-greeter] Use correct enum for logout hint to QMQL.

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Libkworkspace has two duplicate enum values for the same thing, with one marked as "//FIXME remove". My patchset is

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY It still has one problem, after configuration is chan