D16093: Consistent arrow key handling in the Informative Alt+Tab skin

ngraham added a comment. Hmm, this does not actually work for me. Seems like it logically should, but it doesn't. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16093 To: Zren, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D16889: Listen to KDE Connect device signals

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes sure we detect devices being added, removed, or becoming

D16888: Recreate interrupted download when it is resumed

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a download is canceled, finishes, or is interrupted (e.g. loss of netw

D16887: Send all active downloads on load

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures when the extension is reloaded any downloads currently running are

D16886: [windowswitcher] Implement keyboard navigation

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implements keyboard navigation via the up and down arrow keys for the Breeze window switcher.

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking FetchSqlite instances (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16410?vs=44170&id=

D16409: [Bookmarks Runner] Open database connection in the query thread

This revision was automatically updated to reflect the committed changes. Closed by commit R120:145caeac1050: [Bookmarks Runner] Open database connection in the query thread (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16409?vs=

D16861: Improve contrast for crosshair cursors

This revision was automatically updated to reflect the committed changes. Closed by commit R31:39c5b09297cc: Improve contrast for crosshair cursors (authored by ndavis, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45482&id=45484

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. My recommendation would be to abandon the diff or change it to address the problem of the OSD checkbox not being clear about what it affects. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vd

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Should I do anything special about this Diff ? Do we just keep it as it is for reference ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca, ngraham Cc: ngraham, broulik, nicolasfe

D16861: Improve contrast for crosshair cursors

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely work :) I notice this is now branched off of master. Could you land this on the `Plasma/5.12` branch and then merge to `Plasma/5.14` and then master? This is documented at ht

D16861: Improve contrast for crosshair cursors

ndavis updated this revision to Diff 45482. ndavis added a comment. Only change crosshair cursors and source SVG REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45434&id=45482 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16861 AFF

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. In D16082#359352 , @thsurrel wrote: > Absolutely, as said in my previous comment, I agree the usefulness of the OSD in that case is very much questionable. > I was raising questions on a different level: > > - woul

D16875: [kded] Cleanup KScreenDaemon class

This revision was automatically updated to reflect the committed changes. Closed by commit R104:4a177884b052: [kded] Cleanup KScreenDaemon class (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16875?vs=45466&id=45469 REVISION DETAIL ht

D16874: [kded] Replace configReady functon with lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R104:980b100770bb: [kded] Replace configReady functon with lambda (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16874?vs=45446&id=45467 REVISION

D16875: [kded] Cleanup KScreenDaemon class

romangg updated this revision to Diff 45466. romangg added a comment. - Add back Q_SLOTS specifier to be sure REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16875?vs=45448&id=45466 BRANCH codeCleanupExport REVISION DETAIL https://phabricator.kde.org/D

D16875: [kded] Cleanup KScreenDaemon class

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in daemon.h:47 > Are you sure this is a problem? I just tested it manually with qdbusviewer > and the method was called accordingly. > > Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS > specifier

D16875: [kded] Cleanup KScreenDaemon class

broulik added inline comments. INLINE COMMENTS > romangg wrote in daemon.h:47 > Are you sure this is a problem? I just tested it manually with qdbusviewer > and the method was called accordingly. > > Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS > specifier? For

D16875: [kded] Cleanup KScreenDaemon class

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in daemon.h:47 > this has moved from being a slot. > > If it is invoked from DBus as the comment suggests that will be a problem Are you sure this is a problem? I just tested it manually with qdbusviewer and the method was c

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. nice! i've been tinkering with this some more over the past few days (it's been driving me a little nuts), and i've been using "spread: 0.1" on the clock shadow while keeping "spread: 0.35" on the username and action button shadows i've been doing this because "0.35"

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. @davidedmundson I've put only the fairly non-controversial changes into D16879 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: ro

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham created this revision. ngraham added reviewers: davidedmundson, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As requested in D16031 , tweak the login

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Absolutely, as said in my previous comment, I agree the usefulness of the OSD in that case is very much questionable. I was raising questions on a different level: - would it be import to be consistent and show an OSD in the jack case if we are showing one in

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. Well, there are types of visual feedback that are useful and there are types that aren't. A "Bluetooth device successfully paired" notification is useful because there was always some chance that it would fail, and you need to know whether or not that happened. I cou

D15512: [startplasmacompositor] Add Wayland socket argument

fvogt added a comment. It looks like all of that is already implemented in libwayland-server. kwin_wayland just needs to make use of `wl_display_add_socket_auto` (other compositors do as well). In D15512#359308 , @graesslin wrote: > In D1

D15512: [startplasmacompositor] Add Wayland socket argument

graesslin added a comment. In D15512#359253 , @fvogt wrote: > > KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. > > Why? That goes entirely against what I and probably many ot

D16875: [kded] Cleanup KScreenDaemon class

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > daemon.h:47 > +// DBus > +void applyLayoutPreset(const QString &presetName); > + this has moved from being a slot. If it is invoked f

D16874: [kded] Replace configReady functon with lambda

davidedmundson added a comment. > Note, that the configReady function was a public slot in an exported class, so is it safe? it's not in a library that people link to, so you can do whatever. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16874 To: romangg, #p

D16875: [kded] Cleanup KScreenDaemon class

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Do not export class, privatize and unvirtualize members. Cleanup white space. TEST PLAN Manua

D16874: [daemon] Replace configReady functon with lambda

romangg added a comment. Note, that the configReady function was a public slot in an exported class, so is it safe? I would like to change other stuff in this class definition. I don't know why the class is exported and who consumes it. REPOSITORY R104 KScreen REVISION DETAIL https://ph

D16874: [daemon] Replace configReady functon with lambda

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Purely for cosmetic reasons. TEST PLAN Compiles. REPOSITORY R104 KScreen BRANCH codeClean

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Having a visual feedback would be useful when pairing bluetooth speakers IMO (does it ? I don't have any to test with). For a jack connection, that is indeed less useful, but that would be consistent. In addition, the plasma-pa has an option to turn the OSD off,

D15512: [startplasmacompositor] Add Wayland socket argument

fvogt added a comment. > KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. Why? That goes entirely against what I and probably many others expect from a kwin_wayland call without explicit socket argument. kwin_wayland