D15512: [startplasmacompositor] Add Wayland socket argument

graesslin added a comment. KWin does not have functionality to generate the socket. KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. Given that I fully support this change. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16873: [comic] Request current identifier on date changed

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY The problem is when date is changed we connect to source ex.

D16861: Improve contrast for crosshair cursors

ndavis added a comment. In D16861#359193 , @ngraham wrote: > Imagine that, reading the README. :) If manual work is required for each image, that seems like all the more reason to only include the two changed ones in the diff. Yep. This

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ngraham added a comment. Imagine that, reading the README. :) If manual work is required for each image, that seems like all the more reason to only include the two changed ones in the diff. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis planned changes to this revision. ndavis added a comment. Hmm some of the cursors seem blurrier than they used to be and I have no idea why. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-dev

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. Now that I think about it, maybe we keep it the way it is and see if anyone actually complains rather than trying to make the perfect the enemy of the good. I don't think I've actually heard any complaints from the jack always displaying a headphone icon in the apple

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ngraham added a comment. FWIW the actual crosshair cursors seem better to me now, especially the Breeze snow one. You could maybe just take the changed files for the crosshairs and make a new diff with just them if you can't figure out the other issue. REPOSITORY R31 Breeze REVISION DETAI

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis added a comment. I think I found the reason why the prebuilt cursor themes are included in the repo in the README: > No trimming will have been done to the cursors, and X11 *may* give you split-second glitches when switching cursors making them appear to 'jump' for an instant. To

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#359173 , @ngraham wrote: > Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something? It can be any device really, not just speakers/headphones, as long as it

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis added a comment. In D16861#359170 , @ngraham wrote: > So is there a script that regenerates all the X11 cursor files from the SVG whenever it's changed or something? Because I'm willing to bet you didn't change all 654 cursors...

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. In D16082#356111 , @thsurrel wrote: > So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack. I don't think so, sorry. I think th

D16861: Improve crosshair cursor

ngraham added a comment. So is there a script that regenerates all the X11 cursor files from the SVG whenever it's changed or something? Because I'm willing to bet you didn't change all 654 cursors... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis,

D16861: Improve crosshair cursor

ndavis added a comment. I'd like to remove the extra junk, but I don't want to break anything either. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D16861: Improve crosshair cursor

ndavis updated this revision to Diff 45434. ndavis added a comment. Improve contrast for Breeze Snow and Breeze crosshair REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45429&id=45434 BRANCH better-crosshair-cursor (branched from master) REVISION

D16861: Improve crosshair cursor

ngraham added a comment. Don't ask me, I just live here. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D16861: Improve crosshair cursor

ndavis added a comment. Why do we have the cursor theme pre-built in the repo? It's making Arcanist take forever. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D16861: Improve crosshair cursor

ngraham added a comment. I think either way would work. For maximum surety, I would download it locally and then do `arc diff --update D16861`. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel,

D16861: Improve crosshair cursor

ndavis added a comment. What's the best way to update this diff? What I'm doing completely discards your changes. Should I get this diff with `arc patch D16861` and then update the diff from that branch or can I make my own branch and do `arc diff --update D16861` to overwrite your changes?

D16861: Improve crosshair cursor

ngraham added a comment. Go for it! That bugged me too. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D16861: Improve crosshair cursor

ndavis added a comment. I find the Breeze Snow cursors to bee generally lacking in contrast because of the 60% opacity outline. Should I expand this commit to improve the contrast for all Breeze Snow cursors as well? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D168

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359124 , @ngraham wrote: > Would you like to take over? I have a feeling that you can do a better job than I can, and you also know what you're doing with the tools, too. :) Sure. I've basically already c

D15512: [startplasmacompositor] Add Wayland socket argument

romangg updated this revision to Diff 45431. romangg added a comment. - Use SOCKET_OPTION variable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15512?vs=41660&id=45431 BRANCH kwinWaylandSocketArg REVISION DETAIL https://phabricator.kde.org/

D16861: Improve crosshair cursor

ngraham added a comment. Would you like to take over? I have a feeling that you can do a better job than I can, and you also know what you're doing with the tools, too. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze, #vdg, #plasma Cc: nd

D16861: Improve crosshair cursor

ndavis added a comment. Turns out there already is an outline, but it's at 10% opacity instead of 100% and the crosshair doesn't have a blurred shadow around it like the other breeze cursors. I think we should do our best to try to keep the crosshair feeling precise while also improving the

D16861: Improve crosshair cursor

ngraham added a comment. In D16861#359107 , @ndavis wrote: > In D16861#359106 , @ngraham wrote: > > > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359106 , @ngraham wrote: > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but hopefully I'll muddle through... Maybe the original cursors were made with SVG so

D16861: Improve crosshair cursor

ngraham added a comment. Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but hopefully I'll muddle through... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze, #vdg, #plasma Cc: ndavis, plasma-devel

D16861: Improve crosshair cursor

ndavis added a comment. Those crosshair outlines seem to be a bit jagged, unlike the other breeze crosshairs. F6421397: Screenshot_20181113_135510.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze,

D16861: Improve crosshair cursor

ndavis added a comment. You should probably do Breeze Snow as well since it has the exact same issue. In fact, it's probably even worse since a majority of websites use a white background.F6421382: Screenshot_20181113_135123.png REPOSITORY R31 Breeze

D16861: Improve crosshair cursor

ngraham updated this revision to Diff 45429. ngraham added a comment. Remove interior gradients in favor of a flat fill of the standard color REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45409&id=45429 BRANCH better-crosshair-cursor (branched fr

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359066 , @ngraham wrote: > It is indeed a weird gradient. I was just trying to make the minimum required number of changes to fix the bug, but I can fix that too if you'd like. Yes, if you're going to add

D16861: Improve crosshair cursor

ngraham added a comment. It is indeed a weird gradient. I was just trying to make the minimum required number of changes to fix the bug, but I can fix that too if you'd like. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze, #vdg, #plasma Cc:

D16284: do not force text display for ToolButton

astippich updated this revision to Diff 45425. astippich added a comment. - follow style REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16284?vs=43823&id=45425 BRANCH toolbutton REVISION DETAIL https://phabricator.kde.org/D1

D16658: Respect the display property of buttons

astippich added a comment. Can I convince you to land this for Kf 5.53 with the promise to clean up once frameworks depends on Qt 5.10? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-dev

D16658: Respect the display property of buttons

astippich updated this revision to Diff 45424. astippich added a comment. - rebase - more verbose comment about compatibility REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=44827&id=45424 REVISION DETAIL https://phab

D16659: Size according to specified icon width and height

This revision was automatically updated to reflect the committed changes. Closed by commit R858:66d8bdb32735: Size according to specified icon width and height (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D16651: Honor flat property of buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16651?vs=44934&id=45

D16861: Improve crosshair cursor

ndavis added a comment. What color is the area on the inside of the cursor? I'm not sure, but it looks like it has a gradient, which doesn't really match the other Breeze cursors. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze, #vdg, #plas

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 69 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/69/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 13 Nov 2018 13:36:23 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT [...truncated 198.2

D16715: make global menu minimize state aware

mvourlakos marked an inline comment as done. mvourlakos added a comment. follow mart suggestion REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16715 To: mvourlakos, #plasma, broulik, davidedmundson Cc: mart, trmdi, apol, anthonyfieroni, plasma-devel, ragree

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 45411. mvourlakos added a comment. - rename menuHidden to visible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=45142&id=45411 BRANCH appMenuMinimize REVISION DETAIL https://phabricator.kde.o

D16861: Improve crosshair cursor

ngraham created this revision. ngraham added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The regular Breeze crosshair cursor had no white outline like its companions, so it was almos

D16860: touchscreen text controls

mart added inline comments. INLINE COMMENTS > broulik wrote in MobileTextActionsToolBar.qml:25 > Can you check whether this macro substitution actually works for the > "private" folder? yes it works correctly, the problem in the plasma version was the separate install of the style as an import

D16860: touchscreen text controls

broulik added inline comments. INLINE COMMENTS > MobileTextActionsToolBar.qml:25 > +import QtQuick.Window 2.2 > +import QtQuick.Controls @QQC2_VERSION@ > +import org.kde.kirigami 2.5 as Kirigami Can you check whether this macro substitution actually works for the "private" folder? REPOSITORY

D16860: touchscreen text controls

mart added a comment. F6420787: Screenshot_20181113_122130.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D16860: touchscreen text controls

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on QQC2 the controls to be able to select, cut,copy and paste text are responsibility of the style. thi

D16859: Rename config loading function

romangg updated this revision to Diff 45407. romangg added a comment. - Remove unrelated change REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16859?vs=45406&id=45407 BRANCH configReadCleanup REVISION DETAIL https://phabricator.kde.org/D16859 AFFECTE

D16859: Rename config loading function

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Make it more explicit what it does. TEST PLAN Serializer test passes. REPOSITORY R104 KScree

D16845: Make use of libkscreen hash API

This revision was automatically updated to reflect the committed changes. Closed by commit R104:740a86695df4: Make use of libkscreen hash API (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16845?vs=45371&id=45405 REVISION DETAIL https

D16843: Add output and connected outputs config API

This revision was automatically updated to reflect the committed changes. Closed by commit R110:4be57b2027fe: Add output and connected outputs config API (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16843?vs=45368&id=45403#toc REPOSITORY R110 KScreen Library C

D16651: Honor flat property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16651 To: astippich, ngraham, mart, apol, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid added a comment. ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16595 To: aacid, #plasma, davidedmundson, mart Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 68 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/68/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 13 Nov 2018 09:10:11 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...truncated 200.46

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 78 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/78/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 13 Nov 2018 09:10:11 + Build duration: 45 sec and counting CONSOLE OUTPUT [...truncated 163.7

D16776: Better error handling in KNewStuff backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7f6caf385809: Better error handling in KNewStuff backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45355&id=4539

D16843: Add output and connected outputs config API

romangg added a comment. In D16843#358678 , @apol wrote: > Don't we already have a hash per config? Not that I know of. There are output ids, but they get lost after restarts. INLINE COMMENTS > apol wrote in config.h:126 > X=53 :) You m