D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-31 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:7b26061fe052: [Kickoff] Add a subtle separator line between the header and the content view (authored by ngraham). REP

D15786: share common values for both Breeze and Breeze-dark GTK themes

2018-10-31 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Landed as D16365 . REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D15786 To: ngraham, jackg, #plasma, grmat Cc: ngraham, ohelin, plasma-devel, ragreen, Pitel, ZrenBot,

D16365: share common values for both Breeze and Breeze-dark GTK themes

2018-10-31 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R98:6ec73bf06938: share common values for both Breeze and Breeze-dark GTK themes (authored by Matthias Groß , committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D

D16550: [ksmserver] Fix session restore check

2018-10-31 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e53e3e170148: [ksmserver] Fix session restore check (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16550?vs=44558&id=44560 R

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

2018-10-31 Thread David Edmundson
davidedmundson updated this revision to Diff 44559. davidedmundson added a comment. aleix's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16277?vs=43802&id=44559 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16277 AFFE

D16550: [ksmserver] Fix session restore check

2018-10-31 Thread Andreas Hartmetz
ahartmetz accepted this revision. ahartmetz added a comment. This revision is now accepted and ready to land. This fixes session restore for me. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16550 To: davidedmundson, ahartmetz Cc: ahartmet

D16550: [ksmserver] Fix session restore check

2018-10-31 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The old code checked ksmserver->defaultSession in the Startup constructor before ksmserver was set up by main.cpp

D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D16547 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov updated this revision to Diff 44551. volkov added a comment. rename slot REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16547?vs=44550&id=44551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16547 AFFECTED FILE

D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Auto-connections is bad practice cause object renames break code and it can't be detected at compile time. REPOSITORY R121 Policy

D13100: do not use buffered file IO

2018-10-31 Thread Rolf Eike Beer
This revision was automatically updated to reflect the committed changes. Closed by commit R107:fcbcf0f1bdfa: do not use buffered file IO (authored by dakon). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13100?vs=43538&id=44535#toc REPOSITORY R107 KWallet PAM Integration CHANGES SIN