ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The Font Install KCM has a very dated layout. Thisd patch addresses some (but
not all) of the
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:16328d3aab91: Move GHNS button to the normal location
(authored by ngraham).
REPOSITORY
R123 SDDM Configuration Panel (KCM)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16527?vs=44492&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7e4a07d25cc7: Move GHNS buttons to the normal location
for Colors and Emoticons KCMs (authored by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q)
to exit the app (authored by Zren).
REPOSITORY
R118 Plasma SDK
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16521?vs=44472&id=44
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:68538b6d451f: [ksmserver] Launch logout greeter with DBus
methods (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16066?vs=43205&id=44500#toc
REPOSITORY
R120 Pla
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:248dadf49597: [ksmserver] Split startup into separate
class (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16225?vs=43663&id=44501#toc
REPOSITORY
R120 Plasma Wo
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:96a595f1b860: [ksmserver] Rewrite Startup (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16231?vs=43695&id=44502#toc
REPOSITORY
R120 Plasma Workspace
CHANGES S
bruns created this revision.
bruns added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
Qt and GTK based applications have switched to using fontconfig for fonts
exclusively, so this c
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> shutdown.cpp:31
> {
> -if ( state != Idle )
> -return;
> -sessionGroup = QStringLiteral( "Session: " ) + session;
> -saveCurrentSession();
> +
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in startup.cpp:275
> can't this be `&KJob::emitResult`?
It's stupid:
I can do
connect(watch, SIGNAL(finished()), this, SLOT(emitResult()));
but not with function pointers because:
error: 'emitResult' is a protected member of
hein added a comment.
Should be OK now
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D14542
To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen,
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali
hein updated this revision to Diff 44498.
hein added a comment.
Try to remove Marco's revision
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14542?vs=44095&id=44498
BRANCH
arcpatch-D14542_1
REVISION DETAIL
https://phabricator.kde.org/D14542
AFFECTED FI
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
+1 LGTM
INLINE COMMENTS
> startup.cpp:275
> QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pending,
> this);
> -QObject::connect(watcher, &QDBusPendingCallWatcher::fin
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:96aa15d1: fix warnings (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16375?vs=44077&id=44497
REVISION DETAIL
https://phabricator.kde.org
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
This looks really good!
REPOSITORY
R120 Plasma Workspace
BRANCH
ksmserver_split
REVISION DETAIL
https://phabricator.kde.org/D16066
To: davidedmundson, #plasma, apol
Cc: apol, plasma-dev
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch moves the GHNS button to the bottom-right corner for the Icons and
Emoticons KCMs,
ngraham updated this revision to Diff 44492.
ngraham added a comment.
Tweaks
REPOSITORY
R123 SDDM Configuration Panel (KCM)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16527?vs=44491&id=44492
BRANCH
ghns-button-in-a-consistent-location (branched from master)
REVISION DETAIL
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch moves the GHNS button to the bottom-right corner, where it is for
nearly all other
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ae36781b332a: [KCMs] Use consistent text for GHNS buttons
(authored by ngraham).
REPOSITORY
R119 Plasma Desktop
CHA
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:474b5d16b566: Use consistent text for the GHNS button
(authored by ngraham).
REPOSITORY
R123 SDDM Configuration Pane
20 matches
Mail list logo
