D16504: [KCMs] Use consistent text for GHNS buttons

2018-10-28 Thread Andres Betts
abetts added a comment. I like the direction of the patch. My only thing is that we drop the use of the word "Scheme". I think we could use something different like "Pattern", "Swatch", "Theme", etc. If it is about colors, I think swatch would be really cool. REPOSITORY R119 Plasma De

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. Ping! Any #plasma or #vdg concerns, or shall I land this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abetts, mm

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. @mart? Anyone in #plasma ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein, mart Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D16502: Use consistent text for the GHNS button

2018-10-28 Thread Nathaniel Graham
ngraham updated this revision to Diff 44403. ngraham added a comment. Themes -> Styles; it's more consistent with the wording used elsewhere in the KCM REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16502?vs=44399&id=44403 BRANCH consi

D16483: [workspace KCM] Port to QQC2

2018-10-28 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a2c87ce86c80: [workspace KCM] Port to QQC2 (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16483?vs=44357&id=44402 REVISION DETAIL h

D16504: [KCMs] Use consistent text for GHNS buttons

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. I don't feel 100% about the desktop theme and L&F labels since they both use the word "themes". I feel like maybe we can do better than that but was running out of creativity. Maybe `Get New Look and Feel Packages`? `Get New Looks And Feels`? Ugh, that's awful. REPO

D16502: Use consistent text for the GHNS button

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. Open to suggestions on wording here. Would "Styles" be better than "Themes? "Styles" is used in the title after all... REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D16502 To: ngraham, #plasma, #vdg Cc: plasma-devel, ragre

D16504: [KCMs] Use consistent text for GHNS buttons

2018-10-28 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implement consistent text format as decided on in T9941

D16502: Use consistent text for the GHNS button

2018-10-28 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implement consistent text format as decided on in T9941 .

D16503: Use consistent text for the GHNS button

2018-10-28 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Implement consistent text format as decided on in T9941 .

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

2018-10-28 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=375826 Andrew Crouthamel changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2018-10-28 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=349750 Andrew Crouthamel changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

D16497: Give the GHNS button an appropriate icon and more consistent text

2018-10-28 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R123:de088bdca917: Give the GHNS button an appropriate icon and more consistent text (authored by ngraham). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.

D16497: Give the GHNS button an appropriate icon and more consistent text

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. In D16497#350082 , @davidedmundson wrote: > Worth tagging other one-liner commits like this as junior-jobs for GCI. Good idea. Just use the standard `junior-job` keyword, or is there a specific one just for GCI?

D16497: Give the GHNS button an appropriate icon and more consistent text

2018-10-28 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Worth tagging other one-liner commits like this as junior-jobs for GCI. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH ghns-icon-on-button (branched from master)

D16497: Give the GHNS button an appropriate icon and more consistent text

2018-10-28 Thread Nathaniel Graham
ngraham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch gives the GHNS button an icon and tweaks its text to be consistent with the general pattern seen in other KCMs. BUG: 4

D16483: [workspace KCM] Port to QQC2

2018-10-28 Thread Nathaniel Graham
ngraham updated this revision to Diff 44357. ngraham added a comment. Also use `Kirigami.Separator` correctly to get rid of the tiny dot between sections REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16483?vs=44356&id=44357 BRANCH workspace-kcm-

D16483: [workspace KCM] Port to QQC2

2018-10-28 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Port the Workspace KCM to QQC2. BUG: 385547 FIXED-IN: 5.15.0 TEST PLAN -

D16425: Added new Suspend then Hibernate option

2018-10-28 Thread Nathaniel Graham
ngraham added a comment. If the default is 3 hours, then we need to either provide a GUI facility to change that, or, if we can't, then we need to mention the time in the checkbox's label, e.g. `Hibernate after 3 hours when suspended` REPOSITORY R122 Powerdevil REVISION DETAIL https://p

D13100: do not use buffered file IO

2018-10-28 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > dakon wrote in pam_kwallet.c:696 > While this is "just an int", my personal taste is very much against using > const on a file descriptor as this is not how this really works. I don't know. It is how it really works. Think of as a handle value, you

D4034: Show descriptive text when changing containment plugins

2018-10-28 Thread Root
rooty added a comment. nice! props REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davidedmundson, #plasma, mart Cc: ngraham, rooty, broulik, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol