D16425: Added new Suspend then Hibernate option

2018-10-25 Thread Alejandro Valdes
avaldes added a comment. @ngraham afaik powerdevil asks logind for system capabilites, with the CanSuspend, CanHibernate, etc. defined here . I added a new option if logind reports yes for CanSuspendThenHib

D16365: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. @grmat, could you provide your full name and email address so I can add your authorship information? Thanks! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze, #plasma, ngraham Cc: grmat, ngraham, plasma-

D13100: do not use buffered file IO

2018-10-25 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Please make me const-happy before commiting :) INLINE COMMENTS > pam_kwallet.c:696 > char *salt = gcry_random_bytes(KWALLET_PAM_SALTSIZE, > GCRY_STRONG_RANDOM); > -FILE *fd

D16425: Added new Suspend then Hibernate option

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. Very interesting. Is there a programmatic way to detect hardware that would benefit from this? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D16365: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. Nah, you did great! The only thing you could have done to make this easier would have been to submit two patches: one to templatize the code, and a second one to make functional changes. But Phabricator makes this workflow somewhat awkward and more difficult than it

D16365: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread mat gr
grmat added a comment. Thanks for the comments, review and for splitting up the diff. I also know it was daunting to review the patch in its original form and I could've done that better. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg

D15786: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread mat gr
grmat added a comment. Thanks for the review, comments and for splitting up the diff. I also know it was daunting to review the patch in its original form and I could've done that better. I'll see if I can test the updated version in the upcoming days. REPOSITORY R98 Breeze for Gtk REVI

D16425: Added new Suspend then Hibernate option

2018-10-25 Thread Alejandro Valdes
avaldes created this revision. avaldes added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. avaldes requested review of this revision. REVISION SUMMARY See bug 399727 for a good description of what this

D12498: Fully remove `Application Name` from Details panel

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R121:eb9c4c080427: Fully remove `Application Name` from Details panel (authored by sharvey, committed by bruns). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricat

D16417: Improve replacement text when action description is not provided

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R121:9cf71f424950: Improve replacement text when action description is not provided (authored by bruns). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.o