D15170: Add icon names for root level kicker, recent docs, recent apps, power and session

hein added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15170 To: marcusb, #plasma Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16309: Add accessibility information to desktop icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:498c42fed65d: Add accessibility information to desktop icons (authored by chempfling, committed by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16309?vs=43905&id=44057#toc REPOSITORY

D16309: Add accessibility information to desktop icons

hein added a comment. I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To: chempfling, hein, gladh

D16365: Update diff against newest master

ngraham added a comment. JFYI, if we land this patch instead of the original, we'll credit the original author. But do feel free to continue along this vein and maybe do the same for the other GTK version CSS files in another patch afterwards if you'd like! REPOSITORY R98 Breeze for Gtk

D16365: Update diff against newest master

ngraham added a comment. Sort of an unorthodox way to do this, but... it works I guess! Thanks, the patch now applies, and rudimentary testing with some GTK apps doesn't show anything hideously wrong. I assume it works well enough for you too? REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D15786: share common values for both Breeze and Breeze-dark GTK themes

ngraham added a comment. In D15786#347021 , @ohelin wrote: > Oh man I find Phabricator quite unintuitive to use. I clicked on the update diff to... update the diff, but ended up creating a new revision. Don't know if that was the correct way. An

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Ok, I just dissected the thing. First, I made the updated diff file against the newest master: **diff_updated.diff**. Then I saved these files from Phabricator: - **Breeze-dark-gtk_gtk-3.20_gtk.css**: saved the left raw diff file - **Breeze-gtk_gtk-3.20_common.

D16365: Update diff against newest master

ohelin added a comment. Ok, I just dissected the thing. First, I made the updated diff file against the newest master: **diff_updated.diff**. Then I saved these files from Phabricator: - **Breeze-dark-gtk_gtk-3.20_gtk.css**: saved the left raw diff file - **Breeze-gtk_gtk-3.20_common.

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Oh man I find Phabricator quite unintuitive to use. I clicked on the update diff to... update the diff, but ended up creating a new revision. Don't know if that was the correct way. Anyway, I attached the updated diff there and linked it as a child of this revision. I

D16365: Update diff against newest master

ohelin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ohelin requested review of this revision. REVISION SUMMARY Updated diff against newest master so that it applies again. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.k

D7849: Fix the tray icon scaling on HiDPI screens

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This does not actually compile for me against current git master: /home/dev/repos/plasma-framew

D15786: share common values for both Breeze and Breeze-dark GTK themes

ngraham added a comment. Thanks a ton @ohelin! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D15786 To: grmat, jackg, #plasma Cc: ngraham, ohelin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. In D15786#346959 , @ngraham wrote: > @grmat Thank you very much for this patch. I'm sorry that nobody has reviewed it yet. I think people are just intimidated by the huge diff lol. I will make an effort to do so, but it m

D15786: share common values for both Breeze and Breeze-dark GTK themes

ngraham added subscribers: ohelin, ngraham. ngraham added a comment. @grmat Thank you very much for this patch. I'm sorry that nobody has reviewed it yet. I think people are just intimidated by the huge diff lol. I will make an effort to do so, but it might help if you could produce a simplif

D16331: GTK theme treeview style typo/bug fix

ngraham closed this revision. ngraham added a comment. Done; it's in the `Plasma/5.12` branch now. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16331 To: ohelin, #breeze, #vdg, broulik, ngraham Cc: fvogt, ngraham, jackg, plasma-devel, #breeze, ragreen, Pitel

D16331: GTK theme treeview style typo/bug fix

ngraham added a comment. I tried that first, but it didn't apply cleanly, so I was lazy and did it for 5.14 onwards. Thanks for kicking my butt on this; I'll go backport it to 5.12 too. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16331 To: ohelin, #breeze

D16331: GTK theme treeview style typo/bug fix

fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. AFAICT Plasma/5.12 is affected as well, any reason this wasn't landed to 5.12? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16331 To: ohelin, #breeze, #vdg,

D16339: sddm-kcm: don't hardcode session file location.

This revision was automatically updated to reflect the committed changes. Closed by commit R123:1c1f654b0010: sddm-kcm: don't hardcode session file location. (authored by Róbert Bagdán , committed by tcberner). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE