D15616: [Comic] Handle error state correctly

2018-10-03 Thread Anthony Fieroni
anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Filip Fila
filipf added a comment. On a sidenote, I think it's worth pointing out that anonym's change pertaining to the name of the "Volume Feedback" option may be good idea because I don't think that term is self-explanatory; I don't think a first-time fiddler necessarily understands what it's suppos

D15011: [Kickoff] Make the search field always look like a search field

2018-10-03 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, abetts Cc: cfeck, acrouthamel, fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnel

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Root
rooty added a comment. In D14949#336050 , @ngraham wrote: > In D14949#336029 , @davidedmundson wrote: > > > The recurring pattern that we want to avoid is having a framework where theme creators can

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. In D14949#336029 , @davidedmundson wrote: > The recurring pattern that we want to avoid is having a framework where theme creators can set everything, whilst simultaneously the default theme becomes itself a theme engin

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Filip Fila
filipf added a comment. In D14949#336029 , @davidedmundson wrote: > > What is this "mechanism" you are talking about? I'm intrigued! > > We have a mechanism for theme providers to change the OSD. (the whole LNF package stuff). They can overr

Re: My ksmserver plans

2018-10-03 Thread David Edmundson
>or by another 3rd process? (don't they become a bit.. many?) In terms of processes we will have the existing: - ksmserver - logout greeter And new: - startup binary (kstartup?) - shutdown binary (kshutdown) The DBus name org.kde.shutdown would initially go on ksmserver, then move to this

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Filip Fila
filipf added a comment. The position that current state is the one and only way really puzzles me if I'm trying to look at it rationally. Personally, I'm actually fine with they way things are and would probably not change much in my config, but I believe the following two arguments have

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread David Edmundson
davidedmundson added a comment. > What is this "mechanism" you are talking about? I'm intrigued! We have a mechanism for theme providers to change the OSD. (the whole LNF package stuff). They can override all qml, that qml does the positioning. The recurring pattern that we want to a

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread anonym
anonym added a comment. In D14949#335721 , @graesslin wrote: > It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the rest? For what it's worth: I opened this ticket an

D15920: [cursors] Also link for Breeze Snow

2018-10-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R31:54c6c189f9ba: [cursors] Also link for Breeze Snow (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15920?vs=42785&id=42787 REVISION DETAIL

D15920: [cursors] Also link for Breeze Snow

2018-10-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Same as D15889 for Breeze Snow REPOSI

D15889: [Cursors] link *-resize to *_corner cursor

2018-10-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R31:baab8494bbe9: [Cursors] link *-resize to *_corner cursor (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15889?vs=42698&id=42784 REVISION D

Re: My ksmserver plans

2018-10-03 Thread Marco Martin
On lunedì 1 ottobre 2018 13:46:56 CEST David Edmundson wrote: > I was making a few ksmserver patches, I thought I should document what my > long term plans are so the patches make sense. > > https://phabricator.kde.org/T9779 > > It's not an urgent task, so might spread over the next 2 releases.

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Filip Fila
filipf added a comment. What would be the problem in having both the option to turn the OSD off and having the option to change its appearance? The plasma-pa settings dialog is super uncluttered right now so I don't understand the argument that it would complicate things. As for the