D15011: [Kickoff] Make the search field always look like a search field

cfeck added a comment. David is on holidays, so maybe someone else could approve if this is urgent. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: cfeck, acrouthamel, fabianr, huftis, rooty, sharvey

D15333: Group Widget + Color Picker = Widget Out Of Bounds

cfeck added a comment. Any Plasma developer who has kdeplasma-addons installed to verify this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15333 To: McPain, #plasma, ngraham Cc: cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D15790: Follow the preferred mode if we're asked to (i.e. if under QXL)

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY As described in D15789 , follow the preferred mode when the backend

D15789: Support QXL hotplug_mode_update

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QXL is a driver used mainly in VMs. This driver, it creates a new preferred mode upon resize instead of j

D15786: share common values for both Breeze and Breeze-dark GTK themes

grmat added a comment. additional note: commit 1ea1e0f88d0812d0f7b8e542bd9eacee234a93ee is also strongly related to this change as it introduced lots of additional colour variables. For this change, the dark scheme wa

D14068: add -P switch to one-shot redshift call

ngraham added reviewers: Plasma, romangg, martinkostolny. ngraham added a comment. #plasma folks ping! REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: grmat, #plasma, romangg, martinkostolny Cc:

D15786: share common values for both Breeze and Breeze-dark GTK themes

grmat created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. grmat requested review of this revision. REVISION SUMMARY As described in bug #396091, the Breeze-dark theme is often neglected in updates. This patch fixes #396091 and some additional, related

[Powerdevil] [Bug 370966] Battery not recognized

https://bugs.kde.org/show_bug.cgi?id=370966 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[plasmashell] [Bug 360339] Plasma Crash on startup

https://bugs.kde.org/show_bug.cgi?id=360339 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Breeze] [Bug 364313] Umbrello crash

https://bugs.kde.org/show_bug.cgi?id=364313 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Breeze] [Bug 367818] Password textfield is not visible when using dm-crypt

https://bugs.kde.org/show_bug.cgi?id=367818 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Powerdevil] [Bug 364138] Power Management Problem Kubuntu 16.04

https://bugs.kde.org/show_bug.cgi?id=364138 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15785 To: ngraham, #plasma, broulik, mart, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

ngraham added a comment. Note: There is also `wallpapers/image/imagepackage/contents/config/main.xml` which has the same config data in it, but appears to be unused. I didn't make the change there as well because I couldn't find any place where the value was actually used, but if I should, l

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

ngraham created this revision. ngraham added reviewers: Plasma, broulik, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY 10 seconds isn't the best default value for slideshows. 15 minutes is more reasonab

D15304: [KCM] Port (almost) entirely to QQC2

ngraham updated this revision to Diff 42388. ngraham added a comment. Use QQC2 `ScrollView` and PlasmaCore `iconItem` REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=42329&id=42388 BRANCH arcpatch-D15304 REVISION DETAIL http

D15767: Don't apply configs in a loop

This revision was automatically updated to reflect the committed changes. Closed by commit R104:05ebba6b6e6e: Don't apply configs in a loop (authored by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15767?vs=42363&id=42382 REVISION DETAIL https://ph

D15776: Show the preferred resolution on the combo box

ngraham added a comment. I think the `favorite` icon is just fine. 👍 REPOSITORY R104 KScreen BRANCH preferredkcm REVISION DETAIL https://phabricator.kde.org/D15776 To: apol, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D15770: Expose the preferredModesChanged property change

apol requested review of this revision. apol added a comment. Sorry for the noise, this doesn't work. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D15770 To: apol, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15768: Fix using kscreen with qxl, follow the preferred mode

apol abandoned this revision. apol added a comment. Sorry for the noise, this doesn't work. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D15768 To: apol, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D15776: Show the preferred resolution on the combo box

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Code is neater. I like that. Don't have an opinion on the icon, maybe tag VDG. INLINE COMMENTS > resolutionslider.cpp:71 > +mComboBox->addItem(icon, Utils::

D15769: Show "muted" icon in panel and disable shortcuts for Dummy Output

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2ca95da77563: Show "muted" icon in panel and disable shortcuts for Dummy Output (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 42375. sharvey added a comment. - Changed PolKit description to `Description not provided` Was: "Missing" REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=33002&id=42375 BRANCH arcpat

D15304: [KCM] Port (almost) entirely to QQC2

ngraham planned changes to this revision. ngraham added a comment. In D15304#332274 , @drosca wrote: > There is `ScrollView` in QQC2 (since Qt 5.9), so please use it. Ah, I see now that it's only available in QQC 2.2 and later. Will do.

D15776: Show the preferred resolution on the combo box

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Usually there's a preferred resoluton for a display, let the user know it TEST PLAN Used the kcm with it

D15304: [KCM] Port (almost) entirely to QQC2

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. There is `ScrollView` in QQC2 (since Qt 5.9), so please use it. Also as @davidedmundson said, please edit the commit message. REPOSITORY R115 Plasma Audio Volume Applet REVISI

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

ngraham added a comment. @smithjd, since I know you expressed interest in interested in fixing this issue, would you like to become the assignee of this task and implement the following: - Short-term: by default, ship an exclude entry for `~/Vaults` - Long-term: don't index anything in

D15644: Provide option to hide menu bar for Ksysguard

ngraham accepted this revision. ngraham added a comment. Looks perfect to me. BTW, you can mark inline comments as done by clicking in their checkboxes and then clicking Submit on the bottom of the page (I know, I know, it's a bit weird). @sitter, does this look good to you now? REVISIO

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42368. lsartorelli added a comment. little clean up CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42350&id=42368 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsarto

D15768: Fix using kscreen with qxl, follow the preferred mode

broulik added inline comments. INLINE COMMENTS > daemon.cpp:421 > + > +connect(output.data(), &KScreen::Output::preferredModesChanged, > +this, [this, output](){ Doesn't this also need to be a `UniqueConnection` then? REPOSITORY R104 KScreen REVISION DETAIL https://

D15770: Expose the preferredModesChanged property change

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See D15768 REPOSITORY R110 KScreen Library BRANCH master REVISI

D15769: Show "muted" icon in panel and disable shortcuts for Dummy Output

broulik created this revision. broulik added reviewers: Plasma, drosca, nicolasfella, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The "Dummy Output" doesn't play any sound, so indicate that in the p

D15644: Provide option to hide menu bar for Ksysguard

sitter added a subscriber: broulik. sitter added inline comments. INLINE COMMENTS > ksysguard.cpp:148 > + // set up 'Settings' menu > + mShowMenuBarAction = KStandardAction::showMenubar(this, > SLOT(toggleShowMenuBar()), actionCollection()); > @broulik just pointed out that KStandardAction

D15768: Fix using kscreen with qxl, follow the preferred mode

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY When using a the qxl driver (for virtual machines), we'll be getting resizes of the display by changes o

D15644: Provide option to hide menu bar for Ksysguard

sitter added a comment. Looks almost perfect to me. Only nit-pick I have is the fact that the include is out of order. Other than that it looks awesome 👍 INLINE COMMENTS > ksysguard.cpp:54 > #include > +#include > That should be sorted alphabetically. REVISION DETAIL https://phabric

D15767: Don't apply configs in a loop

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Loop through all the changed bits then apply at once. It should trigger less unnecessary visual changes. TEST PLAN Restarted kded5, r

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. @davidedmundson ping again. I believe we've resolved the outstanding visual issues and I have addressed all of the technical issues you found, so I will land this for Plasma 5.15 on September 31st if I don't hear any new objections before them. REPOSITORY R119 Pla

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

ngraham added a comment. In T8066#161715 , @bruns wrote: > As a stopgap measure blacklisting ~/Vaults is probably ok. > Long term, blacklisting *all* encrypted file systems IMHO is the way to go, as this is an information leakage. > Of cours

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

bruns added a comment. As a stopgap measure blacklisting ~/Vaults is probably ok. Long term, blacklisting *all* encrypted file systems IMHO is the way to go, as this is an information leakage. Of course, if the complete home is encrypted, i.e. content and index reside in the same encrypte

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

ngraham added a comment. The default path for vaults to be mounted to is `~/Vaults`; a naive solution would be to ship Baloo with an exclude rule for `~/Vaults`. A slightly smarter approach would be for Plasma Vaults itself to add such a rule for whatever mountpoint is chosen during new vaul

Re: How to contribute

On domenica 23 settembre 2018 21:57:41 CEST tajames wrote: > gotchas when compiling Plasma Mobile? Lastly, of course, I'm looking for a > small, simple project to get started with. Ideally, I'd like someone to > look over my code when it's done and tell me what I should be doing > differently - wi

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42350. lsartorelli added a comment. Removed unused parameter in toggleShowMenuBar() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42298&id=42350 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.c