D15093: Add WireGuard capability.

jgrulich added a comment. In D15093#327889 , @andersonbruce wrote: > Since I added a validator function for the WireGuard style keys, is there any way to assign a validator to the PasswordField widget without a fairly substantial rewrite of tha

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. note there are still few "not done" comments around (eg using QSpinBox for fwMark) INLINE COMMENTS > CMakeLists.txt:28 > Widgets > +Test > ) already added by D15520: Upgra

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

andersonbruce updated this revision to Diff 41878. andersonbruce added a comment. - Remove unnecessary includes and member functions REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15520?vs=41875&id=41878 BRANCH IP4/6validatorsUpd

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

pino added a comment. - please remove all the empty `initTestCase()` in tests INLINE COMMENTS > simpleiplistvalidator.cpp:27-28 > +SimpleIpListValidator::SimpleIpListValidator(QObject *parent, > + AddressStyle style, > +

D15093: Add WireGuard capability.

andersonbruce added a comment. Since I added a validator function for the WireGuard style keys, is there any way to assign a validator to the PasswordField widget without a fairly substantial rewrite of that class? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https:/

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce added a comment. In D15521#327222 , @jgrulich wrote: > Maybe merge this review with D15520 . I think they should go together. I believe that I have now moved all the changes from this revi

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

andersonbruce updated this revision to Diff 41875. andersonbruce added a comment. - Merge new IP list validator into this branch - Update from review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15520?vs=41677&id=41875

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 41874. andersonbruce marked an inline comment as done. andersonbruce added a comment. - Remove changes moved to review D15520 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https:/

D15578: [Notifications] Store "Open..." action in history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a8b71fe5c017: [Notifications] Store "Open..." action in history (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15578?vs=41845&id=418

D15578: [Notifications] Store "Open..." action in history

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Notifications.qml:95 > +var actions = notification.actions.filter(function (item) { > +return item.id.indexOf("jobUrl#") ===

D15578: [Notifications] Store "Open..." action in history

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Actions stop working when the original notification goes away, however the "Open..." notification

D15504: [Output Config] Fix transformation matrix for rotation icon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:fca1c2f25657: [Output Config] Fix transformation matrix for rotation icon (authored by broulik). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15504?vs=41635&id=41

D15571: Sync attribution metadata for SDDM theme to LNF

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6234aaa3680b: Sync attribution metadata for SDDM theme to LNF (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15571?vs=41816&i

D15571: Sync attribution metadata for SDDM theme to LNF

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It had my name for historic reasons before moving about, but given Plasma s

[Breeze] [Bug 379022] Update Task Switcher screenshots

https://bugs.kde.org/show_bug.cgi?id=379022 Alexander Mentyu changed: What|Removed |Added CC||tterrani...@gmail.com --- Comment #5 from Al

Meeting notes for 17/09/2018

Eike: * [General] Various last-minute code reviews and landings of important pending patches for 5.14 beta * [TM] Another LibreOffice workaround: Starting a sub-app from the LibreOffice start center will now correctly hide a pinned launcher for the app * [TM] Fixed reordering tasks by DND in a grou

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce added inline comments. INLINE COMMENTS > jgrulich wrote in simpleiplistvalidator.cpp:39 > In both validator constructors (mean also for IPv6 one), you can directly > pass "style" param from contructor, given both enums seem to be identical. They are the same now but initially they

D15093: Add WireGuard capability.

jgrulich added a comment. Please, update all your reviews so they don't duplicate changes. I would personally have one review for all your IPv[4,6]Validator changes and one review just for WireGuard VPN plugin. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://pha

D15568: Fix finding QtQuick

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e8eac8fc461: Fix finding QtQuick (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15568?vs=41796&id=41799 REVISION DETAIL https://phabricator.k

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added a comment. Any update on this? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin Cc: zzag, romangg, anthonyfieroni, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, Z

D15568: Fix finding QtQuick

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks for tracking this down ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15568 To: broulik, #plasma, tundracomp, hpereiradacosta Cc: plasma-

D15568: Fix finding QtQuick

broulik created this revision. broulik added reviewers: Plasma, tundracomp. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is `QtQuick_FOUND`, not `Qt_Quick_FOUND`. This broke all special-casings for QtQuic