D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce added a comment. In D15521#327222 , @jgrulich wrote: > Maybe merge this review with D15520 . I think they should go together. Can you please discuss this with Pino, he was the one who sugg

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. - same notes for `simpleipv6test.cpp` as in `simpleipv4test.cpp` INLINE COMMENTS > CMakeLists.txt:11-13 > +add_executable(simpleipv6test ${simpleipv6test_SRCS}) > +add_test(simpleipv6

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce marked 3 inline comments as done. andersonbruce added inline comments. INLINE COMMENTS > jgrulich wrote in CMakeLists.txt:92 > I'm sure you don't need to add all these and why did you remove PUBLIC and > PRIVATE keywords? Damn, copied the wrong file. Sorry about that. REPOSITORY

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce updated this revision to Diff 41794. andersonbruce added a comment. - Correct CMakefile I screwed up Updating D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on re

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. - same note as in D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator regarding the commit, and the summary of this review

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

jgrulich added a comment. Maybe merge this review with D15520 . I think they should go together. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15521 To: andersonbruce, jgrulich, pino Cc: plasma-devel, ra

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

jgrulich added inline comments. INLINE COMMENTS > CMakeLists.txt:92 > qca-qt5 > +KF5::NetworkManagerQt > +KF5::Service I'm sure you don't need to add all these and why did you remove PUBLIC and PRIVATE keywords? > CMakeLists.txt:111 > if (WITH_MODEMMANAGER_SUPPORT) > -target_

D15093: Add WireGuard capability.

andersonbruce marked an inline comment as done. andersonbruce added inline comments. INLINE COMMENTS > jgrulich wrote in wireguardadvancedwidget.cpp:104 > I would prefer having just an empty map with data where you just set > everything the user configured in UI, removing options from existing d

D15206: [Kickoff] Add a subtle separator line between the header and the content view

ngraham added a comment. @mmustac, I believe I've addressed your concern now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abetts, mmustac, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D15206: [Kickoff] Add a subtle separator line between the header and the content view

ngraham updated this revision to Diff 41788. ngraham added a comment. Adjust top margin on Favorites view to make sure that the top item doesn't touch the new line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15206?vs=40823&id=41788 BRANCH kick

D15093: Add WireGuard capability.

acrouthamel added a comment. Thank you @andersonbruce for all of your work on this, and quickly working on feedback changes! This will be a great addition. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgr

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. @davidedmundson ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: acrouthamel, fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts,

D10429: Disable the title bar separator by default

IlyaBizyaev added a comment. I think this line's goal is not really to separate the title bar from window content, but instead to make the transition smoother and emphasize style consistency. Take a look at these 2 screenshots, for example. F6267692: Screenshot_20180916_124803.png

D15550: Move correct indices in the manual sort map when getting a move() call for group children

hein created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY Due to not passing `parent` to QAIM::index(), we were moving top-level indices in the map instead. This meant the sort map would become

D15093: Add WireGuard capability.

andersonbruce marked 45 inline comments as done. andersonbruce added inline comments. INLINE COMMENTS > pino wrote in wireguard.cpp:121 > better use qt's foreach here: > > Q_FOREACH (const QString &address, valueList) > > and then using `address` instead of `valueList[i]` Used plain 'for' in

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 41736. andersonbruce added a comment. - Add tests for new and updated ip validators - Update ip validators - Add validator for WireGuard keys - Update per review comments - Add error messages for failure cases REPOSITORY R116 Plasma Network