D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

ngraham added a comment. In D15341#323715 , @smithjd wrote: > KRunner as a standalone application does much more than search for files. Therefore adding independent shortcut configurability isn't so hard to justify. Kicker/Kickoff and dolphin se

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

smithjd added a comment. In D15341#323704 , @ngraham wrote: > In D15341#323672 , @smithjd wrote: > > > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search f

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

ngraham added a comment. In D15341#323672 , @smithjd wrote: > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search fields for Baloo. 1. Kicker/Kickoff actually are: they're full-fledged inter

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

smithjd added a comment. In D15341#322618 , @ngraham wrote: > I appreciate the patch and the fact that you considered the prior comments in D14739 . But I must admit I'm still left with a nagging question: "Wh

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. @davidedmundson - good to go? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D14806: [AppStream Runner] Reduce verbosity of log output

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol, ngraham Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D15410: Handle clients which change window metadata during early startup

hein added a comment. In D15410#323613 , @graesslin wrote: > I just want to point out that such applications are not ICCCM compliant: This property must be present when the window leaves the Withdrawn state and may be changed only while the win

D15410: Handle clients which change window metadata during early startup

graesslin added a comment. I just want to point out that such applications are not ICCCM compliant: This property must be present when the window leaves the Withdrawn state and may be changed only while the window is in the Withdrawn state. Window managers may examine the property only when

D15410: Handle clients which change window metadata during early startup

hein updated this revision to Diff 41356. hein edited the summary of this revision. hein added a comment. Add conclusion to description. Done now, promise. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15410?vs=41355&id=41356 BRANCH master REV

D15410: Handle clients which change window metadata during early startup

hein updated this revision to Diff 41355. hein added a reviewer: ngraham. hein added a comment. Add back Nate. Now I'm committed to using `arc diff --verbatim`, sorry. :P REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15410?vs=41354&id=41355 BRANC

D15410: Handle clients which change window metadata during early startup

hein updated this revision to Diff 41354. hein edited the summary of this revision. hein added a comment. Improve description further. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15410?vs=41353&id=41354 BRANCH master REVISION DETAIL https:

D15410: Handle clients which change window metadata during early startup

hein updated this revision to Diff 41353. hein edited the summary of this revision. hein removed a reviewer: ngraham. hein added a comment. Fix typo in description. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15410?vs=41352&id=41353 BRANCH ma

D15410: Handle clients which change window metadata during early startup

hein created this revision. hein added reviewers: davidedmundson, broulik. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Some apps initially show their window with bogus/useless window metadata and then update to useful metadata during early startup.

D15202: Move kcheckrunning into startkde

davidedmundson updated this revision to Diff 41351. davidedmundson added a comment. Add missing file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15202?vs=40814&id=41351 BRANCH dave2 REVISION DETAIL https://phabricator.kde.org/D15202 AFFEC

D15391: [Bookmarks Runner] Fix cleanup of favicon directory

This revision was automatically updated to reflect the committed changes. Closed by commit R120:140b908e4c17: [Bookmarks Runner] Fix cleanup of favicon directory (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15391?vs=41300&id=413

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c8358c203f11: Don't consider filtered out tasks siblings when sorting in new tasks (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14392

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R119:45c420b7fd11: [Folder View] Hide /home/foo/Desktop place in configuration (authored by broulik). REPOSITORY R119

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

broulik updated this revision to Diff 41331. broulik added a comment. Indeed I did :) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14426?vs=41318&id=41331 REVISION DETAIL https://phabricator.kde.org/D14426 AFFECTED FILES containments/desktop/

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

hein added inline comments. INLINE COMMENTS > broulik wrote in tasksmodel.cpp:561 > Now it's no longer "Pre filter", is it? `sortedPreFilterRows` is a list of pre-filter row indices we use for sorting. Moving its contents around doesn't change the fact that those contents are row indices from

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

hein added a comment. Did you forget to update the diff? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14426 To: broulik, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

hein added a comment. Let's not bother with it then, thanks for looking into it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

Monday meeting notes for 2018-09-10 (week 37)

Roman DONE * Pushed some KWayland fixes * D15256: Fix for serveral bugs because of 5.13 Mouse KCM rewrite * Wrote a blog post about my experience at Akademy: http://www.subdiff.de/2018/09/09/my-first-akademy-in-retrospect/ PLAN * Upload last Xwl dnd patches. * P

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

broulik added inline comments. INLINE COMMENTS > tasksmodel.cpp:561 > + if (filterProxyIndex.isValid()) { > +sortedPreFilterRows.move(row, i + 1); > +moved = true; Now it's no longer "Pre filter", is it? REPOSITORY

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

broulik updated this revision to Diff 41318. broulik edited the summary of this revision. broulik added a comment. - Make `KFilePlacesModel` `static` and ref-counted For simplicify the ref count is increased/decreased in the constructor and not depending on whether the model is actually u

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik added a comment. I just `setDynamicSortFilter(false);` in the constructor and `setDynamicSortFilter(true);` in `QQmlParserStatus::componentComplete()` but it doesn't make a difference. The `filterAcceptsRow()` method is called the same number of times upon opening the config dialog

D15315: Set gtk-modules to auto-load appmenu-gtk-module

broulik updated this revision to Diff 41316. broulik added a comment. - Write into `~/.gtkrc-2.0`, the `GTK2_RC_FILES` variable isn't present for apps launcher by Plasma or KRunner, for some reason (probably only stuff launched through klauncher) REPOSITORY R120 Plasma Workspace CHANGES S