D15011: [Kickoff] Make the search field always look like a search field

rooty added a comment. In D15011#318474 , @ngraham wrote: > I'm working on patches to reduce the visual weight of the focus ring and add some horizontal separators to Kickoff. Those will be submitted as separate patches. Where are we with this o

D15011: [Kickoff] Make the search field always look like a search field

acrouthamel added a comment. In D15011#314963 , @filipf wrote: > To add more to the analysis, since Kickoff is a plasmoid, what seemed like a good idea to me was to have a look at how other plasmoids are designed (especially with relevance to th

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. I'm working on patches to reduce the visual weight of the focus ring and add some horizontal separators to Kickoff. Those will be submitted as separate patches. Where are we with this one? Are people okay with it in conjunction with the aforementioned visual tweaks?

D15187: Merge switch user dialog into lockscreen

davidedmundson added a comment. There's another patch today too. (Can't find it on my phone now) But in any case it we never blur the switch user screen REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D15187 To: davidedmundson, #plasma,

D15187: Merge switch user dialog into lockscreen

ngraham added a comment. In D15187#318464 , @davidedmundson wrote: > There's another patch today too. (Can't find it on my phone now) > > But in any case it we never blur the switch user screen Perfect. No UI objections then! REPOSIT

D15187: Merge switch user dialog into lockscreen

davidedmundson added a comment. See 15186 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D15187 To: davidedmundson, #plasma, mart Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40792. phuongn added a comment. Agree! Updated 🙂 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40791&id=40792 REVISION DETAIL https://phabricator.kde.org/D14989 AFFECTED FILES containmentactions

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

abetts added a comment. I like that string better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14989 To: phuongn, #plasma Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

ngraham added a comment. In D14989#318428 , @phuongn wrote: > Ok! I updated the string, it's now "Enable desktop navigation wraps around" Hmm, now that's no longer grammatically correct. How about: "Enable virtual desktop navigation wrapp

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40791. phuongn added a comment. Ok! I updated the string, it's now "Enable desktop navigation wraps around" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40619&id=40791 REVISION DETAIL https://phab

D15187: Merge switch user dialog into lockscreen

ngraham added a comment. Doesn't build for me: make[2]: *** No rule to make target '/usr/share/dbus-1/interfaces/org.kde.screensaver.xml', needed by 'ksmserver/kscreenlocker_interface.cpp'. Stop. CMakeFiles/Makefile2:3454: recipe for target 'ksmserver/CMakeFiles/kdeinit_ksmserver

D14805: [AppStream Runner] Use categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R120:86e3748f904a: [AppStream Runner] Use categorized logging (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14805?vs=40777&id=40781 REVIS

D14804: [AppStream Runner] Pass on error message from the library

This revision was automatically updated to reflect the committed changes. Closed by commit R120:74a38143e213: [AppStream Runner] Pass on error message from the library (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14804?vs=40772&

D14805: [AppStream Runner] Use categorized logging

bruns updated this revision to Diff 40777. bruns added a comment. Change all other (one) occurences of qWarning(), there is no qDebug() etc. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14805?vs=40773&id=40777 BRANCH appstream_runner_2 REVISI

D14806: [AppStream Runner] Reduce verbosity of log output

bruns updated this revision to Diff 40774. bruns added a comment. rebase after D14807 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14806?vs=39636&id=40774 BRANCH appstream_runner_3 REVISION DETAIL https:

D14805: [AppStream Runner] Use categorized logging

bruns updated this revision to Diff 40773. bruns added a comment. rebase after D14807 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14805?vs=39635&id=40773 BRANCH appstream_runner_2 REVISION DETAIL https:

D14804: [AppStream Runner] Pass on error message from the library

bruns updated this revision to Diff 40772. bruns added a comment. rebase after D14807 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14804?vs=39634&id=40772 BRANCH appstream_runner_1 REVISION DETAIL https:

D14807: [AppStream Runner] Also search when there were errors during Pool::load

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ec3f76810b7: [AppStream Runner] Also search when there were errors during Pool::load (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D15187: Merge switch user dialog into lockscreen

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. lovely code deletions :) and yeah, requiring the passowd again to cancel user switching kinda makes sense, it shouldn't be an issue INLINE COMMENTS > server.cpp:1095 > +OrgKdeScreensaver

D15187: Merge switch user dialog into lockscreen

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This reduces a bunch of code, both hidden in the backend as well as the mos

D15186: Install our org.kde.screensaver interface definition

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KScreenLocker has two interfaces, the FDO interface and a custom interface

D15185: Fix kscreenlocker_greet --switchuser

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Years ago support was added for the lockscreen to default into switch user

D14806: [AppStream Runner] Reduce verbosity of log output

bruns added a comment. In D14806#316424 , @apol wrote: > Because your commits change all very closely related things and even fix each other. first yes, second no. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D15169: Custom toolbars

apol added a comment. +1 cool stuff! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15169 To: mart, #kirigami, lepagevalleeemmanuel Cc: apol, plasma-devel, davidedmundson, mart, hein

D14807: [AppStream Runner] Also search when there were errors during Pool::load

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. whatever. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, #frameworks, apol Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. As I said, that violates https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets and I prefer to keep these apart. This one fixes the behaviour, and has a separate bug report. The other ones change logging and are quite independent. REPOSI

D14807: [AppStream Runner] Also search when there were errors during Pool::load

apol added a comment. Ugh, like I said, can you please squash them into a commit? They are good changes in general. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, #frameworks Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, le

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich, sitter, jriddell Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,