D15093: Add WireGuard capability.

pino added a comment. In D15093#315885 , @andersonbruce wrote: > As far as the 'passwordfield' files, this was just laziness on my part, it being easier to just copy them than figure out how to get cmake (another tool I haven't used much) to ad

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Misc notes: - please remove all the translations (i.e. `Name=[lang]` & `Comment[lang]` from desktop/json files, since KDE has an automatic system to handle them - please use KCo

D15093: Add WireGuard capability.

andersonbruce added a comment. In D15093#315877 , @lbeltrame wrote: > Some smallish nitpicks I noticed there. Also, does this mean that NM has WG support now? Yes there is an add-on available. The original is at https://github.com/max-m

D15093: Add WireGuard capability.

lbeltrame added a comment. In D15093#315885 , @andersonbruce wrote: > > As to copyright notice, I see that most are listed with name and email address. Is the latter expected or is just name enough? I don't have a business email

D15093: Add WireGuard capability.

andersonbruce added a comment. In D15093#315875 , @ngraham wrote: > Wow, what a first patch! And you even used `arc` too, how nice. > > Since this fixes https://bugs.kde.org/show_bug.cgi?id=397572, can you indicate it as such in the Summary s

D15093: Add WireGuard capability.

lbeltrame added a comment. Some smallish nitpicks I noticed there. Also, does this mean that NM has WG support now? I'll also let @jgrulich comment on this, but I'm not too fond of the manual parsing of the INI-like file used by WG. While I can't check at the moment, there should be KF5

D15093: Add WireGuard capability.

ngraham added reviewers: Plasma, jgrulich. ngraham added a comment. Wow, what a first patch! And you even used `arc` too, how nice. Since this fixes https://bugs.kde.org/show_bug.cgi?id=397572, can you indicate it as such in the Summary section per https://community.kde.org/Infrastructur

D15093: Add WireGuard capability.

andersonbruce created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andersonbruce requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH Feature/AddWireGuardVPN REVISION DETAIL https://phabricator.kde.org/D15093

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. In D15011#315864 , @abetts wrote: > Interesting. I can change my opinion here. Should we then make sure that all the examples shown in the table behave the same? They all do //behave// the same, they just don't //

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. In D15011#315863 , @ngraham wrote: > In D15011#315816 , @abetts wrote: > > > I agree that our HIG needs to explain focus better. It doesn't really have to be a long HIG about

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. In D15011#315816 , @abetts wrote: > I agree that our HIG needs to explain focus better. It doesn't really have to be a long HIG about it. It could just be a general rule about the way that fields get their focus. In my m

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. > However, regardless of what we choose, I would like to move towards unifying the interfaces in the above table, because inconsistency in something basic like this is not good. So if we decide to make search fields that have keyboard focus by default not visibly focu

D15011: [Kickoff] Make the search field always look like a search field

ngraham requested review of this revision. ngraham added a comment. Awesome, thanks for introducing that additional information. It seems like we have some inconsistency here in our Plasma search fields; I will summarize: | Interface | Search field has keyboard focus by default? | S

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. I really like the last suggestion from Filip. It blends well with the theme. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: rooty, sharvey, romangg, broulik, safaalfulaij, oy

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich you didn't change FindSPA, is it ok? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel, sche

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham resigned from this revision. ngraham added a comment. OK, maybe there's something weird with my config somehow. :/ Can anyone else reproduce? In the meantime @progwolff, maybe it would be best to continue anyway until and unless anyone else can confirm my issue. Is this reviewabl

D15011: [Kickoff] Make the search field always look like a search field

michaeltunnell added a comment. This is great! This is pretty much exactly what I originally suggested and yet has some tweaks to make it even better. Thanks for doing this. :) 👍 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I installed a fresh Neon (dev unstable), removed the preinstalled files from /etc/fonts, copied your files to /etc/fonts and applied this patch. Still cannot reproduce your issue. F6216652: Screenshot_20180826_151000.png

D15086: Fix localization of QML code

yurchor updated this revision to Diff 40460. yurchor added a comment. Adding more context to the messages REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15086?vs=40458&id=40460 REVISION DETAIL https://phabricator.kde.org/D15086 AFFECT

D15086: Fix localization of QML code

lueck added a comment. probably the strings with "%1 : %2" need context for propr tarnslation INLINE COMMENTS > CurrentWeatherType.qml:191 > Component.onCompleted: { > -weatherMinLabel.text = "Minimum Temperature: " + slttemp > +weather

D15086: Fix localization of QML code

yurchor updated this revision to Diff 40458. yurchor added a comment. Getting rid of French punctuation REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15086?vs=40450&id=40458 REVISION DETAIL https://phabricator.kde.org/D15086 AFFECTED

D15086: Fix localization of QML code

huftis added a comment. You could take the opportunity to change the ‘French’ punctuation in the three `"%1 : %2"` strings to proper English punctuation, i.e. `"%1: %2"`. REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D15086 To: yurchor, Aiix, #lo

D15086: Fix localization of QML code

yurchor created this revision. yurchor added reviewers: Aiix, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY The current code contains untranslatable messages and word puzzles [1]. This patch tri