KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.11 - Build # 1 - Failure!

2018-08-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 25 Aug 2018 01:47:19 + Build duration: 1 hr 17 min and counting CONSOLE

KDE CI: Plasma kdeplasma-addons stable-kf5-qt5 FreeBSDQt5.11 - Build # 1 - Failure!

2018-08-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20stable-kf5-qt5%20FreeBSDQt5.11/1/ Project: Plasma kdeplasma-addons stable-kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 25 Aug 2018 00:58:03 + Build duration: 1 hr 33 min and counting

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Filip Fila
filipf added a comment. To add more to the analysis, since Kickoff is a plasmoid, what seemed like a good idea to me was to have a look at how other plasmoids are designed (especially with relevance to the elements touched on in this proposal). The Clipboard plasmoid stood out to me beca

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-24 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Let's continue the first part of the discussion in T9500: UI scaling . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869 To: ngraham, #plasma, #kde_applications,

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Root
rooty added a comment. In D15011#314812 , @ngraham wrote: > I like the idea of conditionally adding a little magnifying glass icon to the text field to indicate that it's a search field. If other folks are on board too, I can probably put togeth

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Safa Alfulaij
safaalfulaij added a comment. In D15011#314738 , @filipf wrote: > Exactly! In your second proposal I don't think the serachbox sticks out, even as it is. At least to me it looks fine. At the same time it is drawing back, albeit not totally, to o

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Nathaniel Graham
ngraham added a comment. I like the idea of conditionally adding a little magnifying glass icon to the text field to indicate that it's a search field. If other folks are on board too, I can probably put together another patch to add that as an optional feature of the PlasmaComponents TextFi

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Filip Fila
filipf added a comment. In D15011#314744 , @ngraham wrote: > Of your mockups, I like the last one the best, but nonetheless I'm just not a fan of defining a custom textfield style here; I think we should follow the HIG. If we had a dedicated "se

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Andres Betts
abetts added a comment. Maybe something I can explain, for us designers, is that we have a set of defined rules and guidelines for visual design on KDE and we should strive to first search for an option that is adapted or allowed by these guidelines. If that doesn't work, we could propose ot

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Nathaniel Graham
ngraham added a comment. Of your mockups, I like the last one the best, but nonetheless I'm just not a fan of defining a custom textfield style here; I think we should follow the HIG. If we had a dedicated "search field" control that was more subtle than general textfields, we could use that

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Filip Fila
filipf added a comment. In D15011#314514 , @ngraham wrote: > I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example: Exactly! In your second proposal I do

D14855: Add applet with screen layouts and presentation mode

2018-08-24 Thread Frederik Gladhorn
gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. OK, let's do it :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy, gladhorn Cc: anthonyfieroni, ngraham,

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Root
rooty added a comment. In D15011#314514 , @ngraham wrote: > Actually both Kicker and System Settings give their search fields visible focus by default. Kicker does make the field visibly lose focus after you start using the keyboard to navigate

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

2018-08-24 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > McPain wrote in soliddeviceengine.cpp:560 > Any ideas how to do it correctly? It has a default parameters just call event with 3 parameters not 5. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedm

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

2018-08-24 Thread Oleg Solovyov
McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:560 > Sure, it /might/ work, but you're still fetching a random window N seconds > after a user event. > > I don't see how we can know that will result in correct behaviour. Any ideas how to do it co

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Safa Alfulaij
safaalfulaij added a comment. Why don't we have a simple search icon that indicates that one can search in the kickoff, and once you click on it you get switched to the search layout, where you'll find a note saying you can also search by direct typing, and a “Got it” as many websites does?