D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

smithjd abandoned this revision. smithjd added a comment. Closing this because it breaks at least the settings:// ioslave, and the tags:// slave no longer has urls attached to the filename. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D13291 To: smithjd,

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a subscriber: sharvey. ngraham added a comment. Actually both Kicker and System Settings give their search fields visible focus by default. Kicker does make the field visibly lose focus after you start using the keyboard to navigate through the list of returned items, though. T

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. @davidedmundson ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. Are you going to land this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, b

D15011: [Kickoff] Make the search field always look like a search field

ngraham planned changes to this revision. ngraham added a comment. In D15011#314167 , @romangg wrote: > In D15011#314138 , @ngraham wrote: > > > So basically, you want it to be unfocused by default,

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. In D13291#314252 , @smithjd wrote: > This used to work for the Baloo tags:// ioslave, Oh, as you mention it, in future do **not** push to baloo without going through review - you have done this several times now, an

D14949: Add option for whether to show the volume change OSD

anonym added a comment. In D14949#312757 , @ngraham wrote: > Simply making it smaller wouldn't really help the submitter's use case very much anyway since it would still show up and cover up //something//. Yes; I would be completely happy

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

smithjd added a comment. In D13291#314199 , @bruns wrote: > In D13291#314195 , @smithjd wrote: > > > kioclient5 ls settings:/ > > system-administration > > > > dolphin settings:/ > > System

D15026: Fetch high-resolution image from Bing

kossebau resigned from this revision. kossebau added a comment. Sorry, I do not have time for Plasma things these months. No maintainer here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15026 To: carmenbianca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesli

D15026: Fetch high-resolution image from Bing

carmenbianca created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carmenbianca requested review of this revision. REVISION SUMMARY When visiting https://www.bing.com/HPImageArchive.aspx?format=js&idx=0&n=1, the URL field of the image is not always 1920

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. F6211779: Screenshot_20180823_212008.png F6211778: Screenshot_20180823_212035.png As you can see, as soon as you start to edit the URL, the UDS_NAME is used. Probably something

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. In D13291#314195 , @smithjd wrote: > kioclient5 ls settings:/ > system-administration > > dolphin settings:/ > System Administration In dolphin, you can click on "System Administration". With kioclient5, I c

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

ngraham added a comment. before-and-after screenshots from Dolphin would also help, as would a Bugzilla ticket or steps to reproduce, or anything else. Otherwise it's a bit hard to evaluate why this change is desirable. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricat

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. In D13291#314195 , @smithjd wrote: > kioclient5 ls settings:/ > system-administration > > dolphin settings:/ > System Administration That belongs into the test plan, of course with the needed context. REPOS

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

smithjd added a comment. kioclient5 ls settings:/ system-administration dolphin settings:/ System Administration REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D13291 To: smithjd, #plasma Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot,

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. In D15011#314181 , @davidedmundson wrote: > > @davidedmundson, does this look okay now? > > Code wise, yes. > > UI/Concept wide, I don't want to have an opinion either way Thanks Dave REPOSITORY R119 Pla

D15011: [Kickoff] Make the search field always look like a search field

davidedmundson added a comment. > @davidedmundson, does this look okay now? Code wise, yes. UI/Concept wide, I don't want to have an opinion either way REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson,

D15011: [Kickoff] Make the search field always look like a search field

romangg added a comment. In D15011#314138 , @ngraham wrote: > So basically, you want it to be unfocused by default, and typing (or clicking in it, obviously) makes it focused. True that. With the exception that beginning to type should ac

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. In D15011#314154 , @filipf wrote: > Yeah Nate, but if you look at your responses they're predominantly on a much higher level of abstraction (e.g "next step", "change is scary") than the issues raised. That's why for me t

D15011: [Kickoff] Make the search field always look like a search field

filipf added a comment. Yeah Nate, but if you look at your responses they're predominantly on a much higher level of abstraction (e.g "next step", "change is scary") than the issues raised. That's why for me they don't address them completely. The fact here is that you have a unibody Kic

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. So basically, you want it to be unfocused by default, and typing (or clicking in it, obviously) makes it focused. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: romangg, br

D15011: [Kickoff] Make the search field always look like a search field

romangg added a comment. Apparently the discoverability of the search field is poor, so it makes sense to make it more prominent. But the cursor should not flash all the time and having it all the time in Plasma blue with bright white background is also problematic. So I would propose the fo

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. @davidedmundson, does this look okay now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, mi

D15011: [Kickoff] Make the search field always look like a search field

ngraham updated this revision to Diff 40306. ngraham added a comment. Remove FIXME now that it's being worked around with D15021 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15011?vs=40300&id=40306 BRANCH ki

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. Thanks for the kind words. I don't think the objections have been ignored, though: Objection: > but my question is: is it possible to somehow make a toggle to keep the status quo ie. have no search box? [...] I urge you again to please consider leaving an o

D15024: Update icons kcm docbook to 5.13

abetts added a comment. I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was before BUT where the preview image used to be, have the new gallery item look? REP

D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eac5d2e40e1e: [MPRIS Data Engine] Avoid blocking calls in media shortcuts handling (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14

D15024: Update icons kcm docbook to 5.13

lueck added reviewers: Plasma, Documentation. lueck added a comment. F6211258: get-new-theme.png F6211257: main.png F6211256: use-of-icons.png F6211255: edit-delet

D15024: Update icons kcm docbook to 5.13

lueck created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY apply chanches from [Icon KCM] Port to new design https://phabricator.kde.org/D12459 TEST PLAN checkXM

D15011: [Kickoff] Make the search field always look like a search field

filipf added a comment. I've joined partly because feeling some blunders on my skin; I'd like to contribute so that something like the 5.13 media icons thing doesn't happen again (ie. find potential problems for non-Breeze users), but also due to feeling like that some changes get proposed w

D15011: [Kickoff] Make the search field always look like a search field

abetts accepted this revision. abetts added a comment. I like this idea, it is easier to discover. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, fil

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. Can you please give an example? 1. Exact command 2. Current output 3. Expected output REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D13291 To: smithjd, #plasma Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngra

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. In D15011#314078 , @filipf wrote: > There doesn't have to be one solution and this is hardly an issue where such a hardline approach is warranted. There is nothing cold, stark or undifferentiated about Kickoff and its se

D15011: [Kickoff] Make the search field always look like a search field

filipf added a comment. There doesn't have to be one solution and this is hardly an issue where such a hardline approach is warranted. There is nothing cold, stark or undifferentiated about Kickoff and its search bar now. It's just that it's a problem for people who aren't as intuitive with

D14672: [plasma-changeicons] Call sync() after writing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:716deea83dae: [plasma-changeicons] Call sync() after writing (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14672?vs=39254&id=40301 R

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. To address the design and aesthetic angle, I see this as the natural next step in refining what "minimalism" means to KDE, which is a microcosm of a larger trend throughout the design world vis-a-vis minimalism: 1. People go crazy with decorations, frames, lines,

D15011: [Kickoff] Make the search field always look like a search field

broulik added a comment. The fact that the search field in Kickoff isn't permanently visible is a criticism I heard at various exhibitions where I showcased Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmunds

D15011: [Kickoff] Make the search field always look like a search field

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in Header.qml:66 > What's this about? Negative offsets are weird, and we also have a 300ms > animation to move 1px? I was copying this from the original, but yeah, it did seem weird to me too. Removed. > davidedmundson wrot

D15011: [Kickoff] Make the search field always look like a search field

ngraham updated this revision to Diff 40300. ngraham marked 5 inline comments as done. ngraham added a comment. - Address review comments - Stop working around TextField bugs - Remove the timer; it was overkill and didn't work perfectly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D15011: [Kickoff] Make the search field always look like a search field

safaalfulaij added a comment. The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not clear if one can search or not, because of text changing. Why not just keeping the current “Type to search” label as is, and move the user@host text up as in the patch? Also please

D15018: [Folder Model] Use document-properties icon for "Properties" context menu entry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6bfd40c06eb6: [Folder Model] Use document-properties icon for "Properties" context menu entry (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D15018: [Folder Model] Use document-properties icon for "Properties" context menu entry

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it consistent with other places where such an entry exists, such as Dolphin's context

D15011: [Kickoff] Make the search field always look like a search field

oysteins added a comment. In D15011#313872 , @filipf wrote: > although if I think of my parents for example I do see how they might miss it This was the rationale behind my bug report about this; that some users might be puzzled about th

D15011: [Kickoff] Make the search field always look like a search field

anthonyfieroni added a comment. I'm -1 for this, it's not needed to click in just start typing witch is more intuitive. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: anthonyfieroni, filipf, abetts, davide

D15011: [Kickoff] Make the search field always look like a search field

filipf added a comment. Heh, in my opinion the blended in searching is what added elegance to Kickoff compared to its KDE 4 version. The search box just sticks out quite a bit and for me "type to search" is indicative enough, although if I think of my parents for example I do see how they mi