D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-13 Thread Stefan Brüns
bruns created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The return code of the Pool::load() method is somewhat misleading, as it returns true only if there we

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-13 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Its rather pointless to spew an error message each time a query is done.

D14805: [AppStream Runner] Use categorized logging

2018-08-13 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Add category org.kde.plasma.runner.appstream, like done for the Services

D14804: [AppStream Runner] Pass on error message from the library

2018-08-13 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY AppStreamQt since 0.10.6 allows to pass on error messages in case some

D14794: Port away from KLocale and KDELibs4Support

2018-08-13 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14794 To: volkov, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14794: Port away from KLocale and KDELibs4Support

2018-08-13 Thread Alexander Volkov
volkov updated this revision to Diff 39618. volkov added a comment. QLocale::nativeCountryName() may return an empty string, fallback to using QLocale::countryToString() in this case. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D14793: Update connection details only when necessary

2018-08-13 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14793 To: volkov, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14549: EDID parsing: replace non-printable characters with '-'

2018-08-13 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R110:13bc5bcd4bf4: EDID parsing: replace non-printable characters with '-' (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14549?vs=38934&id=39612#toc REPOSITORY R110 KScre

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-08-13 Thread Gun Park
gpark created this revision. gpark added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gpark requested review of this revision. REVISION SUMMARY finish Hardware section stash unset CMAKE_INSTALL_PREFIX fi

D14794: Port away from KLocale and KDELibs4Support

2018-08-13 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14794

D14793: Update connection details only when necessary

2018-08-13 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY They are needed only when the Details tab is visible. In other cases, their update is just eating CP

D14697: X11: set GDK_SCALE (try 2)

2018-08-13 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Please hang on, we need to more thorougly test this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraha

D14786: Fix archive name in README.md

2018-08-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R872:8022c10a8c4e: Fix archive name in README.md (authored by broulik). REPOSITORY R872 Flatpak Support: Testing Application for Portals CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14786?vs=

D14697: X11: set GDK_SCALE (try 2)

2018-08-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision is now accepted and ready to land. Tested this out and it works flawlessly for Firefox, Lollypop, and GIMP (to the extent that GIMP does support HiDPI) with the integer scale factor use c

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-13 Thread Ovidiu Chi
https://bugs.kde.org/show_bug.cgi?id=375840 Ovidiu Chi changed: What|Removed |Added CC||metalkt...@gmail.com --- Comment #9 from Ovidiu Ch

D14786: Fix archive name in README.md

2018-08-13 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: jgrulich. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The installed flatpak archive built installs as `org.kde.portal-

D14243: Fix bad model hygiene in Positioner::move()

2018-08-13 Thread Nathaniel Graham
ngraham added a comment. In D14243#306922 , @broulik wrote: > This actually seems to break re-arranging files, at least on Qt 5.11.1: > F6188387: Screenshot_20180812_103125.png > Reverting this patch m

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

2018-08-13 Thread Nathaniel Graham
ngraham added a comment. I'm doing all my testing in a KDE Neon VM, FWIW. Would you be able to set that one up and try it there to see if you can reproduce it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ng