D14546: [Service Runner] Look up relative entryPaths

broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in servicerunner.cpp:474 > Does it better to check that file exists? `QStandardPaths::locate` already does that: > The full path to the first file […] found is returned. If no such file […] > can be found, an empty string is

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff planned changes to this revision. progwolff added a comment. In D12925#302675 , @ngraham wrote: > With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching

D14574: Fwupd-Backend Fix CI Warning Missing End-if for testing and review

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:33 > pkg_check_modules(FLATPAK flatpak>=0.6.12) > -find_package(LIBFWUPD 1.0.7) > +find_package(LIBFWUPD 1.0.3) > Can we reduce the minimum version to 0.8.3--assuming that version has what we need? This would let us build the f

D14574: Fwupd-Backend Fix CI Warning Missing End-if for testing and review

abhijeet2096 created this revision. abhijeet2096 added reviewers: apol, davidedmundson. abhijeet2096 added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. abhijeet2096 requested review of this revision. RE

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching the hinting style to Full, but then after switching back to something else and then back to Full again, it no longer worked and I

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 86 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/86/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 Aug 2018 02:45:57 + Build duration: 2 min 45 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.10 - Build # 93 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.10/93/ Project: Plasma discover kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 03 Aug 2018 02:45:57 + Build duration: 46 sec and counting CONSOLE OUTPUT [...tru

D14566: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a55b13c3f3a5: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake (authored by abhijeet2096). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.or

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/85/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 Aug 2018 02:25:07 + Build duration: 3 min 33 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.10 - Build # 92 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.10/92/ Project: Plasma discover kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 03 Aug 2018 02:25:07 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT [.

D13988: Use subseq matching for service runner

michaeleden added a comment. @broulik thanks, will do! REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham Cc: cfeck, ngraham, plasma-devel, ragreen, Pit

D14546: [Service Runner] Look up relative entryPaths

anthonyfieroni added inline comments. INLINE COMMENTS > servicerunner.cpp:474 > + > +if (path.isEmpty()) { > +return nullptr; Does it better to check that file exists? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14546 To: broulik, #plasma, hei

D13988: Use subseq matching for service runner

broulik added a comment. Please only change dependency to a released version otherwise this will break the build for everyone. Feel free to bump to 5.49 once it's released (next week?) REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kd

D14566: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake

abhijeet2096 created this revision. abhijeet2096 added reviewers: apol, davidedmundson. abhijeet2096 added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. abhijeet2096 requested review of this revision. RE

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/35/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 Aug 2018 20:03:43 + Build duration: 6 min 10 sec and counting JU

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/22/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 Aug 2018 20:04:27 + Build duration: 2 min 19 sec and counting JUnit Test

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/13/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 02 Aug 2018 20:04:55 + Build duration: 1 min 49 sec and counting

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/15/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 Aug 2018 20:04:39 + Build duration: 1 min 47 sec and counting JUn

D13988: Use subseq matching for service runner

michaeleden added a comment. @ngraham cool! So I should change the deps for KF 5.50 unless someone else disagrees? REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, br

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 84 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/84/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 Aug 2018 19:31:03 + Build duration: 3 min 59 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.10 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.10/91/ Project: Plasma discover kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 02 Aug 2018 19:23:25 + Build duration: 37 sec and counting CONSOLE OUTPUT [...tru

D14050: Fwupd-Backend Integration

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a30850900bbf: Fwupd-Backend Integration (authored by abhijeet2096). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14050?vs=38971&id=38973 REVISION

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38971. abhijeet2096 edited the summary of this revision. abhijeet2096 added a comment. Modified the Patch for latest Master branch Integration REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14050?vs

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38969. progwolff added a comment. - fix writing config temporarily (previews) with missing local config entries REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38829&id=38969 BRANCH arcpatch-D12925

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. @broulik what to do from here? I do not have commit access. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen, davidedmundson Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38966. abhijeet2096 added a comment. - Removed Make Default action from the sources backend actions list - Removed m_actions vector - Renamed the iterateTransaction to updateProgress in transaction Class - Now Using Proper connect Syntax - Fixe

D14562: Introduce Theme.smallestFont

volkov created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It can be useful in itself and when porting code from Plasma. REPOSITORY R169 Kirigami BRANCH

D14546: [Service Runner] Look up relative entryPaths

hein added a comment. I agree a more general fix would be nice, but at least Kicker has a whole bunch of downstreams itself ... I'd probably accept this, but I'd like to hear David's take. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14546 To: broulik,

D14548: testedid: make sure to use uint consistently

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c9955376ed2d: testedid: make sure to use uint consistently (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14548?vs=38933&id=38960 R

D14557: Use a consistent visual style on the Settings page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:85f6a6a0476a: Use a consistent visual style on the Settings page (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14557?vs=3895

D14557: Use a consistent visual style on the Settings page

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes the Settings page visually

D14556: Use 1 instead of true for gtk-shell-shows-menubar

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2829367e2fba: Use 1 instead of true for gtk-shell-shows-menubar (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14556?vs=38951&id=389

D14556: Use 1 instead of true for gtk-shell-shows-menubar

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 397087 REPOSITORY R120 Plasma Workspace RE

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a comment. Bug explained with a fix here D14505 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: davidedmundson, graesslin, sebas, #kwin, dvratil Cc: romangg, kde-frameworks-devel, davidedmundson, p

D14545: Support both QString and QIcon for dragHelper pixmap

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Meh, then go for it. Remove the unneeded exports? (In a separate patch, if you want) REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14545 To: broulik, #plasma, apol C

D14545: Support both QString and QIcon for dragHelper pixmap

broulik added inline comments. INLINE COMMENTS > apol wrote in draghelper.h:46 > This is an exported method, is this not a public library? :/ Milou is released as part of plasma and this class is only for QML use, don't recall why it's exported anymore but there's also no header installed for i

Re: Akademy BOF Topics

** there will be a lot more wayland things from other people Semi-releated: I have a session on Wednesday to set up wayland with app developers and do any wayland specific bug fixes with them.

D14545: Support both QString and QIcon for dragHelper pixmap

apol added inline comments. INLINE COMMENTS > draghelper.h:46 > Q_INVOKABLE bool isDrag(int oldX, int oldY, int newX, int newY) > const; > -Q_INVOKABLE void startDrag(QQuickItem* item, QMimeData *mimeData, > const QIcon &icon = QIcon()); > +Q_INVOKABLE void startDrag(QQ

D14542: WIP: Basic KCM using new virtual desktops DBus interface

mart added inline comments. INLINE COMMENTS > desktopsmodel.cpp:78 > +QStringLiteral("/VirtualDesktopManager"), > +QStringLiteral("org.kde.KWin.VirtualDesktopManager"), > +QStringLiteral("desktopDataChanged"), all of this, static values > desktopsmodel.cpp:106 > +

D14542: WIP: Basic KCM using new virtual desktops DBus interface

broulik added a comment. That DBus stuff looks like it was painful to write :/ It seems the KCM does auto-apply of everything (desktop names, adding, removing them) which is not what we usually do, and neither did the old KCM INLINE COMMENTS > desktopsmodel.cpp:92 > +QStringLite

Re: Akademy BOF Topics

On mercoledì 1 agosto 2018 17:01:28 CEST David Edmundson wrote: > We currently have a bunch of slots booked as general "Plasma". > We should split them up into relevant topics people actually want to > discuss so people know when to turn up to what. > > Either post here or update the wiki directly

D14549: EDID parsing: replace non-printable characters with '-'

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Simplify first to not have zero terminators suddenly replaced b

D14548: testedid: make sure to use uint consistently

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY It seems like compilation was broken with some configurations,

D14546: [Service Runner] Look up relative entryPaths

broulik created this revision. broulik added reviewers: Plasma, hein, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For KCMs we get a relative `entryPath()` for our `KSe

D14545: Support both QString and QIcon for dragHelper pixmap

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The model was changed a while ago to return a QString if possible