D14437: Fix QFileDialog not remembering the last visited directory.

anthonyfieroni added inline comments. INLINE COMMENTS > apol wrote in kdeplatformfiledialoghelper.cpp:118 > I'm not sure I understand the comment. Is it like a TODO? It works without comment, i think these connections are not needed. REPOSITORY R135 Integration for Qt applications in Plasma

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

anthonyfieroni added a comment. +1 from me. REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14474: Stop enforcing spacings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yes yes yes yes! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D14474 To: apol, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenB

D14437: Fix QFileDialog not remembering the last visited directory.

apol added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:118 > +connect(m_fileWidget->dirOperator(), &KDirOperator::urlEntered, this, > &KDEPlatformFileDialogBase::directoryEntered); > +// ## no connect to fileSelected, filesSelected, fileHighlighted, > currentChang

D14050: Fwupd Backend For Review and Improvement

apol added a comment. Please, do some review yourself, you should be able to see most of these things yourself INLINE COMMENTS > FwupdSourcesBackend.cpp:151 > +{ > +return m_actions ; > +} `return {}` and remove the unused attribute. > FwupdSourcesBackend.h:46 > +bool supportsAddi

D14474: Stop enforcing spacings

apol added a comment. F6161719: Screenshot_20180730_014620.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14474 To: apol, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D14474: Stop enforcing spacings

apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Kirigami isn't designed to have this spacing between elements and it keeps

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson updated this revision to Diff 38734. davidedmundson added a comment. exciting whitespace change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=38733&id=38734 BRANCH output_changes REVISION DETAIL https://phabricator.kde.org/D1

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson updated this revision to Diff 38733. davidedmundson added a comment. Instead of modifying the geometry event use two new events to remain fully compatiable. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25806&id=38733 BRANCH o

D14436: SwitchDesktop mousewheel options with config dialog added

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Showing a disabled checkbox for rollover doesn't make much sense. IMHO we should either have it as a separate option from kwin and have a checkbox, or not have a

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

tundracomp added a comment. That would be „Alexander Schlarb “. Thanks! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba