D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38290. hein added a comment. Fix one whitespace for making of glorious patch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38287&id=38290 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein requested review of this revision. hein added a comment. One more time Kai, sorry :P REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14285 To: hein, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38287. hein added a comment. Fix coding style. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38252&id=38287 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14285 AFFECTED FILES applets/

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Scott Harvey
sharvey added a comment. As soon as D12311: Align lock icon with bold message text; reduce overall size of dialog is landed, I'll change this string. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To:

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Stefan Brüns
bruns added a comment. In D12498#296546 , @ngraham wrote: > Darn, that's a shame. "Not Provided" it is, then. @bruns, are you okay with this? Either > 'Description' not provided, please file a bug report or > 'Description'

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. Darn, that's a shame. "Not Provided" it is, then. @bruns, are you okay with this? REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey, bruns, ngraham, davidedmundson Cc: davidedmundson, bruns, ngraham, plas

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. ``Check out https://community.kde.org/Get_Involved/development#Get_the_code :)`` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: abetts, Zren, plasma-devel, ragreen, Pi

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. In D14105#296525 , @ngraham wrote: > It's the `edit-clear-history` icon in the `breeze-icons` repo. Can you help me find that repo please? I have no clue how to get there. REPOSITORY R120 Plasma Workspace REVISI

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. It's the `edit-clear-history` icon in the `breeze-icons` repo. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, leslie

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. Can you share the svg file for this icon please? I would like to edit it a little bit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: abetts, Zren, plasma-devel, ragreen,

D14307: Changed refresh time from 30 to 60 seconds

2018-07-23 Thread Piotr Kąkol
piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14307 AFFECTED FILES applets/binary-clock/package/contents/ui/main.qml

D14306: Changed refresh time from 30 to 60 seconds

2018-07-23 Thread Piotr Kąkol
piotrkakol created this revision. piotrkakol added a reviewer: ngraham. piotrkakol added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH change-refresh-time (branched from master) REVISION DETAIL https://phabricator.kde.org/D14306 AFFE

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Stefan Brüns
bruns added a comment. In D12498#296414 , @ngraham wrote: > ... but I'd still prefer something a little bit more descriptive like "Not provided by " The problem is you can not really know the application. While often the Action-ID is de

D12855: Move Widget search field to its own row so it doesn't get compressed

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. @davidedmundson does this look okay now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, s

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. "Not Provided" makes it clear that //someone// didn't provide the information, but who? If we can't agree on anything else, I'll agree to compromise on "Not Provided", but I'd still prefer something a little bit more descriptive like "Not provided by " I mean,

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Scott Harvey
sharvey added a comment. I'm still in favor of the brief but descriptive "Not Provided". This is an advanced developer field. I could add a tooltip with some additional information. My point is to convey the fact that "the vendor is supposed to provide this information, but did not." To

D14303: [SubCategoryPage] Use binding for back button color

2018-07-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of doing it programmatically which breaks bi

D14299: kirigami_package_breeze_icons: don't treat lists as elements

2018-07-23 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:a492ecde6467: kirigami_package_breeze_icons: don't treat lists as elements (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14299?vs=38257&id=382

D14238: Polish Notifier Plasmoid's UI

2018-07-23 Thread Aleix Pol Gonzalez
apol added a comment. In D14238#295991 , @fabianr wrote: > In D14238#295426 , @apol wrote: > > > In D14238#295251 , @fabianr wrote: > > > > > Maybe add

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Go for it then! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Scott Harvey
sharvey added a comment. I believe it's done. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, broulik,

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. Can we commit this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, broulik,

D12498: Fully remove `Application Name` from Details panel

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. I'm not comfortable with the string "Missing". It's a developer-centric string that's not user-friendly, and it doesn't help the user figure out what's wrong or whose fault it might be. We'd get bug reports over this; people would say, "If it's missing, KDE should pr

D14299: kirigami_package_breeze_icons: don't treat lists as elements

2018-07-23 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 38257. apol added a comment. Include a warning REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14299?vs=38256&id=38257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14299 AFFECTED FILES KF5Kirigami2Ma

D14299: kirigami_package_breeze_icons: don't treat lists as elements

2018-07-23 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: mart, vkrause, andreaska. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY GLOB_RECURSE will give us a list, treat it as such. Al

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Perfect, thanks. You're missing `return` before the `Math.min` ... REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D14285 To: hein, b

D14226: Let download update timer only run when there's running downloads

2018-07-23 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:c8b49b565796: Let download update timer only run when there's running downloads (authored by broulik). REPOSITORY R8

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38252. hein added a comment. This revision is now accepted and ready to land. Only apply size hint in the perpendicular dimension REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38241&id=38252 BRANCH mast

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein planned changes to this revision. hein added a comment. After more discussion with Kai this is still not fully what we want. I'll make it better later. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14285 To: hein, broulik Cc: plasma-devel, ragreen, Pit

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2018-07-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=354250 Nate Graham changed: What|Removed |Added CC||n...@kde.org Resolution|---

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2018-07-23 Thread Alexander Mentyu
https://bugs.kde.org/show_bug.cgi?id=354250 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #37 from Alex

D14156: Show "muted" icon for dummy output

2018-07-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R115:ae9fb0a57cef: Show "muted" icon for dummy output (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14156?vs=37863&id=38248 R

D14185: Disable script execution over DBus when scripting console is disabled

2018-07-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5c4a0acba409: Disable script execution over DBus when scripting console is disabled (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38241. hein added a comment. Clean up diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38240&id=38241 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14285 AFFECTED FILES applets/kick

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38240. hein added a comment. One more try REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38236&id=38240 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14285 AFFECTED FILES applets/kicko

Minutes monday meeting week 29

2018-07-23 Thread Marco Martin
Meeting for 23/7/2018 Eike: * I reworked my trio of wayland/virtual desktop patches, the DND stuff (pager to pager, tm to pager) is now on par with X11, sans moving window position within the screen since there's no protocol for it * I fixed some model bugs in Folder View that hit a new assert i

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein updated this revision to Diff 38236. hein added a comment. Revamp, fix issues pointed out by Kai. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38221&id=38236 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14285 AFFE

D14287: [Notifications Engine] Never group notifications with URLs

2018-07-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c221f6315808: [Notifications Engine] Never group notifications with URLs (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14287?vs=382

D14287: [Notifications Engine] Never group notifications with URLs

2018-07-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't merge URLs and it probably doesn't make se

D14285: Fix Kickoff compact repr size hints in panel

2018-07-23 Thread Eike Hein
hein created this revision. hein added a reviewer: broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The old code was copy-pasted from Kicker but the wrong code block; it was the code path for custom button image mode, not the reg