D14268: Changed refresh time from 30 to 60 seconds

piotrkakol added a comment. Thanks, David. Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it should

D14268: Changed refresh time from 30 to 60 seconds

davidedmundson added a comment. also try to commit just the change you're making not all of the other changes in the other commit INLINE COMMENTS > main.qml:51 > engine: "time" > connectedSources: ["Local"] > +interval: showSeconds ? 1000 : 6 please add inte

D14268: Changed refresh time from 30 to 60 seconds

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH change-refresh-time (branched from master) REVISION DETAIL https://phabricator.kde.org/D14268 AFFECTED FILES applets/binar

D14267: Cleaned code for binary clock applet and added comments

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH code-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D14267 AFFECTED FILES applets/binary-clock

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

graesslin added a comment. What's really strange is that requestShowTooltip comes from the event loop. But nothing in kdecoration or in KWin goes through a queued event to KWin::Decoration::DecoratedClientImpl::requestShowToolTip. Could it be a decoration plugin causing this? REPOSITORY

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

graesslin added a comment. The hovered state cannot change if there is no decoration. Hover is from an event handler from Decoration. I doubt that this change here can fix the crash. Also that's the explanation for the update slot not checking: no hover change if there's no decoration.

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

davidedmundson planned changes to this revision. davidedmundson added a comment. Not a stupid question. Will check REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D14264 To: davidedmundson, #kwin Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 marked 7 inline comments as done. abhijeet2096 added inline comments. INLINE COMMENTS > apol wrote in FwupdBackend.cpp:395 > Are you sure you need an event-loop there? Let's make this non-blocking. Can you please guide me, on how can I make this non-blocking? REPOSITORY R134 Disc

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38183. abhijeet2096 added a comment. - Removed the derived FwupdUpdater - Using Standard Backend Updater - Now using the standard to name functions - Added Status on transactions [Not Tested] - Now Apps Cannot be executed/ Launched [Not tested]

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

zzag added a comment. Probably stupid question, I'm just curious.. Why had only one receiver been changed to `decoration.data()`? Why that's not the case for connect(this, &DecorationButton::hoveredChanged, this, updateSlot); ? Just for reference void DecorationButton::

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Decoration is destroyed at some point before De