D14238: Polish Notifier Plasmoid's UI

broulik added a comment. +1 for the looks INLINE COMMENTS > Full.qml:27 > +Item { > +anchors.fill: parent > + We typically do that where the component is used, not in its definition > Full.qml:30 > PlasmaExtras.Heading { > -Layout.fillWidth: true > +anchors.left: pa

[kscreenlocker] [Bug 374300] All UI elements should respect active color theme

https://bugs.kde.org/show_bug.cgi?id=374300 --- Comment #6 from Rog131 --- (In reply to Nate Graham from comment #5) > Certain elements on the lock screen respect the active color theme--such as > the Unlock button and the textfield. I think it would make the most sense to > continue in this vein

D14238: Polish Notifier Plasmoid's UI

abetts added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238 To: ngraham, apol, #discover_software_store, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14238: Polish Notifier Plasmoid's UI

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements the following cha

[kscreenlocker] [Bug 374300] All UI elements should respect active color theme

https://bugs.kde.org/show_bug.cgi?id=374300 Nate Graham changed: What|Removed |Added Summary|Option to change the font |All UI elements should |color o

D14234: [Folder View] Improve file name text rendering

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks better with fractional scaling and doesn't regress at all for 1x scaling. Drop shadows are still rendered. Code looks good. REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D14224: Make kcm size hint bigger

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This doesn't seem to have the desired effect. Here's how it looks for me without the patch: F6120769: Master.png And with it: F612

D14234: [Folder View] Improve file name text rendering

Zren added a comment. I tested the `x: -main.x % 1` code. Before: F6120560: 2018-07-19___13-46-20.png After: F6120562: 2018-07-19___13-47-29.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https

Re: Baloo and remote file systems

Hi David, thank for your answer. On Donnerstag, 19. Juli 2018 10:35:52 CEST David Kahles wrote: > Hi Rainer, > > > I assume it relies on inotify or something similar to > > avoid periodic full scans. > > I don't know enough about Baloo to answer your questions, but Baloo relies > not only on in

D14234: [Folder View] Improve file name text rendering

broulik updated this revision to Diff 38097. broulik added a comment. - Don't even bother creating the `DropShadow` if not supported REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14234?vs=38096&id=38097 REVISION DETAIL https://phabricator.kde.org

D14234: [Folder View] Improve file name text rendering

broulik created this revision. broulik added reviewers: Plasma, hein, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `GridView` pads out its delegate to

D14145: Show a vertical menu for the panel widget options pop-up

ngraham added inline comments. INLINE COMMENTS > broulik wrote in ConfigOverlay.qml:372 > Can be removed once you addressed the `width` above This is still needed because it's referred to on line 354 (`label.text = currentApplet.applet.title;`) > broulik wrote in ConfigOverlay.qml:375 > This d

D14145: Show a vertical menu for the panel widget options pop-up

ngraham updated this revision to Diff 38095. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments and adjust side padding REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14145?vs=37919&id=38095 BRANCH more-user

D14229: Make OSD buttons' accessible

davidedmundson added a comment. This is a duplicate? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14229 To: gladhorn, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14229: Make OSD buttons' accessible

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH arcpatch-D14165 REVISION DETAIL https://pha

D14228: Make OSD buttons' accessible

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH arcpatch-D14165 REVISION DETAIL https://phabricator.kde.org/D14228 AFFECTED F

D14227: Use AbstractDBusRunner instead of custom export + plugin

davidedmundson updated this revision to Diff 38074. davidedmundson added a comment. Rebase. Hopefully arc will show something correct now REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14227?vs=38070&id=38074 BRANCH runner_without_mute

D14165: Handle keyboard in action selector OSD

gladhorn updated this revision to Diff 38073. gladhorn added a comment. Fix accepting of left key event and use Row instead of ButtonRow REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14165?vs=38003&id=38073 BRANCH arcpatch-D14165 REVISION DETAIL http

D14165: Handle keyboard in action selector OSD

gladhorn marked an inline comment as done. gladhorn added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:107 > Given we're doing this manually, we should drop the ButtonRow which is also > meddling with what's checked or not. > > Row should be a drop in replacement.

D14227: Use AbstractDBusRunner instead of custom export + plugin

zzag added inline comments. INLINE COMMENTS > tabsrunnerplugin.h:38-39 > public: > explicit TabsRunnerPlugin(QObject *parent); > +TabsRunnerPlugin(QObject *parent); > +~TabsRunnerPlugin(); Does it compile? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://pha

D14145: Show a vertical menu for the panel widget options pop-up

broulik added a comment. Minor nitpicks but otherwise looking good INLINE COMMENTS > ConfigOverlay.qml:360 > enabled: currentApplet > -width: handleRow.childrenRect.width + (2 * handleRow.spacing) > -height: Math.max(configureButton.height, label.contentHe

Re: Baloo and remote file systems

Hi Rainer, > I assume it relies on inotify or something similar to > avoid periodic full scans. I don't know enough about Baloo to answer your questions, but Baloo relies not only on inotify, but additionally on LMDB (lightning memory-mapped database). > Can anybody tell if it is possible to run

D14227: Use AbstractDBusRunner instead of custom export + plugin

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Contains everything as before in half the cod

D14226: Let download update timer only run when there's running downloads

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Currently we have a 1000ms timer running que

D14225: Use hideOsd function instead of its code copied

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The function does exactly the same as these two lines. REPOSITORY R104 KScreen BRANCH master

D14223: Fix duplicate object name in ui file

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0597035f8611: Fix duplicate object name in ui file (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14223?vs=38062&id=38065 REVISION DETAIL

D14224: Make kcm size hint bigger

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This makes the kcm look less cramped when running kcm_shell. REPOSITORY R104 KScreen BRANCH

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. There is now new release of PipeWire (version 0.2.0), which breaks API a bit. I would suggest to bump PipeWire requirements to 0.2.0 and change your code. There is also now a version file included so in future we can use this to check PW version during build time an

D14213: Simplify if/else that all make the same call

This revision was automatically updated to reflect the committed changes. Closed by commit R104:64e03b1e7b2b: Simplify if/else that all make the same call (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14213?vs=38030&id=38063 REVISION

D14223: Fix duplicate object name in ui file

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This has no practical implications, but generates a warning (fr