D13931: [KCM] Add speaker placement test

2018-07-07 Thread David Rosca
drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Advanced.qml:112 > + > +delegate: > + So this will show this grid as many times as you have sinks below each other and scrollable in ListView wit

D13937: Update formulas and add option to change grid thickness

2018-07-07 Thread Piotr Kąkol
piotrkakol added a comment. I don't have KDE developer account so I cannot push this patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13937 To: piotrkakol Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D13937: Update formulas and add option to change grid thickness

2018-07-07 Thread Piotr Kąkol
piotrkakol added a comment. F6044411: squares fix.png On the left there's the old applet and on the right mine after only changing dotSize (now squareSize) from real to int. All squares, not rectangles. F6044428: config.png

D13937: Update formulas and add option to change grid thickness

2018-07-07 Thread Piotr Kąkol
piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REVISION SUMMARY Cleaned code for binary clock applet and added comments. Changed refresh time from 30 to 60 seconds. Changed variable type to int to display

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Tagore Chandan Reddy
tagorechandanreddy updated this revision to Diff 37297. tagorechandanreddy added a comment. Fixed siodprovider.json file. It should work now. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13930?vs=37288&id=37297 REVISION DETAIL https://phabricator

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. No name shows up in the list: F6043949: Screenshot_20180707_173801.png Also, using it doesn't seem to actually work; the wallpape

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

2018-07-07 Thread Nathaniel Graham
ngraham added a comment. Nice, works for me! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13868 To: tagorechandanreddy, #plasma, kossebau Cc: ngraham, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D13935: Remove audio setup from Phonon KCM

2018-07-07 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, sitter, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Once D13931

D13932: Show icons for actions that have an icon source rather than an icon name

2018-07-07 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13932 AFFECTED FILES s

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Tagore Chandan Reddy
tagorechandanreddy added a comment. And regarding the license of the images, Space.com acquires them from twitter and other public outlets that belong to NASA and its Astronauts. All images are taken by Space.com from public domains with credit to the original contributors. No other mention

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Tagore Chandan Reddy
tagorechandanreddy updated this revision to Diff 37288. tagorechandanreddy added a comment. Made copyright, translation changes as suggested. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13930?vs=37285&id=37288 REVISION DETAIL https://phabricator

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: jriddell. kossebau added a comment. Thanks for offering this for inclusion. No time to test myself currently. Important: can you tell what license space.com has on those images? Can they be used e.g. without a fee by 3rd-party software, like this plugin? I cou

D13931: [KCM] Add speaker placement test

2018-07-07 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application edited subscribers, added: plasma-devel; removed: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY An equivalent to the Phonon

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2018-07-07 Thread Tagore Chandan Reddy
tagorechandanreddy created this revision. tagorechandanreddy added reviewers: Plasma, kossebau. tagorechandanreddy added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tagorechandanreddy requested review of this revision. REVISION SUMMARY Added new Picture of the Day

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

2018-07-07 Thread Tagore Chandan Reddy
tagorechandanreddy updated this revision to Diff 37283. tagorechandanreddy added a comment. Further RegExp changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13868?vs=37141&id=37283 REVISION DETAIL https://phabricator.kde.org/D13868 AFFECTED F

D13927: autotests: Compare doubles to doubles

2018-07-07 Thread David Edmundson
davidedmundson added a comment. My fault :/ Thanks for taking care of that. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D13927 To: zzag, #plasma Cc: davidedmundson, kossebau, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg