D13927: autotests: Compare doubles to doubles

zzag added a comment. > Seems Phabricator decided it's the same commit due to being an identical patch? I guess so. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D13927 To: zzag, #plasma Cc: kossebau, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13927: autotests: Compare doubles to doubles

kossebau added a comment. Pardon for having pushed a fix directly, as I was sure about this fix for the issue :) Seems Phabricator decided it's the same commit due to being an identical patch? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D13927 To: zzag,

D13927: autotests: Compare doubles to doubles

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:03aed13d9ff3: Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int (authored by kossebau). REPOSITORY

Re: libkscreen and Qt 5.9

On Friday, July 6, 2018 11:07:59 PM EEST Ben Cooksley wrote: > Hi folks, > > During a recent dependency build, the build for libkscreen failed due > to recent changes to it's tests. > > The log showing the failure message can be found at > https://build.kde.org/view/CI%20Management/job/Dependency

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein added a comment. The change would have to be in the libtm patch. But the filter model hasn't changed, all I've done in the libtm patch is that initial population loop thing in VirtualDesktopInfo. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To:

D13927: autotests: Compare doubles to doubles

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY That's not possible to compare doubles to ints with QCOMPARE in Qt 5.9. RE

libkscreen and Qt 5.9

Hi folks, During a recent dependency build, the build for libkscreen failed due to recent changes to it's tests. The log showing the failure message can be found at https://build.kde.org/view/CI%20Management/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.9/68/console If someone could

D11198: [libbreezecommon] Add box shadow helper

zzag added a comment. If there are serious problems, we still can revert it. Also, there is a chance that we need to notify sysadmins about new dependency. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, brou

D11198: [libbreezecommon] Add box shadow helper

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:bffe8faa8706: [libbreezecommon] Add box shadow helper (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST U

D11175: [kstyle] Refine shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a15e8ed40e1: [kstyle] Refine shadows (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=35491&id=37268 REVISION DETAIL https://phabricator.

D11069: [kdecoration] Refine shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R31:54b75015eda8: [kdecoration] Refine shadows (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=35489&id=37267 REVISION DETAIL https://phabri

D11198: [libbreezecommon] Add box shadow helper

zzag added a comment. Landing it... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13920: [Font Management KCM] Only show on xcb platform

broulik added a comment. Added a comment to T7282 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13920 To: broulik, #plasma, fvogt Cc: davidedmundson, alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D13923: [User Switcher] Swap Cancel and Switch buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eaa093443a7c: [User Switcher] Swap Cancel and Switch buttons (authored by aleksejshilin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13923?vs=37251&id=37253#toc REPOSITORY R120 Plasma Wo

D13850: Remove pointless setMin/setMax size on DesktopView

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c96a9f5afec3: Remove pointless setMin/setMax size on DesktopView (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13850?vs=3706

D13923: [User Switcher] Swap Cancel and Switch buttons

aleksejshilin created this revision. aleksejshilin added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Cancel is typically the rightmost button. REPO

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

mart added a comment. with latest version (don't know if depends from this or libtaskmanager) i get desktops only on a single pager cell REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D13920: [Font Management KCM] Only show on xcb platform

davidedmundson added a comment. Please open a bug report that this is missing and should be ported. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13920 To: broulik, #plasma, fvogt Cc: davidedmundson, alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D13907: [SDDM Theme] Set sourceSize on background image

davidedmundson added a comment. > Actually increases ram usage of sddm-greeter by 10 MiB here. I thought it would never load the image larger than it is? :/ It won't. Maybe you're testing wrong. INLINE COMMENTS > Background.qml:37-38 > id: sceneImageBackground > -anchor

D13919: [Fonts KCM] Generate font rendering previews only on X

broulik added a comment. Yes, it says in the commit message REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13919 To: broulik, #plasma, fvogt Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D13919: [Fonts KCM] Generate font rendering previews only on X

alexeymin added a comment. This is probably for BUG: 396214 ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13919 To: broulik, #plasma, fvogt Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13920: [Font Management KCM] Only show on xcb platform

alexeymin added a comment. BUG: 396214 or better BUG: 364746 ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13920 To: broulik, #plasma, fvogt Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13920: [Font Management KCM] Only show on xcb platform

broulik created this revision. broulik added reviewers: Plasma, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This entire thing is built on X technology and just crashes

D13919: [Fonts KCM] Generate font rendering previews only on X

broulik created this revision. broulik added reviewers: Plasma, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It uses Xft unconditionally and crashes the entire module wh

D13911: Sync MAX_UID with upstream

arojas created this revision. arojas added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Dynamic users are getting more widely used in latest versions