D13481: Recommend window border size "None"

graesslin added a comment. Nate, I cannot believe what I read here. Every week you do a blog post about usability. In other reviews you draw the usability card so often that it annoys me. And here you want to break user setups and break with "form follows function". This is absolutely unbeli

D13481: Recommend window border size "None"

hein added a comment. Here's a realistic scenario for the "Dead Zone Problem": I had quick-tiled two windows next to each other on the desktop. In the left-hand window, I had a scrollable list. The right-hand window was a text editor. I was going through the list on the left, and turning

D9638: [effects] replace old slide effect with a new one

vermeeren added a comment. In D9638#282890 , @zzag wrote: > In D9638#282881 , @vermeeren wrote: > > > I just upgraded my system and got the update with this new change. Is it possible to add an option

D9638: [effects] replace old slide effect with a new one

zzag added a comment. In D9638#282881 , @vermeeren wrote: > I just upgraded my system and got the update with this new change. Is it possible to add an option `Slide wallpaper` similar to the current option `Slide docks`? > On my 31" display a

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#282884 , @hein wrote: > Can you have a look at the code in `kdeclarative`, specifically `src/qmlcontrols/kcoreaddons/kuserproxy.cpp` - that's where the KDirWatch monitoring the `face.icon` file is. I think you

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

hein added a comment. Can you have a look at the code in `kdeclarative`, specifically `src/qmlcontrols/kcoreaddons/kuserproxy.cpp` - that's where the KDirWatch monitoring the `face.icon` file is. I think you need to place some `qDebug()` there to see if the file change gets picked up on your

D9638: [effects] replace old slide effect with a new one

vermeeren added a comment. Restricted Application edited projects, added KWin; removed Plasma. Hello, I just upgraded my system and got the update with this new change. Is it possible to add an option `Slide wallpaper` similar to the current option `Slide docks`? On my 31" display at h

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#282860 , @hein wrote: > Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ `touch`. A few days ago, you suggested > You can run `touch $H

D13672: Mouse KCM Pointer Speed Slider Improvement

ngraham added a comment. In D13672#282856 , @furkantokac wrote: > In D13672#281774 , @ngraham wrote: > > > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old dumb text. :)

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

hein added a comment. Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ `touch`. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415 To: sharvey, ngraham, davidedmundson, mart, apol, abetts Cc: h

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Trying to use `touch` made no difference. I called it manually between changes, and actually added it (temporarily) to the actual Kickoff code, so it "touched" every time Kickoff was opened. No change. Anybody have another guess? REPOSITORY R119 Plasma Desktop

D13672: Mouse KCM Pointer Speed Slider Improvement

furkantokac added a comment. In D13672#281774 , @ngraham wrote: > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old dumb text. :) This patch actually solves the problem specified on bug title, "libinput pointer k

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 106 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/106/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Jun 2018 18:30:26 + Build duration: 2 min 27 sec and counting CONSOLE OUTPUT

D13573: Touchpad KCM QtQuickControls2 Conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6a4b5870fb2f: Touchpad KCM QtQuickControls2 Conversion (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13573?vs=36648&id=36649 REV

D13573: Touchpad KCM QtQuickControls2 Conversion

ngraham accepted this revision. ngraham added a comment. Ship it! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13573 To: furkantokac, romangg, ngraham, #plasma, mart Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac updated this revision to Diff 36648. furkantokac added a comment. Typo fix. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13573?vs=36308&id=36648 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13573 AFFECTED FILES kc

D13696: Handle enabled property of simple models

cordlandwehr closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13696 To: cordlandwehr, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D13481: Recommend window border size "None"

ngraham added a comment. In D13481#282788 , @graesslin wrote: > I think we should go back to the drawing board and think about what really is wanted and needed. I want to remind that the original idea was to still have round corners. As I said

D13481: Recommend window border size "None"

abetts added a comment. In D13481#282788 , @graesslin wrote: > In D13481#282653 , @mart wrote: > > > In D13481#280767 , @romangg wrote: > > > > > What

D13481: Recommend window border size "None"

graesslin added a comment. In D13481#282653 , @mart wrote: > In D13481#280767 , @romangg wrote: > > > What I thought of as a solution back when it happened was to check if it's a single click on the

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#282731 , @ngraham wrote: > Thanks, that fixes things in Discover in conjunction with D13663 . There's only one remaining small visual issue: the whitespace to the left of the na

D13663: Refactor the Global ToolBar concept

ngraham added a comment. Thanks, that fixes things in Discover in conjunction with D13663 . There's only one remaining small visual issue: the whitespace to the left of the navigation is now too small, as seen in this screenshot: F5956012: Not enough

D13679: Fix recent toolbar layout regression

mart added a comment. last version of D13663 should fix that bug REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To: ngraham, #discover_software_store Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D13663: Refactor the Global ToolBar concept

mart updated this revision to Diff 36635. mart added a comment. - remove dead code - check for handle visibility REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36502&id=36635 BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator.kde.o

D13717: Implement Seek() and Seeked()

nicolasfella added a comment. +1, setting the position for e.g. Youtube now works from KDE Connect REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13717 To: mokhtari, broulik Cc: nicolasfella, plasma-devel, #kde_connect, jdvr, yannux, Danial0_0, jo

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

mart added a comment. some jargon words become so common they are the most obvious one.. I don't have the pulse on where anti alias stands, so REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13593 To: ngraham, #plasma, #vdg Cc: mart, davidedmundson, Fuchs,

D13663: Refactor the Global ToolBar concept

mart added inline comments. INLINE COMMENTS > apol wrote in DesktopExampleApp.qml:29 > Why is this commented? old leftover, completely removing it now REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13663 To: mart, #kirigami Cc: apol, IlyaBizyaev, ngraham, davidedmun

D13717: Implement Seek() and Seeked()

mokhtari created this revision. mokhtari added a reviewer: KDE Connect. mokhtari added a project: KDE Connect. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mokhtari requested review of this revision. REVISION SUMMARY Implementing Seek()

D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I don't think QtQML supports ECMScript 6 const It does. REPOSITORY R120 Plasma Workspace BRANCH feature/krunner-scroll-jk REVISION DETAIL https://phabricator.k

D13625: Add 'Documentation' category to the Application menus

mart added a comment. anyways, the patch is fine for me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13625 To: yurchor, #plasma_workspaces Cc: hein, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D13679: Fix recent toolbar layout regression

mart added a comment. oh, yes, i know why the extra space problem, i'll fix INLINE COMMENTS > mart wrote in DiscoverWindow.qml:30 > why the logic of all of this? no applicationheader should be there at any point, in any formfactor, unless you want something to go on top of the toolbar REPO

D13679: Fix recent toolbar layout regression

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:30 > > ConditionalObject { > id: whichToolbar why the logic of all of this? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To: ngraham, #discover_software_store Cc:

D13481: Recommend window border size "None"

mart added a comment. In D13481#280767 , @romangg wrote: > What I thought of as a solution back when it happened was to check if it's a single click on the dead zone without mouse movement, then activate the window below. Since if you want to us