D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

michaeleden created this revision. michaeleden added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaeleden requested review of this revision. REVISION SUMMARY This change allows users to scroll through krunner ou

D13602: Fix tooltip woes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1e218b405bee: Fix tooltip woes (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13602?vs=36405&id=36537 REVISION DETAIL https://phabricat

D13602: Fix tooltip woes

rikmills added a comment. I have tested the modified patch on the same environment with Qt 5.10.1 where I found the crash with the previous version in 5.13.0 tars. plasmashell now seems to start without issue on login REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.10 - Build # 55 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.10/55/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Jun 2018 15:11:04 + Build duration: 1 hr 36 min and counting JUnit Tests

D13663: Refactor the Global ToolBar concept

apol added inline comments. INLINE COMMENTS > DesktopExampleApp.qml:29 > > -header: Kirigami.ToolBarApplicationHeader {} > + // header: Kirigami.ToolBarApplicationHeader {} > Why is this commented? > ExampleApp.qml:29 > > -header: Kirigami.ApplicationHeader {} > +//header: K

D13678: Overhaul presentation of link buttons in the Reviews section

This revision was automatically updated to reflect the committed changes. Closed by commit R134:5ee0a9c8c4cb: Overhaul presentation of link buttons in the Reviews section (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D136

D13679: Fix recent toolbar layout regression

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY D13663 fixed

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. In D13593#281594 , @mart wrote: > I'm ok with shortening the strings, i don't think anti alias is much more complicated than smoothing? "Anti-aliasing" is esoteric technical jargon; "Smoothing" is plain language.

D13672: Mouse KCM Pointer Speed Slider Improvement

ngraham accepted this revision. ngraham added a comment. `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old dumb text. :) Also, it seems that this is dependent on D13573 . So please also add `Depends on D13573` to the Summary sectio

D13663: Refactor the Global ToolBar concept

ngraham added a comment. Thanks, that seems to fix the bug! However, it also introduces another issue: there's now a bunch of whitespace on the left of the toolbar: F5932887: Unnecessary whitespace.png REPOSITORY R169 Kirigami REVISION DETAI

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#281744 , @ngraham wrote: > Better now, thanks! > > What exactly do we have to do in Discover to make this patch fix https://bugs.kde.org/show_bug.cgi?id=395455? remove the line header: ToolBarApplicatio

D13678: Overhaul presentation of link buttons in the Reviews section

ngraham updated this revision to Diff 36517. ngraham added a comment. Fix logic error REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13678?vs=36516&id=36517 BRANCH overhaul-review-section-prsentation (branched from master) REVISION DETAI

D13678: Overhaul presentation of link buttons in the Reviews section

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the link buttons in the Reviews section

D13663: Refactor the Global ToolBar concept

ngraham resigned from this revision. ngraham added a comment. Better now, thanks! What exactly do we have to do in Discover to make this patch fix https://bugs.kde.org/show_bug.cgi?id=395455? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13663 To: mart, #kir

D13591: Set complete vectors instead of creting them at runtime

tcanabrava updated this revision to Diff 36515. tcanabrava edited the summary of this revision. tcanabrava added a comment. - Don't realloc _pixmap vector - Don't use a Temporary to Copy data over - Fix compile - Don't use temporaries, compilers can optimize better this way REPOSITORY

D13625: Add 'Documentation' category to the Application menus

yurchor added a comment. In D13625#281596 , @mart wrote: > probably in this case the distro should put an entry in the menu offering to uninstall that package.. tough for that we have to rely on the distro Actually, the corresponding .des

D13663: Refactor the Global ToolBar concept

mart added a comment. F5932192: Spectacle.B20207.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13663 To: mart, #kirigami, ngraham Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein

D13481: Recommend window border size "None"

mart added a comment. the dead zone is actually a point.. tough that's a thing that a big company would have an actual usability testing lab for . To me is very probably something that doesn't get even noticed (i always had side borders disabled but now that i read here of the issue is the f

D13663: Refactor the Global ToolBar concept

mart updated this revision to Diff 36502. mart marked 2 inline comments as done. mart added a comment. - adress comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36472&id=36502 BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator

D13663: Refactor the Global ToolBar concept

mart added a comment. reproduced, adding here a comparison for recording prurposes before the patch: F5931512: Spectacle.W15291.png after the patch: F5931526: Spectacle.M15738.png so indeed size hints of ac

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/39/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Jun 2018 07:37:04 + Build duration: 1 hr 39 min and counting JUnit Tests Name: (roo

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#281390 , @ngraham wrote: > I don't know if it was supposed to, but FWIW this does not fix https://bugs.kde.org/show_bug.cgi?id=395455. yes, it should fix that issue REPOSITORY R169 Kirigami REVISION DET

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#281391 , @ngraham wrote: > Also, this regresses the Install button width in Discover, and other main action buttons, which you can see in your screen recording. They're now very narrow and don't have enough side p

D13664: Fix leak of pipe FDs in MD RAID code

This revision was automatically updated to reflect the committed changes. Closed by commit R106:d0287c1dea39: Fix leak of pipe FDs in MD RAID code (authored by fvogt). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13664?vs=36480&id=36497 REVISION DETAIL

D13625: Add 'Documentation' category to the Application menus

mart added a comment. probably in this case the distro should put an entry in the menu offering to uninstall that package.. tough for that we have to rely on the distro REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13625 To: yurchor, #plasma_workspaces Cc

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

mart added a comment. I'm ok with shortening the strings, i don't think anti alias is much more complicated than smoothing? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13593 To: ngraham, #plasma, #vdg Cc: mart, davidedmundson, Fuchs, abetts, nicolasfella,

D13672: Mouse KCM Pointer Speed Slider Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13672 AFFECT