Minutes monday meeting week 25

Hello, please find the notes for meeting, sorry for delay fvogt: 15:31 I can't join due to lunch, but my topics would be bug 394534 and https://phabricator.kde.org/D13535 - have fun! 15:31 KDE bug 394534 in systemsettings (kcm_mouse) "kcminit crash on startup" [crash,] https://bugs.kde.org/s

D13481: Recommend window border size "None"

januz added a comment. +1 I've been using borderless windows all the time since I came back to ~~KDE~~ Plasma and haven't had any workflow issues. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: januz, ngraham, davidedmundson, grae

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Perhaps I can go into the UserManager KCM, let it change the avatar like always, then run a brief time (250ms?), and then ‘touch’ the face file so the KDirWatch runs a second time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415

D13481: Recommend window border size "None"

ngraham added a comment. In D13481#280767 , @romangg wrote: > What I thought of as a solution back when it happened was to check if it's a single click on the dead zone without mouse movement, then activate the window below. Since if you want to

D13487: Fix build against static Qt without QLibrary

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a473e6e9ef0: Fix build against static Qt without QLibrary (authored by dvratil). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13487?vs=36028&id=36408 REVISION

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

hein added a comment. You can run `touch $HOME/.face.icon` to make the system believe the file changed, then it goes through KDirWatch etc. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415 To: sharvey, ngraham, davidedmundson, mart, apol, abetts Cc: hein

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. @hein : Thanks for the time spent investigating. The User Manager KCM appears to write out proper (non-corrupt) files, at least in my testing. I know there's a KDirWatch in one of the included Frameworks (KCoreAddons, I think), but that seems to work properly. It doe

D13637: fix icon name NumLock for Keyboard Indicator #T9050

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:05b0efa3d97c: New icons for Keyboard Indicator Closes T9050 (authored by varlesh). REPOSITORY R114 Plasma Addons CH

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

hein added a comment. I had a look at this today, and I wasn't able to reproduce the problem so far. What I've done is test by using `cp` at a terminal to copy various PNG/SVG/JPG files into the `$HOME/.face.icon` location, which is what Kickoff (via a KDirWatch in KUserProxy in kdeclara

D13602: Fix tooltip woes

hein updated this revision to Diff 36405. hein added a comment. Fix crash on Qt <5.11 This makes no sense, but fixes the crash reliably in testing. Since it works on 5.11, this may be a bug that got fixed in Qt. I didn't bisect it though. REPOSITORY R119 Plasma Desktop CHANGES SINC

D13481: Recommend window border size "None"

romangg added a comment. FWIW when I enabled borderless windows for these patches to test out the first time ever, I tried to click in the dead zone to activate the window below and then was for a moment annoyed that it didn't work. After this one "incident" I can't remember any other ti

D13637: fix icon name NumLock for Keyboard Indicator #T9050

varlesh created this revision. varlesh added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. varlesh requested review of this revision. REVISION SUMMARY "fix icon name NumLock for Keyboard Indicator #T9050" REPOSITORY

D13481: Recommend window border size "None"

ngraham added a comment. Right. That's not a workflow I think I've ever seen anyone do with a windowed game. For anyone who wants to do that, they can always turn the borders back on. Or just resize one of the windows slightly so the dead zone doesn't overlap the game window. Or not try to p

D13481: Recommend window border size "None"

davidedmundson added a comment. The dead zone exists if you have a focussed lower stacked client. i.e set window A to always on top put window A right next to window B (our FPS) focus window B move the mouse to the edge between A and B but still slightly over B input is not given

D13481: Recommend window border size "None"

ngraham added a comment. What is the problem with an FPS in windowed mode? If anything, the potential problem would be a windowed RTS or other game where you're expected to move the view by touching a window edge. But even in this case, the "dead zone" is //outside// the window rather than i

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. I'll get back to work on this. I've got a current open patch I need to finish up first, then I'll resume work on this. Should be a couple days at most. Thanks for all the debate and decision on the messaging. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISI

D13481: Recommend window border size "None"

graesslin added a comment. In D13481#279575 , @davidedmundson wrote: > There are two visual hints when the mouse is inside the deadzone. > > You would still get the different cursor > The client gets the mouse left event and would not s

Plasma 5.14 kickoff meeting Thursday 28 June 14:00UTC, 15:00BST, 16:00CEST

Most popular time for Plasma 5.14 Kickoff meeting is Plasma 5.14 kickoff meeting Thursday 14:00UTC, 15:00BST, 16:00CEST in #Plasma

D13625: Add 'Documentation' category to the Application menus

hein added a comment. I can see Marco's point, so I can't be the tie-breaker. Other opinions? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13625 To: yurchor, #plasma_workspaces Cc: hein, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

bruns added a comment. New revision with remaining tasks: D12498 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: bruns, abetts, plasma-devel, #plasma, ra

Re: Plasma 5.13.1

Hi: What are those two problems specifically and which distros are reporting them? ArchLinux already included the update to version 5.13.1 Cheers On Tue, Jun 19, 2018, 8:21 PM David Edmundson wrote: > ​Distros, > > We're getting numerous reports of two major problems with 5.13.1 > Please hold

D13625: Add 'Documentation' category to the Application menus

ngraham added a comment. Please replace `BUG: https://bugs.kde.org/show_bug.cgi?id=395580` with `BUG: 395580`. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13625 To: yurchor,

D13628: Make content-script media player code follow user settings

This revision was automatically updated to reflect the committed changes. Closed by commit R856:bbce684853a3: Make content-script media player code follow user settings (authored by davidedmundson). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.

D13628: Make content-script media player code follow user settings

davidedmundson updated this revision to Diff 36379. davidedmundson added a comment. FVogts comments REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13628?vs=36378&id=36379 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13

D13628: Make content-script media player code follow user settings

fvogt added inline comments. INLINE COMMENTS > messages.json:36 > +"description": "Title for MediaSessions API Control plugin", > +"message": "Enhanced Media Controls" > +}, Maybe add `(Experimental)` REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://ph

D13628: Make content-script media player code follow user settings

fvogt added a comment. Does it make sense to enable mprisMediaSessions without mpris? As I don't think that is the case, can you make that visible in the UI and change `if (items.mprisMediaSessions.enabled) {` to `if (items.mpris.enabled && items.mprisMediaSessions.enabled) {` REPOSITORY

D13628: Make content-script media player code follow user settings

davidedmundson created this revision. davidedmundson added reviewers: fvogt, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If a user disables the mpris plugin th

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/14/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 10:06:38 + Build duration: 6 min 0 sec and counting JUnit Tests

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 13 - Still Failing!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/6/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 20 Jun 2018 09:52:35 + Build duration: 3 min 16 sec and counting

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/19/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 09:53:30 + Build duration: 1 min 24 sec and counting JU

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/8/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 09:52:31 + Build duration: 1 min 42 sec and counting JUni

Re: Plasma 5.13.1

plasma-desktop 5.13.1.1 tarball is now up. Should have both issues resolved sha256 c5f51c34a8549c879b691ea5de054100884c00bea32f559fc537ce338870a1bf plasma-desktop-5.13.1.1.tar.xz c1edded6db86fa77d8078f08ba9858f94e82dca336b7da871cbd611093e8a70e plasma-desktop-5.13.1.1.tar.xz.sig Note it's signed b

D13618: Only add Media Sessions Shim if we find a valid video object

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in content-script.js:419 > even if it did, you still have DOM manipulation on the executeScript function Sure but one thing at a time REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org

Re: plasma-devel to auto-discard non-subscribers?

On Wed, Jun 20, 2018 at 8:38 PM, Luca Beltrame wrote: > In data martedì 19 giugno 2018 16:05:34 CEST, Harald Sitter ha scritto: > >> I really do not think this list doesn't benefit from a moderation queue. > > -1. I direct people to this list when they have queries, and for one-off > matters they

D13612: Fix drop between shared views

hoffmannrobert added a comment. I don't have commit access, can you please land it for me? Thanks. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13612 To: hoffmannrobert, mart Cc: amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

Re: plasma-devel to auto-discard non-subscribers?

In data martedì 19 giugno 2018 16:05:34 CEST, Harald Sitter ha scritto: > I really do not think this list doesn't benefit from a moderation queue. -1. I direct people to this list when they have queries, and for one-off matters they shouldn't be forced to subscribe. An outright rejection of the

Re: plasma-devel to auto-discard non-subscribers?

On Tue, Jun 19, 2018 at 5:32 PM Aleix Pol wrote: > > On Tue, Jun 19, 2018 at 4:06 PM Harald Sitter wrote: > > > > Heya > > > > I've been moderating the plasma-devel list for 6 months now, and in > > that time I've seen **one** legitimate pending email. Everything else > > was spam. At least one s

D13625: Add 'Documentation' category to the Application menus

mart added a comment. good idea but a bit on the fence on this.. is something that is definitely useful, but for a short time.. i see the user wanting to eventually remove this after having used said distro for enough time and feeling to have learned it REPOSITORY R120 Plasma Workspace RE

D13619: Inject script on relevant video nodes not top of DOM

davidedmundson added a comment. Right, I should move the removeChild to before the break. As for the other comment if there's no players, there's limited point executing the script. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13619 To: david

D13619: Inject script on relevant video nodes not top of DOM

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. I don't think this is a good idea - if no player exists, it'll either fail silently or throw an exception on the "element.parentNode" access. REPOSITORY R856 Plasma Browser Integr

Re: Plasma 5.13.1

Two issues were: * Complete crash on startup. Seems to be with Qt < 5.11 so Arch is fine * Some relatively minor issue with the touchpad KCM not loading We'll have a 5.13.1.1 of plasma-desktop coming today which addresses both. David