asturmlechner updated this revision to Diff 35985.
asturmlechner added a comment.
Use Q_UNUSED
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13255?vs=35896&id=35985
BRANCH
arcpatch-D13255
REVISION DETAIL
https://phabricator.kde.org/D13255
AFFEC
romangg accepted this revision.
romangg added a comment.
Please wait for @mart's ok before pushing.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13372
To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, les
furkantokac updated this revision to Diff 35974.
furkantokac added a comment.
Stupid mistake that I have done is fixed. Thank you romangg.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13372?vs=35961&id=35974
BRANCH
arcpatch-D13372
REVISION DETA
romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.qml:78
> -id: maincol
> -enabled: deviceCount
> -spacing: units.largeSpacing
This needs to stay. Try it without mou
ngraham accepted this revision.
ngraham added a comment.
Thanks! Looks good to me now. Please wait for Marco and Roman too before
committing.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13372
To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart,
furkantokac updated this revision to Diff 35961.
furkantokac added a comment.
V0.3
sizeHint and minimumSizeHint are added.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13372?vs=35926&id=35961
BRANCH
arcpatch-D13372
REVISION DETAIL
https://p
kossebau resigned from this revision.
kossebau added a comment.
Myself have not dealt with KIO/UDS for some years, so no clue what is wanted
here. Also only touched this repo for buildsystem brush-over, so not a good
reviewer candidate, thus resigning as reviewer.
@smithjd I would recomm
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.qml:32
> -property size sizeHint: Qt.size(maincol.width, maincol.height)
> -property size minimumSizeHint: Qt.size(maincol.width/2,
> deviceSel
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/10/
Project:
Plasma powerdevil stable-kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Jun 2018 17:02:05 +
Build duration:
1 min 52 sec and counting
JUnit Test
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/6/
Project:
Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Jun 2018 17:02:08 +
Build duration:
1 min 46 sec and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/4/
Project:
Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10
Date of build:
Sun, 10 Jun 2018 17:02:11 +
Build duration:
1 min 43 sec and counting
https://bugs.kde.org/show_bug.cgi?id=350365
--- Comment #22 from Rolf Eike Beer ---
Similar to comment #8, I have this messages:
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:43:39:
Unable to assign [undefined] to bool
file:///usr/share/plasma/pl
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/43/
Project:
Plasma kwin kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Jun 2018 07:20:30 +
Build duration:
33 min and counting
JUnit Tests
Name: (root) Failed: 6
13 matches
Mail list logo
