D13372: Mouse KCM is redesigned by using Kirigami. Tested on Xorg and Wayland. Functionality is same.

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13372 AFFECT

D13202: Circular user avatar for Kickoff

sharvey added a comment. @apol : My first pass at this used `OpacityMask`. It worked well. See below. In D13202#270387 , @sharvey wrote: > F5875550: Screenshot_20180529_113110.png Two things, th

D13202: Circular user avatar for Kickoff

sharvey added inline comments. INLINE COMMENTS > apol wrote in Header.qml:139 > No need to set it to true, just drop the line. Stupid defaults. :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma Cc: apol, davidedmundson

D13202: Circular user avatar for Kickoff

apol added inline comments. INLINE COMMENTS > Header.qml:104 > +//but in SDDM that's a bit pointless > +fragmentShader: " > +varying highp vec2 qt_TexCoord0; I tried using fragment shader in discover and it ported poorly on different hardware.

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35648. sharvey added a comment. - Reset QtQuick version to 2.4 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35647&id=35648 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL https

D13202: Circular user avatar for Kickoff

sharvey added a comment. Let's try this... INLINE COMMENTS > Header.qml:139 > +source: squareFace > +visible: true > width: units.gridUnit * 3 Was `faceIcon.status !== Image.Ready`, which I believe was an old timing test when machines were slower. Doesn't seem neces

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35647. sharvey added a comment. - Force icon to be visible, avoiding blank circle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35151&id=35647 BRANCH round-kickoff-avatar (branched from master) REVI

D13346: Use more contextual strings for some button labels

abetts added a comment. In D13346#274450 , @emateli wrote: > > In D13346#274446 , @abetts wrote: > > Could we have a button that enables/disables bluetooth instead? We can show the warning message on

D13346: Use more contextual strings for some button labels

emateli added a comment. > In D13346#274446 , @abetts wrote: > Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when ena

D13346: Use more contextual strings for some button labels

abetts added a comment. In D13346#274427 , @ngraham wrote: > Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color? I t

D13346: Use more contextual strings for some button labels

ngraham added a comment. Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D13346 To: ngraham,

D13367: Improve the clarity and presentation of the update details text field

ngraham added a comment. Does this work satisfactorily for you on Arch? REPOSITORY R134 Discover Software Store BRANCH clearer-update-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D13367 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ragreen, P

D13232: introduce Custom color set

mart updated this revision to Diff 35612. mart added a comment. - confised prototype for custom colors handling - coloroverrides has approach - add missing file - another route: Custom color set - propagate all colors - export a palette in the basictheme - propagate colors to materi

D13361: Allow Compact view with narrower windows

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY When the width of the sidebar was reduced, I

D13346: Use more contextual strings for some button labels

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Every Bluetooth error's "fix this error" button's text is "Fix

D13288: Fix the icons KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3085a40378c3: Fix the icons KCM (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13288?vs=35415&id=35623 REVISION DETAIL https://phabric

D13346: Use more contextual strings for some button labels

abetts added a comment. +1 I feel this is a must. We are trying to convey that the user needs to enable Bluetooth in order to make it work. There is real issue there. In fact, could we maybe change the color message from RED to something more informational? REPOSITORY R97 Bluedevil R

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We don't need this now we have Albert's patch, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davide

[Breeze] [Bug 395010] If scroll up/down buttons are visible, always show them in the scrollbar gutter

https://bugs.kde.org/show_bug.cgi?id=395010 --- Comment #3 from Nate Graham --- Yeah, I didn't have much luck there either. I found two instances of this in kstyle/breezestyle.cpp: // no mouse over and no animation in progress, don't draw arrows at all else if( !widgetMouseOver ) return Qt::tran

D13326: Hide settings when run on non-supported platform

This revision was automatically updated to reflect the committed changes. Closed by commit R856:27096b7afc81: Hide settings when run on non-supported platform (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13326?vs=356

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

ngraham added a comment. Do you need someone to land this for you, Miklós? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma, mart Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D13232: introduce Custom color set

mart added a comment. D13233 not necassary anymore REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13232 To: mart, #kirigami, broulik Cc: plasma-devel, apol, davidedmundson, mart, hein

D13326: Hide settings when run on non-supported platform

broulik updated this revision to Diff 35611. broulik added a comment. - Don't load settings when unsupported - Also don't register the save handlers REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13326?vs=35505&id=35611 REVISION DETAIL

D13360: Touchpad KDED module: Convert to JSON metadata

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. marten requested review of this revision. REVISION SUMMARY This is now the preferred way of providing plugin metadata. It's not

D13346: Use more contextual strings for some button labels

This revision was automatically updated to reflect the committed changes. Closed by commit R97:c7f72367599b: Use more contextual strings for some button labels (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13346?vs=35583&id=35607 REVI

D13334: When using a different background color, use highlightedText as text color

This revision was automatically updated to reflect the committed changes. Closed by commit R169:048da9adcbb9: When using a different background color, use highlightedText as text color (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13334?v

D13336: Check for option->styleObject before accessing it

This revision was automatically updated to reflect the committed changes. Closed by commit R31:6d886e9f75d0: Check for option->styleObject before accessing it (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13336?vs=35534&id=35603#toc REPOSITORY R31 Breeze CHANGE

D13350: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fb96a53d: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13350?vs=35589&id=35

D13357: Use logging categories in a few dataengines

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH

D13350: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Nice REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13350 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen,

D13350: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Which delegates the task of doing it to a out of process IO slave

D13336: Check for option->styleObject before accessing it

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Note you're not matching Breeze's existing coding style REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13336 To: broulik, #plasma, cfeck, davidedmun

D13346: Use more contextual strings for some button labels

broulik added a comment. +1 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D13346 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart