D11746: Assign notification area category

2018-05-20 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D11746 To: wsdfhjxc, #plasma, broulik Cc: Pitel, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12534: [timer applet] Fix internal function calls

2018-05-20 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R114:557a4d2de724: [timer applet] Fix internal function calls (authored by mmazur, committed by aacid). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12534?vs=331

D12533: [timer applet] Unify QtQuick imports

2018-05-20 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12533 To: mmazur, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12821: Added missing files in QMake's .pri

2018-05-20 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12821 To: Dax, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D12853: Calendar widget: fix resize

2018-05-20 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12853 To: miklosm, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

2018-05-20 Thread David Edmundson
davidedmundson resigned from this revision. davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in actionlist.cpp:156 > This patch worked just for me all by itself, so I wasn't aware this required > a plasma-framework change (I just moved the conditional around a bit, > basica

D13006: Move the inline installer progress cancel button to the left side

2018-05-20 Thread Andreas Kainz
andreaska added a comment. Thanks +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13006 To: ngraham, apol, #discover_software_store Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D13006: Move the inline installer progress cancel button to the left side

2018-05-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This prevents the progress view from jumping

Re: Plasma Vaults by Default

2018-05-20 Thread Ivan Čukić
Hi Jonathan, One possibility is to hide the icon if the user does not use Vaults (if the user has no vaults configured) similar to how the pager applet behaves. Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3 45DF C9C5 77AF 0A37 240A

D12996: Register players when tab becomes audible

2018-05-20 Thread Fabian Vogt
fvogt added a comment. Fixed: https://phabricator.kde.org/D13001 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D12996 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13001: Handle children of added nodes as well

2018-05-20 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, broulik, davidedmundson. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Element trees can be added as well, but without this, only the root element was handled. TEST PLAN

D12999: Fix always empty memory bar

2018-05-20 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R114:f54bcde16302: Fix always empty memory bar (authored by arojas). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12999?vs=34521&id=34529 REVISION DETAIL http

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

2018-05-20 Thread Martin Flöser
graesslin added a comment. Restricted Application added a subscriber: kde-frameworks-devel. any update on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel

D12999: Fix always empty memory bar

2018-05-20 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Add back the memoryUsageProportionsChanged() call that was re

D12996: Register players when tab becomes audible

2018-05-20 Thread Fabian Vogt
fvogt added a comment. > I don't fully understand why neither createElement nor the mutation observer detect it, though. IMO that should be debugged a bit further before landing this, as it's AFACIT only a hack. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://pha

D12997: Add new api to support window tabs

2018-05-20 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY The new API basically just provides a vector of Decorat

D12990: update mouse kcm docbook to 5.13

2018-05-20 Thread Luigi Toscano
ltoscano added a comment. Maybe we need a basic document for the other KCM too; a small note here could be useful anyway. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12990 To: lueck, #plasma, #documentation Cc: ltoscano, plasma-devel, kde-doc-english, rag

D12990: update mouse kcm docbook to 5.13

2018-05-20 Thread Burkhard Lück
lueck added a comment. does it make sense to add a hint, that single-/double-click setting moved to workspaceoption kcm? workspaceoption kcm has no docbook, therefore you can not find where this setting is in plasma >5.12 using search in khelpcenter or on docs.kde.org, but this search was

D12996: Register players when tab becomes audible

2018-05-20 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a tab becomes audible (ie. the playing

D12991: Ensure the salt file is indeed a regular file

2018-05-20 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pam_kwallet.c:732 > +syslog(LOG_ERR, "%s: Failed to ensure %s looks like a salt file", > logPrefix, path); > +return 1; > +} Missing `free

D12991: Ensure the salt file is indeed a regular file

2018-05-20 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY If it's not a regular file we try to re-create it if we can't for some reason, we bail out REPOSITORY

D12990: update mouse kcm docbook to 5.13

2018-05-20 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added projects: Plasma, Documentation. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY bump date + releaseinfo ad