[Breeze] [Bug 394459] New: "Invalid escape sequences in line" error in system log

2018-05-19 Thread ๆž—ๅšไป
https://bugs.kde.org/show_bug.cgi?id=394459 Bug ID: 394459 Summary: "Invalid escape sequences in line" error in system log Product: Breeze Version: 5.12.5 Platform: Neon Packages OS: Linux Status: UNCONFIRMED

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > workspaceoptions.cpp:51 > > -/*ConfigModule functions*/ > +// ***ConfigModule functions > void KCMWorkspaceOptions::load() Why all the asterisks? > workspaceoptions.h:58 > // QML variables > -bool m_ostateToolTip; // Original state

D12973: Workspace KCM Redesign Using Kirigami

2018-05-19 Thread Furkan Tokac
furkantokac updated this revision to Diff 34500. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34459&id=34500 BRANCH kcmworkspace-Redesign REVISION DETAIL https://phabricator.kde.org/D1

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac
furkantokac marked 3 inline comments as done. furkantokac added inline comments. INLINE COMMENTS > zzag wrote in workspaceoptions.cpp:37 > I think you could do something like this in the header file > > class ... { > ... > m_stateToolTip = true; > m_stateVisualFeedback = true; >

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac
furkantokac updated this revision to Diff 34499. furkantokac added a comment. State variable names are changed. Some formatting improvements. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34458&id=34499 BRANCH kcmworkspace-CodeFormatting

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Nathaniel Graham
ngraham added a comment. In D12974#264991 , @furkantokac wrote: > In D12974#264920 , @ngraham wrote: > > > While we're doing some formatting and style cleanup work, how about renaming some variable

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Luigi Toscano
ltoscano added a comment. I expect the plasma developer to be able to help with fixing this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 To: yurchor, #plasma, kde-i18n-doc, ltoscano Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Yuri Chornoivan
yurchor added a comment. In D12982#265059 , @ltoscano wrote: > I don't want to go back from kcm5_workspace to kcm_workspace. Any solution should allow to define a specific name for the KCMs. This will probably need some refactoring inside

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. I don't want to go back from kcm5_workspace to kcm_workspace. Any solution should allow to define a specific name for the KCMs. REPOSITORY R119 Plasma Desktop REVISION DETA

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Yuri Chornoivan
yurchor created this revision. yurchor added reviewers: Plasma, kde-i18n-doc. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY According to this comment: https://marc.info/?l=

D12960: Drag handle to reorder items in a ListView

2018-05-19 Thread Alessandro Longo
alex-l added a comment. Possible interactions on hover (I used the third one and the fourth one when dragging): F5858223: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein

D12960: Drag handle to reorder items in a ListView

2018-05-19 Thread Alessandro Longo
alex-l added a comment. I tried with arrows too, but I think the fifth one looks better... my second choice is the third one. F5858203: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigam

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Vlad Zagorodniy
zzag added a comment. Also, about coding style. Why are you using `/*` for one line comments? INLINE COMMENTS > workspaceoptions.cpp:29 > #include > #include > https://community.kde.org/Policies/Kdelibs_Coding_Style#Qt_Includes > workspaceoptions.cpp:37 >m_stateVisualFeedback(

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac
furkantokac added a comment. In D12974#264920 , @ngraham wrote: > While we're doing some formatting and style cleanup work, how about renaming some variables? For example `m_ostateToolTip` and `m_ostateVisualFeedback` aren't very descriptive IMH

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Vlad Zagorodniy
zzag removed a reviewer: zzag. zzag added a comment. Thanks, but I'm not a member of #Plasma . ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12974 To: furkantokac, ngraham, romangg, #plasma Cc: plasma-devel, ragr

KDE CI: Plasma kwin stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Still unstable!

2018-05-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20SUSEQt5.10/9/ Project: Plasma kwin stable-kf5-qt5 SUSEQt5.10 Date of build: Sat, 19 May 2018 07:02:13 + Build duration: 37 min and counting JUnit Tests Name: (roo