KDE CI: Plasma ksysguard kf5-qt5 FreeBSDQt5.10 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma ksysguard kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 17 May 2018 05:47:57 + Build duration: 1 min 32 sec and counting

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#263873 , @Kanedias wrote: > Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try `auto reply = dbusXdpService->CreateSession(QVariantMap());` (with empty parameter map), the main desk

D12936: Rewrite workspace KCM in QtQuick

romangg added inline comments. INLINE COMMENTS > kcm.cpp:107 > +{ > +if( m_stateToolTip == state ) return; > + needs braces. see https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces > metadata.desktop:2 > +[Desktop Entry] > +Name=Workspace > +Name[ar]=مساحة العمل I believe you sh

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#263885 , @Kanedias wrote: > Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch? ScreenCa

D12936: Rewrite workspace KCM in QtQuick

furkantokac added a comment. In D12936#263969 , @ngraham wrote: > Please follow standard KDE style for braces in new code: > > void myFunction() { > int stuff = 1; > } > According to Kdelibs Coding Style

D12936: Rewrite workspace KCM in QtQuick

ngraham added inline comments. INLINE COMMENTS > kcm.cpp:51 > +// Load toolTip > +{ > +const KConfigGroup cg(config, QStringLiteral("PlasmaToolTips")); Why are these within braces? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12936 To: furkan

D12936: Rewrite workspace KCM in QtQuick

ngraham added a comment. Please follow standard KDE style for braces in new code: void myFunction() { int stuff = 1; } REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12936 To: furkantokac, romangg, ngraham Cc: davidedmundson, plasma-devel,

D12936: kcm_workspace is finished.

furkantokac updated this revision to Diff 34343. furkantokac added a comment. Rewrite workspace KCM in QtQuick REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12936?vs=34332&id=34343 BRANCH bug393547-SingleDoubleClickFunc REVISION DETAIL https:/

D12936: kcm_workspace is finished.

ngraham added inline comments. INLINE COMMENTS > kcm.cpp:133 > +// If yes, setNeedsSave(true). > +void KCMWorkspaceOptions::handleIfNeedSave() > +{ How about `handleNeedsSave()` instead? > furkantokac wrote in ToolTip.qml:2 > Yeap it's Roman's implementation used in "input" kcm. Shouldn't I use

D12936: kcm_workspace is finished.

davidedmundson added inline comments. INLINE COMMENTS > furkantokac wrote in metadata.desktop:105-107 > I'm removing. > Can you explain why ? Just want to learn. Those are special hints which are used only by plasma applets. This isn't a plasma applet. So they do nothing. REPOSITORY R119 Pla

D12936: kcm_workspace is finished.

ngraham added a comment. Also, this patch doesn't actually solve https://bugs.kde.org/show_bug.cgi?id=393547; it just ports the KCM to QML in preparation for fixing it. So please remove the `BUG 393547` keyword and let's only add it to the patch that actually re-adds the missing feature. RE

D12936: kcm_workspace is finished.

furkantokac added a comment. In D12936#263939 , @ngraham wrote: > In D12936#263907 , @furkantokac wrote: > > > In D12936#263886 , @davidedmundson wrote:

D12936: kcm_workspace is finished.

ngraham added a comment. In D12936#263907 , @furkantokac wrote: > In D12936#263886 , @davidedmundson wrote: > > > Can you change the title to something more specific. > > > There will be other

D12936: kcm_workspace is finished.

furkantokac added a comment. In D12936#263894 , @ngraham wrote: > BTW, here are a couple of formatting rules you should follow: https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch Oh I know it but just forgot. Editi

D12937: Drop privileges when reading the salt file

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY As found by Matthias Gerstner the user here controls nearly everything: - he controls his own passw

D12936: kcm_workspace is finished.

ngraham added inline comments. INLINE COMMENTS > ExclGroupBox.qml:1 > +/* > + * Copyright 2017 Roman Gilg Is this file actually used at all? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12936 To: furkantokac, romangg, ngraham Cc: davidedmundson, plasma-deve

D12936: kcm_workspace is finished.

davidedmundson added a comment. Can you change the title to something more specific. INLINE COMMENTS > ToolTip.qml:2 > +/* > + * Copyright 2017 Roman Gilg > + * is this copy pasted from somewhere? > main.qml:24 > + > +import org.kde.plasma.core 2.0 as PlasmaCore > + this is unused in ever

D12936: kcm_workspace is finished.

ngraham added a comment. BTW, here are a couple of formatting rules you should follow: https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12936 To: furkantokac, romangg, ngraham Cc: david

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedia

D12936: kcm_workspace is finished.

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY kcm_workspaceoptions is changed as kcm_workspace. It is rewritten in QML, ConfigModule.

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try `auto reply = dbusXdpService->CreateSession(QVariantMap());` (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG Deskto

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

rkflx resigned from this revision. rkflx added a comment. Sorry for resigning as a reviewer, but currently I lack the time to review this in depth. Maybe I can do some basic testing tomorrow, but no promises. As said before though, conceptually this makes sense to me. IIUC, this is a GUI

D12849: Improve layout of fonts kcm

rkflx added a comment. In D12849#263660 , @progwolff wrote: > That would be this one: > > In D12849#262919 , @progwolff wrote: > > > F5849709: Screenshot_fonts_layout_tabbar.png

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34315. progwolff added a comment. - remove unintentionally committed debug lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34274&id=34315 BRANCH fonts_kcm_globalConfigFiles (branched from maste

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

ngraham added a comment. I liked this... Are you going to try again with a different style of notification or something? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, ma

D12909: Don't create salt file if user home directory does not exist

aacid closed this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12909 To: aacid, mart, fvogt Cc: fvogt, mgerstner, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12909: Don't create salt file if user home directory does not exist

aacid updated this revision to Diff 34309. aacid added a comment. add missing return ^_^ REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12909?vs=34239&id=34309 BRANCH arcpatch-D12909 REVISION DETAIL https://phabricator.kde.org/D12909

D12910: Return PAM_IGNORE from pam_sm_authenticate

This revision was automatically updated to reflect the committed changes. Closed by commit R107:aa33d5438842: Return PAM_IGNORE from pam_sm_authenticate (authored by aacid). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12910?vs=34243&id=34308

D12849: Improve layout of fonts kcm

ngraham added a comment. I know the tabs are currently ugly, but let me explain my reasoning behind suggesting them: It's not a simple "VDG says tabs are bad, don't use them"; scrolling is preferred to a more formal method of organization only when the content itself is naturally scroll

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. +1 conceptually; "Vendor Default" was always really awkward to explain to people. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, rkflx Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D12849: Improve layout of fonts kcm

progwolff added a comment. That would be this one: In D12849#262919 , @progwolff wrote: > F5849709: Screenshot_fonts_layout_tabbar.png @mart @rkflx @broulik is this okay for you? REPOSITORY

D12837: Split replaceAccount from addAccountToCache

This revision was automatically updated to reflect the committed changes. Closed by commit R128:ff88e24e4380: Split replaceAccount from addAccountToCache (authored by valeriymalov). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12837?vs=34027&id=34304 R

D12837: Split replaceAccount from addAccountToCache

ngraham added a comment. The next stable release is 5.12.6, which is scheduled for 2018-06-27 (actually after 5.13!). So I think you should be fine. https://community.kde.org/Schedules/Plasma_5 REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. I meant it more in terms of "not landing it right before next stable release" :v But if it's okay to land now I can land it right now REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D12837 To: valeriymalov, #plasma,

D12837: Split replaceAccount from addAccountToCache

ngraham added a comment. In D12837#263632 , @valeriymalov wrote: > In D12837#262817 , @ngraham wrote: > > > Any chance we could land this on the stable branch? > > > Well, it does apply cleanl

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. In D12837#262817 , @ngraham wrote: > Any chance we could land this on the stable branch? Well, it does apply cleanly to Plasma/5.12 branch and it still works, but I don't really know if there's a special proc

D12849: Improve layout of fonts kcm

abetts added a comment. In D12849#263364 , @progwolff wrote: > In D12849#263302 , @broulik wrote: > > > We were always told by VDG that tabs are bad and a 5 km vertically scrolling list is better n

D12852: Added the option to display date in the same line of clock

abetts added a comment. Where would this be used? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12852 To: astevanato, #plasma_workspaces, #vdg Cc: abetts, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12926: Set variable for chromium install dir

This revision was automatically updated to reflect the committed changes. Closed by commit R856:fa06ad6b7090: Set variable for chromium install dir (authored by jriddell). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12926?vs=34286&id=3429

D12928: Make Apply/Discard settings prompt consistent with rest of settings

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When switching between shortcut categories with pending change

D12676: [Notifications] Show tooltip on action when text doesn't fit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:92a98735cc5b: [Notifications] Show tooltip on action when text doesn't fit (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12676?vs=3

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. As part of porting can you please go through: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&component=kcm_language&list_id=1517561&product=systemsettings&query_format=advanced One about

D12909: Don't create salt file if user home directory does not exist

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pam_kwallet.c:713 > +syslog(LOG_ERR, "%s-kwalletd: user home folder does not exist", > logPrefix); > +} > + Missing return? REPOSITORY R107 KWal

D12926: Set variable for chromium install dir

jriddell updated this revision to Diff 34286. jriddell added a comment. - add back comment about ubuntu REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12926?vs=34281&id=34286 BRANCH master REVISION DETAIL https://phabricator.kde.org

D12927: [Service Runner] Do startsWith check case-insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b998e68d1128: [Service Runner] Do startsWith check case-insensitive (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12927?vs=34280&id

D12923: [TabBar] Switch tabs with mouse wheel

This revision was automatically updated to reflect the committed changes. Closed by commit R858:670f6771aa7f: [TabBar] Switch tabs with mouse wheel (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12923?vs=34269&

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. In D12925#263459 , @mart wrote: > if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? Just don't change anything in the kcm. The global config files are ne

D12926: Set variable for chromium install dir

bshah accepted this revision. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:75 > # chromium > -# in ubuntu and derivatives, this should be installed in the > chromium-browser/extensions, > -# but since this is distribu

D12927: [Service Runner] Do startsWith check case-insensitive

broulik created this revision. broulik added reviewers: Plasma, hein, romangg. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This codepath is hit when the search query is very s

D12926: Set variable for chromium install dir

jriddell created this revision. jriddell added a reviewer: bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jriddell requested review of this revision. REVISION SUMMARY Set variable for chromium install dir TEST PLAN make; install

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

mart added a comment. what's the status of this? when ready, should go in, together D12040 at the beginning of 3.14 vyvle REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: mart, abetts, davidedm

D12539: Klipper: Do not insert secret data into history

davidedmundson added a comment. I was kinda hoping to see your keepassx patch merged before we did this in case of any changes, but given we have 5.13 beta soon, I've merged as-is REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, dav

D12893: Fix Logout screen countdown not cancelling on multi-monitor setups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:38367efd5e93: Fix Logout screen countdown not cancelling on multi-monitor setups (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D12539: Klipper: Do not insert secret data into history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:637cd0bf62e4: Klipper: Do not insert secret data into history (authored by hoffmannrobert, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12539?vs=33138&id=34277#t

D12852: Added the option to display date in the same line of clock

mart added a comment. added VDG for their opinion on this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12852 To: astevanato, #plasma_workspaces, #vdg Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ship it with a minor change INLINE COMMENTS > cpu.qml:45 > //return i18n("%1 %2", Math.round(data.value), data.units); > return i18nc("CPU usage: %1 is the value, %2 t

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

mart added a comment. if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, rkflx Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D12102: Port Language KCM to Qt Quick

hein added a comment. Sorry, accident! The code in the Keyboard KCM is ... interesting and literally breaks my system trying to build it (it needs a two-digit amount of GB of memory to build thanks to a boost-based keyboard layout preview generator it even changes the LLVM template recursion

D12091: HIG entry for On-demand pattern and swipe list item

fabianr closed this revision. REPOSITORY R985 KDE Human Interface Guidelines REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

colomar accepted this revision. colomar added a comment. Perfect! REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol,

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 34275. fabianr added a comment. - removed border around dolphin example in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=34271&id=34275 BRANCH swipe REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34274. progwolff added a comment. - Fix 'disabled from' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34272&id=34274 BRANCH fonts_kcm_globalConfigFiles (branched from master) REVISION DETAIL htt

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff created this revision. progwolff added a reviewer: rkflx. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The fonts kcm did only parse a local config file. Global and

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 34271. fabianr added a comment. - moved example image to the top in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33745&id=34271 BRANCH swipe REVISION DETAIL https

D12923: [TabBar] Switch tabs with mouse wheel

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it consistent with `QTabWidget` TEST PLAN Copied from `Co

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. More concrete suggestion: Move the Dolphin screenshot to the top, next to the mobile screenshot. REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-de

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. Currently we have a screenshot of the nouseover in Dolphin in here, but screenshots for swipeListItem only in the corresponding page. That gives preference to the Dolphin pattern because lazy people will implement what they see first. Therefore there should either be

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. Restricted Application removed a subscriber: Frameworks. Any suggestion how to fix the overload problem? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, n

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#263302 , @broulik wrote: > We were always told by VDG that tabs are bad and a 5 km vertically scrolling list is better no matter what. So be consistent, please. I thought I read something like this in