D12102: Port Language KCM to Qt Quick

2018-05-09 Thread Eike Hein
hein added a comment. @mart Do you think I should push this before we work on the DND stuff? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts

D12794: [weather applet] Improve name & comment metadata

2018-05-09 Thread Nathaniel Graham
ngraham added a comment. "Forecast and current conditions? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

2018-05-09 Thread Friedrich W . H . Kossebau
kossebau added a comment. Hoping for some native speaker with weather science background to provide proper naming here :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D12794: [weather applet] Improve name & comment metadata

2018-05-09 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The applet shows both observation and the forecast as reported

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2018-05-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=348529 gade...@gmail.com changed: What|Removed |Added CC||gade...@gmail.com --- Comment #15 from gade.

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369520 Nate Graham changed: What|Removed |Added Component|default |FISH CC|

[kio-extras] [Bug 361454] fish: No information on disk space

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=361454 Nate Graham changed: What|Removed |Added Component|default |FISH CC|

[kio-extras] [Bug 329687] previewing an HTML file from a local file system causes network retrievals while generating the thumbnail

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=329687 Nate Graham changed: What|Removed |Added Component|default |Thumbnails and previews CC|

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=366488 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=354004 Nate Graham changed: What|Removed |Added Component|default |Samba CC|

[kio-extras] [Bug 348163] NFS configuration fails on absence of xdr_u_int64_t type

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=348163 Nate Graham changed: What|Removed |Added Component|default |NFS CC|

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=345440 Nate Graham changed: What|Removed |Added Component|default |SFTP CC|

[kio-extras] [Bug 375305] SFTP file create date is wrong

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375305 Nate Graham changed: What|Removed |Added Component|default |SFTP CC|

[kio-extras] [Bug 370594] smb cannot create file with a :

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=370594 Nate Graham changed: What|Removed |Added Component|default |Samba CC|

[kio-extras] [Bug 380417] fish doesn't use User from .ssh/config

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=380417 Nate Graham changed: What|Removed |Added CC||n...@kde.org Severity|normal

[kio-extras] [Bug 378217] Use user defined in .ssh/config for fish

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=378217 Nate Graham changed: What|Removed |Added Component|default |FISH CC|

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375826 Nate Graham changed: What|Removed |Added Component|default |SFTP CC|

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=376301 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=363593 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

[kio-extras] [Bug 368877] log_kio_sftp log flood

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368877 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375732 Nate Graham changed: What|Removed |Added Component|default |SFTP CC|

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375249 Nate Graham changed: What|Removed |Added Component|default |NFS -- You are receiving this mail because: You

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=362988 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375840 Nate Graham changed: What|Removed |Added Component|default |MTP -- You are receiving this mail because: You

[kio-extras] [Bug 375552] Search in files does not show results when search string ends with parenthese

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=375552 Nate Graham changed: What|Removed |Added Keywords||usability -- You are receiving this mail because

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

2018-05-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=349795 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|default

D12777: Fixed access to current slideshow image using correct field in action_open

2018-05-09 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm both the issue and that this patch fixes it. Thanks! Any objections from other #plasma folks? REPOSITORY R120 Plasma Workspace REV

D12790: Use \n instead of for the extra part of the summary

2018-05-09 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: lukas, jgrulich. fvogt requested review of this revision. REVISION SUMMARY The tooltip text only supports plaintext, so it contained a literal "". A "\n" works as a newline in both the expanded representation and the tooltip. TEST PLAN Hov

D6096: Add Wayland RemoteAccess capabilities to KRfb

2018-05-09 Thread Oleg Chernovskiy
Kanedias added a subscriber: jgrulich. Kanedias added a comment. @jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie. Now I'm curious, you have `handle` and `session_handle` paths everywhere in Screencast interface inside XDP-KDE source. W

D12777: Fixed access to current slideshow image using correct field in action_open

2018-05-09 Thread Nathaniel Graham
ngraham added a comment. In D12777#260152 , @odeda wrote: > Thanks for the notes. I've followed the instructions in https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow the link to the Phabricator page you referred to

D12777: Fixed access to current slideshow image using correct field in action_open

2018-05-09 Thread Oded Arbel
odeda added a comment. Thanks for the notes. I've followed the instructions in https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow the link to the Phabricator page you referred to - it might have been a good idea to stress the importance of reading that page a bit

D12102: Port Language KCM to Qt Quick

2018-05-09 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. on my side, code is all fine now REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotash

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

2018-05-09 Thread Scott Harvey
This revision was automatically updated to reflect the committed changes. Closed by commit R124:19712a1d22b2: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to… (authored by sharvey). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||til...@arved.at --- Comment #12 from Christoph

D12777: Fix for KDE bug 394035

2018-05-09 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch! Please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch - Describe the change in the title - Mention the bug in the Summary section, like this: `BUG: 394035` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein added a comment. There's some conceptual problems with this remaining: - The SNI doesn't disappear when the browser is closed. - When you click the SNI to open, it won't necessarily open in the browser it notified about if it's not also the default browser. - General issues with

D12780: Avoid including the generated config-X11 private header

2018-05-09 Thread Maximiliano Curia
maximilianocuria closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12780 To: maximilianocuria, #plasma, mlaurent, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12781: Fix filetypestest

2018-05-09 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Concatenating strings results

D12780: Avoid including the generated config-X11 private header

2018-05-09 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, mlaurent. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. TEST PLAN building the installed headers no lon

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein updated this revision to Diff 33877. hein added a comment. Clean up `auto` usage REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12698?vs=33868&id=33877 BRANCH arcpatch-D12698 REVISION DETAIL https://phabricator.kde.org/D12698

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > browserintegrationreminder.cpp:138 > +QMenu *menu = new QMenu; > +auto action = new QAction(i18n("Do not show again")); > +menu->addAction(action); `auto` usage is not consistent. Also, it would be better not to use `auto` to deduce raw

Re: Cursor sizes on wayland

2018-05-09 Thread Aleix Pol
On Tue, May 8, 2018 at 8:57 PM, Martin Flöser wrote: > > > Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol : >>Hi, >>I've been looking into getting a consistent cursor look on wayland, >>which is specially daunting because of scaling. >> >>I'd like to look into fixing it for xwayland clients. Would

D12777: Fix for KDE bug 394035

2018-05-09 Thread Oded Arbel
odeda created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. odeda requested review of this revision. REVISION SUMMARY With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" from RMB does nothing. h

D12775: Always set applet title, even when label is disabled

2018-05-09 Thread Eike Hein
hein updated this revision to Diff 33871. hein added a comment. Fix logic error. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12775?vs=33870&id=33871 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D12775 AFFECTED FILES cont

D12775: Always set applet title, even when label is disabled

2018-05-09 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Except when we're a containment. This way Folder View applets always have a nice tab title in the grouping applet. BUG:3

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein added a comment. The code simplification in the above changes also gets rid of the possible C++20 usage. Please re-review now. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D12698 To: hein, davidedmundson, apol, mart, #plasma Cc: alexey

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein updated this revision to Diff 33868. hein added a comment. Add .desktop file names for Firefox Nightly and Google Chrome Beta. "Nightly" is the WM_CLASS used by Firefox Nightly. Its .desktop file should therefore be nightly.desktop, otherwise there are already integration seams.

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein updated this revision to Diff 33867. hein added a comment. - Revise naming and make consistent - Fix copyrights - Don't use other people's branding - Simplify (BrowserInfo is gone) REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein added a comment. At the same time, I'm not sure using the browser icon straight in an SNI is appropriate either. Upstreams might not appreciate their branding being slapped onto something they didn't originate. I think we should use internet-web-browser here (the same icon that's used f

D12698: WIP: Show SNI to install browser-side extension

2018-05-09 Thread Eike Hein
hein added a comment. I'm not a fan of the combined icon idea. On face of it it's a neat "go the extra mile" kind of thing, on the other hand it creates follow-up which I'm certain will not be done in a timely manner, or even forgotten about: Updating those assets whenever the upstream brand

D12774: Fix submenus not updating when switching between categories of the same size

2018-05-09 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This fixes a regression introduced in 38403268aad3 , wh

D12694: Properly fix the native messaging host file

2018-05-09 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R856:e057dcd6afa9: Properly fix the native messaging host file (authored by bshah). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12694?vs=33611&id=3