D12694: Properly fix the native messaging host file

bshah added a comment. In D12694#259291 , @mwolff wrote: > @bshah ping? will you push this? sorry, I was on sick leave, I'll push this, however for documentation you will have to wait for @davidedmundson or @broulik as they are the one wh

D12698: WIP: Show SNI to install browser-side extension

davidedmundson added a comment. FWIW icon was coded like that in order to use a custom firefox + Plasma combined logo / custom chrome + plasma combined logo as appropriate. Though I'm not sure if that image actually got merged into breeze, at which point we could do anything else. REPOSI

Re: Cursor sizes on wayland

Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol : >Hi, >I've been looking into getting a consistent cursor look on wayland, >which is specially daunting because of scaling. > >I'd like to look into fixing it for xwayland clients. Would somebody >be able to shed some light into the issue so I can u

D12698: WIP: Show SNI to install browser-side extension

zzag added a comment. In D12698#259621 , @alexeymin wrote: > Nightly users shall suffer! Icon mismatch is not fatal error, I don't think so. For example, let's say I installed only Google Chrome (from Dev Channel). The only google c

D12760: Improve single-instance application behavior

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY 1. Avoid showing the window of the second instance by creating KDBusService object before creating th

Cursor sizes on wayland

Hi, I've been looking into getting a consistent cursor look on wayland, which is specially daunting because of scaling. I'd like to look into fixing it for xwayland clients. Would somebody be able to shed some light into the issue so I can understand it and fix it? (or if someone else is working

D12698: WIP: Show SNI to install browser-side extension

alexeymin added a comment. In D12698#259554 , @zzag wrote: > Also, there is Firefox Nightly, which has its own icon too. Nightly users shall suffer! Icon mismatch is not fatal error, at least nightly users should know what they have signe

D12741: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R169:242b58bfbed8: Fix warnings (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12741?vs=33762&id=33827 REVISION DETAIL https://phabricator.kde.org

D12742: Remove wrong warning

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dd45e3328845: Remove wrong warning (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12742?vs=33767&id=33826 REVISION DETAIL https://phabricator

D12698: WIP: Show SNI to install browser-side extension

zzag added a comment. Also, there is Firefox Nightly, which has its own icon too. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D12698 To: hein, davidedmundson, apol, mart, #plasma Cc: zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12698: WIP: Show SNI to install browser-side extension

zzag added inline comments. INLINE COMMENTS > browserlaunchwatcher.cpp:62 > +m_browsers["google-chrome.desktop"] = chrome; > +m_browsers["google-chrome-unstable.desktop"] = chrome; > +m_browsers["chromium-browser.desktop"] = {.icon="chromium-browser", > .url=QUrl("https://chrome.goog

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33818. hein added a comment. Set explicit width for Material style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33817&id=33818 BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D1

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33817. hein added a comment. - Right-align 'Add languages ...' button - Clean up cruft from a pre-ListView revision, thanks Marco REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33742&id=33817 BRANCH ar

D12102: Port Language KCM to Qt Quick

mart added a comment. +1 for moving the add language button bottom-right INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +Layout.fillWidth: true > + same consideration for Layout.* in delegates > main.qml:185 > + > +Layout.fillWi

D10791: Fixed the Wikimedia Commons Picture of the Day provider

manuelc abandoned this revision. manuelc added a comment. Okay, no, that clearly didn't work, I think I don't quite know how to resolve that... But, what I also just noticed, is that someone else took on this task anyway, so I'm just gonna abandon this. REPOSITORY R114 Plasma Addons REVIS

D12102: Port Language KCM to Qt Quick

rkflx added a comment. In D12102#259446 , @hein wrote: > Helper text: It's at the top now, AIUI the discussion had evolved to leave it like this? Not sure. LGTM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D10791: Fixed the Wikimedia Commons Picture of the Day provider

manuelc updated this revision to Diff 33814. manuelc added a comment. And I think I totally messed up the diff just now, here I go again... REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10791?vs=33813&id=33814 REVISION DETAIL https://phabricator.k

D10791: Fixed the Wikimedia Commons Picture of the Day provider

manuelc updated this revision to Diff 33813. manuelc added a comment. After some time and careful consideration of how the other providers work I rewrote the JSON parsing code. While doing that I noticed that I overlooked an object in the second return value... I don't know though, wheth

D12698: WIP: Show SNI to install browser-side extension

hein added a comment. I'm left to interpret what David meant with "I don't like the module names". How about we rename the module to 'browserintegrationchecker'? Let's not bikeshed too much though. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.or

D12698: WIP: Show SNI to install browser-side extension

hein added reviewers: apol, mart, Plasma. hein added a comment. The code looks fine to me. I was questioning if `config.writeEntry("shownCount", 100);` should be MAX_SHOW_COUNT + 1 instead for a moment, but this is safer in case it gets bumped later. I'm not sure if this should be an SNI

D12698: WIP: Show SNI to install browser-side extension

hein commandeered this revision. hein added a reviewer: davidedmundson. hein added a comment. I'll commandeer, Kai asked me to take this due to being really sick. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D12698 To: hein, davidedmundson Cc: he

D12702: Avoid giving an stderr to kwallet

maximilianocuria added a comment. Btw, Debian users confirmed that this fixes the issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897687 And in the "Kwallet does not work" thread here: https://lists.debian.org/debian-kde/2018/05/threads.html#1 REPOSITORY R107 KWallet PAM

D12702: Avoid giving an stderr to kwallet

maximilianocuria added a comment. I'm not sure, but I think that pam could be called from a process that has the stdin/stdout/stderr redirected to pipes, so disconnecting those for a long lived process would avoid a possible broken pipe. Now, if that's so, why it's not clossing stdin and std