D12102: Port Language KCM to Qt Quick

hein added a comment. Right-aligned button: Can do, sure. Helper text: It's at the top now, AIUI the discussion had evolved to leave it like this? Not sure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspota

D12702: Avoid giving an stderr to kwallet

tsimonq2 added a comment. When this was getting a security review for Ubuntu from Seth Arnold , he wanted to ask the following (without having to make an account here): "Why is stderr closed on line 429? Most programs can have unexpected results when

D12694: Properly fix the native messaging host file

mwolff added a comment. @bshah ping? will you push this? REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D12694 To: bshah, mwolff, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D12742: Remove wrong warning

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We are using the DelegateRecycler now, this warning doesn't apply.

D12741: Fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't call null items REPOSITORY R169 Kirigami BRANCH master

D4140: Rework playing of volume feedback

drosca added a comment. In D4140#259101 , @apol wrote: > Could we maybe accept this? Not as is, because after D9755 this would need duplicated `SinkModel` (or revert D9755

D12102: Port Language KCM to Qt Quick

abetts added a comment. In D12102#254322 , @hein wrote: > New screenshot: > > F5823188: Screenshot_20180427_001323.png Is the Add Languages button able to be right aligned? Did we want to in

D12685: Fix calendar view: hide unused start/end time labels in day events list

abetts added a comment. I think this is a good idea. Maybe the execution is a bit rough but we can work in making the looks better. Can you take a look at this calendar list and see if there are some things we can use? https://www.google.com/search?q=fantastical&source=lnms&tbm=isch&sa=

D4140: Rework playing of volume feedback

apol added a comment. Could we maybe accept this? BUG: 393931 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4140 To: drosca, #plasma Cc: apol, Zren, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D12685: Fix calendar view: hide unused start/end time labels in day events list

dvratil added a comment. I could imagine using something like "14:00 →" to indicate that the event starts today at 2PM but does not end today, and "→ 16:00" to indicate that this is a multi-day event that didn't start today and ends today at 4PM. Not sure how to indicate a multi-day eve

D12699: Don't allow showing/hiding the drawer when there's no handle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a65e4da24804: Don't allow showing/hiding the drawer when there's no handle (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12699?vs=33646&id=337

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33745. fabianr added a comment. - Changed 'How to use' for on demand pattern to incorporate phab feedback REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33631&id=33745 BRANCH swipe RE

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.10 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.10/15/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 May 2018 06:46:28 + Build duration: 14 min and counting JUnit Tests