D12686: Fix sidebar view regression of not prompting about unsaved changes

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. The current index or highlighted item in the sidebar still changes if you Cancel in the prompt as that's done from QML REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I'm not completely sure that IsDirect should be manually set to true in wayland code path (it looks like a hack just to test). What happens if IsDirect is set to true, but software rendering is active? Will get_dri_device() fail gracefully or something horrible wi

D12686: Fix sidebar view regression of not prompting about unsaved changes

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When you switch module with unsaved changes t

D12476: kcm_opengl: Fix retrieval of DRI information

roberts updated this revision to Diff 33565. roberts added a comment. Update to set IsDirect under Wayland. Managed to run kwin_wayland embedded in an X11 session to confirm. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12476?vs=32999&id=33565 B

D12476: kcm_opengl: Fix retrieval of DRI information

roberts marked an inline comment as done. roberts added a comment. Alexey: That sounds great, but unfortunately I can't get a wayland session to log in no matter how hard I try, so I can't confirm your changes. I'd suggest creating a separate review with your additions if you want to pursue t

D12685: Fix calendar view: hide unused start/end time labels in day events list

kossebau added a comment. Before: F5832339: CalendarBefore.png After: F5832341: CalendarAfter.png I see a small challenge here though how to denote if a date is the start or the end date, in case there

D12685: Fix calendar view: hide unused start/end time labels in day events list

kossebau created this revision. kossebau added reviewers: VDG, Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY There can be events with no start or no end date.

D12683: Guard BookmarksRunner thread use

rempt added a comment. I cannot test it since I haven't got a system with a home-built plasma desktop, but it looks reasonable to me :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12683 To: davidedmundson, #plasma Cc: rempt, plasma-devel, ragreen, Pite

D11722: If GL context creation fails fall back to the software renderer

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:743e2bc94391: If GL context creation fails fall back to the software renderer (authored by davidedmundson). CHANGED PR

D12679: Show SNI when software renderer is in use

This revision was automatically updated to reflect the committed changes. Closed by commit R120:444696fe8e1e: Show SNI when software renderer is in use (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12679?vs=33557&id=33560#toc REPOSITORY R120 Plasma Worksp

D12679: Show SNI when software renderer is in use

davidedmundson updated this revision to Diff 33557. davidedmundson added a comment. Updated per comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12679?vs=33547&id=33557 REVISION DETAIL https://phabricator.kde.org/D12679 AFFECTED FILES

D12683: Guard BookmarksRunner thread use

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Krunner::match is performed in potentially mu

D12679: Show SNI when software renderer is in use

alexeymin added a comment. In D12679#257717 , @davidedmundson wrote: > I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't think we can really help with that.

D12679: Show SNI when software renderer is in use

davidedmundson added a comment. > Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here? I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't thin

D12679: Show SNI when software renderer is in use

alexeymin added a comment. Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12679 To: davidedmundson, #plasma Cc: alexeymin, broulik, plasma-d

D12679: Show SNI when software renderer is in use

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in softwarerendernotifier.cpp:14 > Returns empty string for me, as it's too early in the startup: > > > \note The return value of this function may still be outdated by > > subsequent calls to setSceneGraphBackend() until the

D12679: Show SNI when software renderer is in use

broulik added inline comments. INLINE COMMENTS > softwarerendernotifier.cpp:14 > +{ > +if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) { > +auto group = > KSharedConfig::openConfig()->group(QStringLiteral("softwarerenderer")); Returns empty string for me, as it's

Notes from Sprint - Convergence / input

-- Apps Roman asked about adding touch to our existing QWidget apps. General consensus is that they'll never be as perfect as considering it from the start (aka our kirigami apps) but it's worth doing where it's sensible and easy. possible for Dolphin etc for enabling basic support (flick to scr

D12679: Show SNI when software renderer is in use

davidedmundson added a comment. One of the requested features to D11722 just split as a separate review as the code is mostly unrelated REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12679 To: davidedmundson, #plasma C

D12679: Show SNI when software renderer is in use

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This then invokes the relevant KCM when click

D12573: Style enhancement for network management applet

intika abandoned this revision. intika added a comment. @mart yes indeed i had the same thoughts afterward, this code need to be fixed upfront in QtQuick.Controls.Styles.Plasma or somewhere... REVISION DETAIL https://phabricator.kde.org/D12573 To: intika, #plasma, mart Cc: mart, zzag, plas