D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2018-04-30 Thread Andres Betts
abetts added a comment. What does this look like now after the changes? Screenshot? Video? :D REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragr

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 126 - Still Failing!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/126/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 01 May 2018 03:45:28 + Build duration: 3 min 34 sec and counting

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2018-04-30 Thread Nathaniel Graham
ngraham added a comment. Here's an idea shamelessly stolen from a blog commenter: how about showing the current keyboard layout next to the text field, instead of down in the corner? That way users would see upfront that they're using (or not using) the keyboard layout that they expect. REP

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 125 - Still Failing!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/125/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 01 May 2018 03:45:28 + Build duration: 1 min 45 sec and counting CONSOLE

KDE CI: Plasma kwin stable-kf5-qt5 FreeBSDQt5.9 - Build # 68 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20FreeBSDQt5.9/68/ Project: Plasma kwin stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 21:49:18 + Build duration: 7 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 157 - Still Failing!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/157/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 21:51:09 + Build duration: 3 min 8 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 265 - Still Failing!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/265/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 19:56:13 + Build duration: 2 min 7 sec and counting CONSOLE

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2018-04-30 Thread Nathaniel Graham
ngraham added a comment. Shall we land this, or are there any other objections? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, Z

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 124 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/124/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 16:07:38 + Build duration: 2 min 23 sec and counting CONSOLE

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 156 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/156/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 16:02:53 + Build duration: 7 min 5 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 125 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/125/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 16:07:38 + Build duration: 1 min 22 sec and counting

D12577: Allowing KAMD to run without a database backend

2018-04-30 Thread David Edmundson
davidedmundson added a comment. > ivan created this revision.Sat, Apr 28, 2:06 PM > This revision was not accepted when it landed; it landed in state Needs Review.Sun, Apr 29, 2:21 PM I don't mind you merging if no-one bothers reviewing your changes, but expecting that in 24 hours is a

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. In D12606#255923 , @davidedmundson wrote: > It is not "dead" however it is now restricted to fixes for major bugs such as security and data loss. Ok, I don't think this qualifies then... REPOSITORY R120 Plasma

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread David Edmundson
davidedmundson added a comment. It is not "dead" however it is now restricted to fixes for major bugs such as security and data loss. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12606 To: wbauer, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragree

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. Forgot to ask: should I cherry-pick this to the 5.8 branch too? Or is that completely dead already anyway? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12606 To: wbauer, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen,

D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update

2018-04-30 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY flatpak_installation_list_installed_refs_for_

D10747: Implement zwp_linux_dmabuf_v1

2018-04-30 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > linuxdmabuf_v1_interface.cpp:364 > + > +static void unbind(wl_client *client, wl_resource *resource); > +static void createParamsCallback(wl_client *client, wl_resource > *resource, uint32_t id); is this defined? I can't find it I

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 264 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/264/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 11:48:31 + Build duration: 2 min 4 sec and counting CONSOLE

KDE CI: Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9 - Build # 98 - Failure!

2018-04-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20stable-kf5-qt5%20FreeBSDQt5.9/98/ Project: Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 30 Apr 2018 11:47:46 + Build duration: 1 min 20 sec and counting

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R120:608204765110: [ksmserver] Use QUrl::fromUserInput to construct sound url (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12606?vs=3330

Notes from Sprint - Plasma Browser Integration

2018-04-30 Thread David Edmundson
Plasma Browser Integration has a host part and a client (chrome/firefox extension) part. The host must be installed by distros, The plan of action we've agreed upon is that we (by default) won't install the client part. We'll encourage distros to install the host part by default. The host part wi

Notes from Sprint - Input stuff

2018-04-30 Thread David Edmundson
As you may know, we had the lead dev of the new Qt input stack at the sprint, with one goal to show all the really unusual things we do with input and trying to make sure the new stack can handle them. The new stack really isn't there for mouse input as-is; and won't be in 5.11 either. My gut feel

D12481: Add dptr to models

2018-04-30 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R994:0abe8778072a: Add dptr to models (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32924&id=33315 REVISION DETAIL

D12481: Add dptr to models

2018-04-30 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in models_p.h:26 > Do we need an explicit `Q_DECL_HIDDEN` or something? No. That's only needed for when people do class AbstractModel::Pr