D12086: [OSD] Enforce plain text

broulik added a comment. > where do we put third party data in an OSDItem - `mediaPlayerVolumeChanged` takes `playerName` which is shown when muted - `kbdLayoutChanged` takes `layoutName` - `virtualDesktopChanged` takes `currentVirtualDesktopName` and most importantly -

D12103: Support snap permissions in Discover

ngraham added a comment. Also those labels are not very descriptive; are there better strings available? Looking at the screenshots, I have no idea what most of those permissions actually do. A regular user would be even more confused. REPOSITORY R134 Discover Software Store REVISION DETA

D12103: Support snap permissions in Discover

ngraham added a comment. +1 for the feature, but could we use checkboxes instead of toggles? I'm not real thrilled with the ones in those screenshots. It's not at all clear what's on and what's off. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D121

D12103: Support snap permissions in Discover

apol added a comment. F5803518: Screenshot_20180411_024622.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12103: Support snap permissions in Discover

apol added a comment. F5803515: Screenshot_20180411_024501.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12103: Support snap permissions in Discover

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D12103 AFFECTED FI

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 31846. zzag added a comment. Because this patch hasn't been landed yet, I would like to post here my recent work on optimizing the box shadow helper... Summary of changes: - re-write naive blur helper - modify only alpha channel in blur helpers

D12102: Port Language KCM to Qt Quick

hein added subscribers: ngraham, abetts. hein added a comment. Note: The screenshots don't look like the mockup in T7247 because that's outdated. The VDG channel had a long discussion about the KCM a few weeks ago and decided on a single list + modal dialo

D12102: Port Language KCM to Qt Quick

hein added a comment. Some shots: F5803407: Screenshot_20180411_072428.png F5803409: Screenshot_20180411_072443.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102

D12102: Port Language KCM to Qt Quick

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Changed the overall design from two lists to one list wit

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 10 Apr 2018 21:42:00 + Build duration: 46 sec and counting CONSOLE OUTPUT [

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provider

kossebau added a comment. If there are no further comments, will push on Fri, April 13th. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11978 To: kossebau, xuetianweng Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D11964: [potd dataengine] Enable development of 3rd-party potd provider plugins

kossebau added a comment. If noone objects, will push on Fri, April 13th. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11964 To: kossebau, xuetianweng Cc: richardbowen, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 10 Apr 2018 21:23:40 + Build duration: 43 sec and counting CONSOLE OUTPUT [

D11954: [potd dataengine] Turn prodiver plugin metadata into json files

kossebau added a comment. If noone objects, will push on Fri, April 13th. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11954 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D11957: [potd dataengine] De-pimplify potd providers for more simple code

kossebau added a comment. If noone objects, will push on Fri, April 13th. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11957 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

String freeze exception for Plasma/5.12 (documentation)

Hi, I'd like to request an exception for the documentation of kcmsmserver in Plasma/5.12, and namely the backport of this review: https://phabricator.kde.org/D11817 which fixes various references to Plasma instead of KDE. Given the LTS nature of Plasma 5.12 I think it's worth doing it. Comments

D12097: Make room for footer and header.

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added projects: Kirigami, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. hein requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAI

D12092: Add plasmashell --replace

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good otherwise. INLINE COMMENTS > main.cpp:107 > > +QCommandLineOption > replaceOption(QStringList({QStringLiteral("replace")}), > + i18n("Replace a

D12056: Don't have a non-integral size on separators

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2c09d61d736c: Don't have a non-integral size on separators (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12056?vs=31795&id=31833 REVISION DET

D12080: Don't show the actions if they are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b22a3b0c52af: Don't show the actions if they are disabled (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12080?vs=31793&id=31831 REVISION DETA

D12081: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R169:18228385e172: Fix warning (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12081?vs=31794&id=31832 REVISION DETAIL https://phabricator.kde.org/

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 10 Apr 2018 17:24:33 + Build duration: 5 min 35 sec and counting CONSOLE OUTPUT

D12092: Add plasmashell --replace

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Calls the existing quit signal on a running p

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 Rog131 changed: What|Removed |Added CC||s.oosth...@xs4all.nl --- Comment #25 from Rog131 ---

D12086: [OSD] Enforce plain text

davidedmundson added a comment. Change is fine, but where do we put third party data in an OSDItem? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12086 To: broulik, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D12090: port the look and feel kcm to new design

davidedmundson added a comment. Same comments as the other one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12090 To: mart, #plasma, #vdg Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D12088: port the ksplash kcm to the new design

davidedmundson added a comment. I like patches with more red than green. It's a very positive sign ++ Minor comments below INLINE COMMENTS > main.qml:51 > +kcm.selectedPlugin = model.pluginName; > +view.currentIndex = index; > +view.forceActiveFocus();

D12090: port the look and feel kcm to new design

mart added a comment. F5802963: Spectacle.eJ4587.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12090 To: mart, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D12090: port the look and feel kcm to new design

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use the new design for the look and feel kcm, together with a massive cod

D12088: port the ksplash kcm to the new design

mart added a comment. F5802937: Spectacle.E21294.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D12088: port the ksplash kcm to the new design

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY redically simplifying the code, port the ksplash kcm to the new design TES

D12086: [OSD] Enforce plain text

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN 5.8 branch as it's potentially security-relevant (img tag) like the noti

D11850: modernize: use auto

davidedmundson added a comment. I was saying you can push this now you've done it, but I wouldnt' go about changing other bits of code elsewhere. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11850 To: zzag, #breeze, davidedmundson Cc: davidedmundson, plasma-devel,

D11175: [kstyle] refine shadows

zzag updated this revision to Diff 31810. zzag added a comment. Rebase. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=30238&id=31810 BRANCH refine-shadows-kstyle REVISION DETAIL https://phabricator.kde.org/D11175 AFFECTED FILES kstyle/CMake

D11069: [kdecoration] refine shadows

zzag updated this revision to Diff 31809. zzag added a comment. Rebase. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29540&id=31809 BRANCH refine-shadows-kdecoration REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES kdecora

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 31808. zzag added a comment. Rebase. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=29989&id=31808 BRANCH refine-shadows-libbreezecommon REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FILES CMa

D11981: [Image Wallpaper] Fix blur

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d34a9e23eddd: [Image Wallpaper] Fix blur (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11981?vs=31468&id=31806 REVISION DETAIL h

D11533: [kstyle] create shadow tiles more explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit R31:a4131c5d4024: [kstyle] create shadow tiles more explicitly (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11533?vs=31802&id=31805 REVISION DETAIL

D11533: [kstyle] create shadow tiles more explicitly

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH explicit-shadow-creation REVISION DETAIL https://phabricator.kde.org/D11533 To: zzag, #breeze, hpereiradacosta Cc: plasma-dev

D12083: Show OSD when default output changes

This revision was automatically updated to reflect the committed changes. Closed by commit R115:893ee005b120: Show OSD when default output changes (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12083?vs=31800&id=31804

D11533: [kstyle] create shadow tiles more explicitly

zzag updated this revision to Diff 31802. zzag added a comment. Trigger creation of shadow tiles in `loadConfig()`. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11533?vs=31774&id=31802 BRANCH explicit-shadow-creation REVISION DETAIL https://phabricato

D12083: Show OSD when default output changes

broulik updated this revision to Diff 31800. broulik edited the test plan for this revision. broulik added a comment. - Use default sink instead of preferred sink as the latter also changes depending on where music is being played REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LA

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

davidedmundson added a comment. Either things are consistent or not consistent with other applets. That is a yes/no case. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11558 To: davidedmundson, #plasma Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

rkflx added a comment. In D11558#243632 , @davidedmundson wrote: > We're at an impasse then. Only if you make this a yes/no decision. There are still options for a compromise which would fit both use cases. > by default it's current

D11558: Don't show cache memory in systemloadviewer bars

davidedmundson added a comment. We're at an impasse then. I do like and respect having your feedback, but I'm not particularly swayed. It leaves this one super tiny summary applet showing more "detailed/noisy" information than the full on ksysguard application, which doesn't make sense

D11986: [potd wallpaper] Add missing Messages.sh, use wallpaper catalog name

This revision was automatically updated to reflect the committed changes. Closed by commit R114:79377f8a206f: [potd wallpaper] Add missing Messages.sh, use wallpaper catalog name (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1198

D12083: Show OSD when default output changes

davidedmundson added a comment. Very nice +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D12083 To: broulik, #plasma, #vdg, drosca Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D12083: Show OSD when default output changes

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ListItemBase.qml:284 > menuItem.clicked.connect(function() { > +paSinkModel.pendingPreferredSinkChange = true; >

Upcoming CI changes - service disruption

Hi all, In order to allow for two replacement physical build hosts to be rotated in and the old ones to be decommissioned, i'm scheduling some downtime for both the CI system and the Binary Factory tomorrow. Assuming all goes well, this downtime should be fairly short. During the downtime Jenkins

D12083: Show OSD when default output changes

broulik created this revision. broulik added reviewers: Plasma, VDG, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the default output changes because a device is pl

D12056: Don't have a non-integral size on separators

apol updated this revision to Diff 31795. apol added a comment. - Don't show the actions if they are disabled REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12056?vs=31792&id=31795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12056 AFF

D12081: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY .../kirigami.2/ScrollablePage.qml:160: TypeError: Cannot assign to read

D12080: Don't show the actions if they are disabled

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise you get a dummy button that does nothing REPOSITORY R169 K

D12056: Don't have a non-integral size on separators

apol updated this revision to Diff 31792. apol added a comment. - Don't show the actions if they are disabled REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12056?vs=31711&id=31792 BRANCH disabledActions REVISION DETAIL https://phabricator.kde.org/D1

D11533: [kstyle] create shadow tiles more explicitly

hpereiradacosta added a comment. In D11533#243511 , @zzag wrote: > Well, after thinking for a while, I think shadowTiles should be called in loadConfig. It doesn't make much sense to create something in reset method. I agree REPOSITORY

D11991: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R858:9c0c690188a7: Fix warning (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11991?vs=31510&id=31789 REVISION DETAIL ht