Re: Keyboard Layout notification on Wayland

Am 6. April 2018 18:15:47 MESZ schrieb Aleix Pol : >Hey, >Since I moved to wayland instead of seeing an item on the tray with >the layout I see a keyboard. The behavior is right but the fact that I >just see a keyboard that doesn't tell me much pushed me to see if we >could gain back the behavior

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

alexeymin added a comment. On wayland, without this patch with OpenGL 3.2 version requested, it fails with error: F5796592: wayland before.png and outputs in terminal: Could not get requested OpenGL profile, requested QSurfaceFormat::OpenGLCo

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

alexeymin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. alexeymin requested review of this revision. REVISION SUMMARY Removing the requirement of 3.2 version just fixes it for my AMD RX560 on amdgpu opensource dri

D11876: Display star ratings

ngraham added a comment. Yea/nay on this design? Should we tweak it a bit more? REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: fabianr, ragreen, acrouthamel, plasma-devel, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abe

D11989: [Notifications] Always scroll to the top when opening

davidedmundson added a comment. If you're working round a Qt bug, I'd like a bug reported and in the comment please INLINE COMMENTS > main.qml:82 > +historyList.positionViewAtBeginning(); > +historyList.contentY = Qt.binding(function() { > +return -his

D12000: [ProcessModel] Return invalid QVariant() for when window is not known

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This communicates "unknown" better than a zero. The KSysGuardProce

D3484: Center systemmonitor window properly on multi-screen setup

cfeck added a comment. > If the application will set it's own geometry, then it'll still cause conflicts with (potential) KWin rules No, the KWin rules are a mean to override (or ignore) what applications set. An application shouldn't rely on KWin rules to deliver the user experience. R

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. In D3484#239893 , @cfeck wrote: > It is the application that sets the window size. Since the initial size is likely wrong, applications usually remember sizes of windows and important dialogs. If the applicat

D11991: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY .../qml/QtQuick/Controls.2/org.kde.desktop/ToolBar.qml:37: Refer

Re: Keyboard Layout notification on Wayland

​It's come up before. Everyone is fine with it, there's a task in one of the kwin boards somewhere. Having a UI that matches the other plasmoids on click would also be good. There's some code in the lockscreen that can be re-used. It needs checking with Eike who also has IM plans, IIRC that was o

Keyboard Layout notification on Wayland

Hey, Since I moved to wayland instead of seeing an item on the tray with the layout I see a keyboard. The behavior is right but the fact that I just see a keyboard that doesn't tell me much pushed me to see if we could gain back the behavior we have on X11. I saw that this code moved to kwin, my f

D11970: Fix typo in the kcm_desktoptheme edit theme tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:85416dd8ef30: Fix typo in the kcm_desktoptheme edit theme tooltip (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11970?vs=31420&id=31503

D11989: [Notifications] Always scroll to the top when opening

broulik updated this revision to Diff 31501. broulik added a comment. - Also use `positionViewAtBeginning` as `contentY` alone doesn't really work with the way `ListView` works REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11989?vs=31500&id=31501

D11989: [Notifications] Always scroll to the top when opening

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The more important recent stuff is at the top. BUG: 39164

D11966: Remove one more kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0c4fd8a5e629: Remove one more kdelibs4support (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11966?vs=31407&id=31497 REVISIO

D11375: Don't block evaluating DBus scripts if widgets are locked.

Zren added a comment. Um, `if (immutability() != Plasma::Types::SystemImmutable) { return; }` was pushed. You're last revision https://phabricator.kde.org/D11375?id=30006 had it correctly. `if (immutability() == Plasma::Types::SystemImmutable) { return; }` REPOSITORY R120 Plasma Work

D11986: [potd wallpaper] Add missing Messages.sh, use wallpaper catalog name

kossebau added a comment. Target: 5.12 branch, to fix missing translations REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11986 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11986: [potd wallpaper] Add missing Messages.sh, use wallpaper catalog name

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH translationforpotdwallpaper REVISI

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

This revision was automatically updated to reflect the committed changes. Closed by commit R114:458f4387f825: [potd wallpaper] Config UI: fix spacing between UI elements (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11983?vs=3148

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

abetts added a comment. +1 REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION DETAIL https://phabricator.kde.org/D11983 To: kossebau, xuetianweng, ngraham, davidedmundson Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D11919: support for standalone ksplash themes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:465e86ee7b94: support for standalone ksplash themes (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11919?vs=31470&id=31489#toc REPOSITORY R119 Plasma Desktop CHANGES SIN

D11985: [KRunner] Don't add to history items that start with a space

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b1ec23bc615b: [KRunner] Don't add to history items that start with a space (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11985?vs=3

D11985: [KRunner] Don't add to history items that start with a space

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This mimics shell prompt behavior. BUG: 392762 FIXED-IN: 5.

D11928: fade to blue when the login box appears

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D11928#241045 , @mart wrote: > tough i'm not sure in the login screen makes sense to not show controls by default? Right, that's

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That looks sane to me visually. The QML change is sane too. REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION DETAIL https://phabricator.kde.org/D11983 To: kosseba

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. Guess I better leave the rows as they are, to also follow current config UI logic of the plasma-workspace wallpaper plugins. But fixing at least the missing vertical spacing, making it look like this: F5795203: Screenshot_20180406_150633.png

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau updated this revision to Diff 31486. kossebau added a comment. one step at a time: keep old Rows and just switch to ColumnLayout REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11983?vs=31481&id=31486 BRANCH improvepotdconfigui REVISION DE

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. > It's saying the maximum size is the size it currently is; which is true for all values simultaneously. The idea is to make sure the size stays at the value calculated by `formAlignment - units.largeSpacing` (`formAlignment` being injected here by the wallpape

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

davidedmundson added inline comments. INLINE COMMENTS > config.qml:68 > QtControls.Label { > +Layout.minimumWidth: width > +Layout.maximumWidth: width This doesn't make sense. It's saying the maximum size is the size it currently is; which is true for all value

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau added a comment. New look: F5795019: Screenshot_20180406_140546.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11983 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau updated this revision to Diff 31481. kossebau added a comment. add missing bump of QtQuick.Controls version for autoresize of comboboxes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11983?vs=31480&id=31481 BRANCH improvepotdconfigui REV

D11983: [potd wallpaper] Config UI: fix spacing between UI elements

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH improvepotdconfigui REVISION DETAI

D11919: support for standalone ksplash themes

mart added a comment. In D11919#240505 , @davidedmundson wrote: > There seems to be two perfectly viable long term strategies we're looking at: > > - We use LnFs everywhere and filter everywhere (what we were doing for splash) ok, s

D11919: support for standalone ksplash themes

mart updated this revision to Diff 31470. mart added a comment. - use lnf packages for splashscreen REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11919?vs=31282&id=31470 BRANCH mart/ksplashGhns REVISION DETAIL https://phabricator.kde.org/D1191

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provider

kossebau added a comment. In D11978#240976 , @ngraham wrote: > Can confirm that it works again, yay! +1 for that. Thanks for testing. > Is there really no longer a working feed or some sort for this? None that I had found at leas

D11981: [Image Wallpaper] Fix blur

broulik updated this revision to Diff 31468. broulik added a comment. - Always render background when blur is not loaded regardless of why (fill mode or config) - use `PreserveAspectCrop` for blur as it was in the old code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE http

D11981: [Image Wallpaper] Fix blur

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This broke in the transition to `StackView` as the

D11928: fade to blue when the login box appears

mart added a comment. tough i'm not sure in the login screen makes sense to not show controls by default? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11928 To: mart, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, richardbowen, ngraham, plasma-devel,

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik added a comment. Looks good > I don't know how to make the result of the action available to the MMB (middle mouse button). `QClipboard::setText()` has a `mode` argument that specifies which buffer it should use. Default is `QClipboard::Clipboard` (the Ctrl+V one), just