D11978: [potd dataengine] Fix Wikimedia Picture of the Day provicer

ngraham added a comment. Can confirm that it works again, yay! +1 for that. Is there really no longer a working feed or some sort for this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11978 To: kossebau, xuetianweng Cc: ngraham, plasma-devel, ragreen, Pite

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provicer

kossebau added a comment. Target branch: 5.12 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11978 To: kossebau, xuetianweng Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provicer

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The used service no longer existed. While the pointers lis

D6183: [Digital Clock] Allow copying current date and time to clipboard

sharvey added a comment. I read this (unfortunately unpleasant) bug report the other day and was just asking on IRC how to put data the clipboard. I'll be studying this closely - nice work! REVISION DETAIL https://phabricator.kde.org/D6183 To: bschiffner, #plasma, broulik Cc: sharvey, dav

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner added a comment. ping ... Kai Uwe, David any ideas how to proceed with the change last week? Bernhard REVISION DETAIL https://phabricator.kde.org/D6183 To: bschiffner, #plasma, broulik Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

Zren abandoned this revision. Zren added a comment. Yep, D4751 was used instead. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 To: Zren, #plasma:_design, #plasma Cc: broulik, davidedmundson, drosca, coloma

D11970: Fix typo in the kcm_desktoptheme edit theme tooltip

Zren created this revision. Zren added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Got missed during the D8006 cod

D11928: fade to blue when the login box appears

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11928 To: mart, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, richardbowen, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D11928: fade to blue when the login box appears

davidedmundson added a comment. > We can continue this discussion in the follow-up SDDM theme patch though, but it's something to keep in mind. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11928 To: mart, #plasma, #vdg, ngraham Cc: davidedmundson, rich

D11928: fade to blue when the login box appears

ngraham added a comment. I love it! This solves the problems we set out to solve and it looks fantastic. Just a few remaining comments: - The commit message and summary need to be updated to reflect the latest changes - I'm still not a huge fan of how the interactive UI elements d

D11928: fade to blue when the login box appears

mart updated this revision to Diff 31410. mart added a comment. - bigger clock REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11928?vs=31408&id=31410 BRANCH mart/newlockscreen REVISION DETAIL https://phabricator.kde.org/D11928 AFFECTED FILES

D11928: fade to blue when the login box appears

mart updated this revision to Diff 31408. mart added a comment. - add precisions to make it work on GLES REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11928?vs=31406&id=31408 BRANCH mart/newlockscreen REVISION DETAIL https://phabricator.kde.

D11928: fade to blue when the login box appears

ngraham added a comment. OK, fair enough. Maybe we could just make the clock + date a bit bigger in general, and not animate it? Here's how it looks with 48pt clock text and 24pt date text (up from 32 and 18), and `spread: 0.2`: F5791749: Spectacle.Hf4100.png

D11966: Remove one more kdelibs4support

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Using the DBus API directly is done in both p

D11928: fade to blue when the login box appears

mart updated this revision to Diff 31406. mart added a comment. - whitespaces fixes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11928?vs=31392&id=31406 BRANCH mart/newlockscreen REVISION DETAIL https://phabricator.kde.org/D11928 AFFECTED

D11928: fade to blue when the login box appears

mart added a comment. i tried to scale the clock (just the time, not the date) F5791700: Spectacle.fB7458.png not sure if i like how it looks, the animations looks very.. wonky... however one thing that has to be kept in mind is that animating the sc

D11928: fade to blue when the login box appears

ngraham added inline comments. INLINE COMMENTS > SessionManagementScreen.qml:66 > > - > UserList { Unrelated whitespace change > LockScreenUi.qml:130 > > - > StackView { Unrelated whitespace change > LockScreenUi.qml:224 > +anchors.fill: parent > +

D11964: [potd dataengine] Enable development of 3rd-party potd provider plugins

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Installing the headers of libplasmapotdprovidercore in the

D11961: Add QtQuickSettings

broulik planned changes to this revision. broulik added a comment. Right, didn't think of that, will update the patch to do it in main instead REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11961 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ragreen

D11961: Add QtQuickSettings

davidedmundson added a comment. We have a tonne of KCMs that are also in QtQuick. It might be best in the main app and in kcmshell. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11961 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, Z

D11961: Add QtQuickSettings

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN [QtQuickRendererSettings] SceneGraphBackend=software Verified

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 133 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/133/ Project: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 14:10:27 + Build duration: 5 min 14 sec and counting JUnit Tes

D11928: fade to blue when the login box appears

ngraham added a comment. Nice, I like this much better. Blurring and darkening the background when the controls are shown solves the legibility problem for the Switch User button and the default avatar picture, nice! And the drop shadow around the Clock hugely improves legibility there too.

D11959: Add DashCards Shadow and News Card Hyperlinks

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:d7e547177f00: Add DashCards Shadow and News Card Hyperlinks (authored by Aiix). REPOSITORY R846 Mycroft Plasma integ

D11959: Add DashCards Shadow and News Card Hyperlinks

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T7175 Added dropshadows to dashboar

D11957: [potd dataengine] De-pimplify potd providers for more simple code

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY There is no need to use pimpl for non-public-API classes.

D11919: support for standalone ksplash themes

davidedmundson added a comment. We're going to see this again for lockscreen, logout, osd, previews, runcommand and the 3 kwin bits. Is it still the long term plan for lnfs to have these? It's fine if that's purely backwards compatibility, but it's a whole different story to have a pl

D11928: fade to blue when the login box appears

mart added a comment. look of the latest version https://www.youtube.com/watch?v=VMRzbWZCTJE REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11928 To: mart, #plasma, #vdg, ngraham Cc: richardbowen, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D11928: fade to blue when the login box appears

mart updated this revision to Diff 31392. mart added a comment. - just blur and darken the background REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11928?vs=31303&id=31392 BRANCH mart/newlockscreen REVISION DETAIL https://phabricator.kde.org

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Could you add a code comment about why this is not an issue, similar to the description? If two far-removed places of code depend on each other indirectly and by design it warrants a comment so

D11950: Remove traces of polkit-kde-authorization tool

This revision was automatically updated to reflect the committed changes. Closed by commit R121:3791346b2843: Remove traces of polkit-kde-authorization tool (authored by broulik). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11950?vs=313

D11947: [Folder View] Use KStandardAction for rename, delete, and trash

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eab41217209b: [Folder View] Use KStandardAction for rename, delete, and trash (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11947?vs=

D11953: [Folder View] Set shortcut on plasmoid.action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:94aee349c346: [Folder View] Set shortcut on plasmoid.action (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11953?vs=31380&id=31388 RE

D11944: [Folder View] Update "Empty Trash" enabled state for files inside Trash and links to Trash

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7e98c5d737eb: [Folder View] Update "Empty Trash" enabled state for files inside Trash and… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D11927: [System Model] Support actions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf12647c6002: [System Model] Support actions (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11927?vs=31299&id=31384 REVISION DETAIL

D11946: [Folder View] Simplify clearing of lists

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dadb306d4299: [Folder View] Simplify clearing of lists (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11946?vs=31358&id=31386 REVISIO

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY While both actions are added to the collection, only one is s

D11954: [potd dataengine] Turn prodiver plugin metadata into json files

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The desktop files are only used at buildtime, so given the

D11953: [Folder View] Set shortcut on plasmoid.action

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures the shortcuts are shown in the menu. We need to acc

D11952: [potd dataengine] Remove unused X-KDE-PlasmaPoTDProvider-SuffixType

This revision was automatically updated to reflect the committed changes. Closed by commit R114:64433ca70996: [potd dataengine] Remove unused X-KDE-PlasmaPoTDProvider-SuffixType (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11952

D11952: [potd dataengine] Remove unused X-KDE-PlasmaPoTDProvider-SuffixType

kossebau created this revision. kossebau added a reviewer: xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Not used by code at least since this dataengine was moved

KDE CI: Plasma plasma-workspace stable-kf5-qt5 SUSEQt5.9 - Build # 98 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20stable-kf5-qt5%20SUSEQt5.9/98/ Project: Plasma plasma-workspace stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Apr 2018 10:30:52 + Build duration: 28 min and counting JUnit

D11950: Remove traces of polkit-kde-authorization tool

fvogt accepted this revision. fvogt added a comment. I don't even have that binary installed and no package contains it here - probably some legacy KDE4 stuff. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D11950 To: broulik, davidedmundson, fv

D11950: Remove traces of polkit-kde-authorization tool

broulik created this revision. broulik added reviewers: davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's been unmaintained for almost a decade now and e

D11919: support for standalone ksplash themes

mart added a comment. In D11919#239962 , @davidedmundson wrote: > What do we need the different package root for? > Just for making sure it's not selected in the lnf KCM? yes, to not list in lnf any of those that have splashscreen onl

KDE CI: Plasma plasma-workspace stable-kf5-qt5 SUSEQt5.9 - Build # 97 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20stable-kf5-qt5%20SUSEQt5.9/97/ Project: Plasma plasma-workspace stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 16:40:30 + Build duration: 15 hr and counting CONSOLE

D11947: [Folder View] Use KStandardAction for rename, delete, and trash

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures the keyboard shortcut is visible in the menu CCB

KDE CI: Plasma xdg-desktop-portal-kde kf5-qt5 SUSEQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20xdg-desktop-portal-kde%20kf5-qt5%20SUSEQt5.9/17/ Project: Plasma xdg-desktop-portal-kde kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Apr 2018 07:25:00 + Build duration: 2 min 18 sec and counting JU

KDE CI: Plasma xdg-desktop-portal-kde kf5-qt5 FreeBSDQt5.9 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20xdg-desktop-portal-kde%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Plasma xdg-desktop-portal-kde kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 07:25:00 + Build duration: 2 min 1 sec and counting

D11946: [Folder View] Simplify clearing of lists

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids triple lookup (contains → value → remove) `take()` r

D11944: [Folder View] Update "Empty Trash" enabled state for files inside Trash and links to Trash

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Previously this was only done for files inside Trash. Now als